Koha-clms/circ
Benjamin Rokseth 3b63cab416 Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio
This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both slips
6) also note that there is no itemnumber or barcode in the requests from returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a2b9db00cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-06-07 09:36:02 +02:00
..
add_message.pl Bug 3669: Remove parameters passed to action of form 2016-06-24 13:20:14 +00:00
article-request-slip.pl Bug 17762: Send lang to GetPreparedLetter 2017-05-09 20:56:41 +00:00
article-requests.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
bookcount.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
branchoverdues.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
branchtransfers.pl Bug 19059: Fix compilation issues 2017-09-12 12:42:59 -03:00
circulation-home.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
circulation.pl Bug 20067: Fix other checks for linked authorised value categories 2018-04-23 22:31:43 +00:00
del_message.pl Bug 15632: Koha::Patron::Messages - Remove DeleteMessage 2016-03-03 21:22:13 +00:00
hold-transfer-slip.pl Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-07 09:36:02 +02:00
offline-mf.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
offline.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
on-site_checkouts.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
overdue.pl Bug 19438: Fix sorting by date due in overdues.pl 2017-10-13 13:58:04 -03:00
pendingreserves.pl Bug 18079: Holds to pull cleanup 2017-02-14 13:48:34 +00:00
renew.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
request-article.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
reserveratios.pl Bug 15685: Avoid "Use of uninitialized value" warning in logs 2017-10-11 13:08:47 -03:00
returns.pl Bug 20003: (QA follow-up) use patron checkouts method instead of Koha::Checkouts 2018-02-02 14:43:58 +00:00
selectbranchprinter.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
transfer-slip.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
transferstoreceive.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
view_holdsqueue.pl Bug 18881: [QA Follow-up] Remove even more 2017-07-06 14:29:04 -03:00
waitingreserves.pl Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
ypattrodue-attr-search-authvalue.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
ysearch.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00