gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,621 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Benjamin Rokseth 3b63cab416 Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 
This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both slips
6) also note that there is no itemnumber or barcode in the requests from returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a2b9db00cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2018-06-07 09:36:02 +02:00
C4 Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-07 09:36:02 +02:00
Koha Bug 20767: Display a stack trace when a method is not covered by tests 2018-06-06 14:01:13 +02:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 20861: Correct EDI permissions on EDI messsages 2018-06-07 09:23:36 +02:00
admin Bug 20383: Hide link to plugin management if plugins are not enabled 2018-04-23 22:24:07 +00:00
api/v1 Bug 7317: (QA followup) Make query parameters consistent with other endpoints 2017-11-09 11:42:16 -03:00
authorities Bug 19583: Remove use of C4::AuthoritiesMarc 2018-05-14 13:19:48 +00:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 20067: Fix other checks for linked authorised value categories 2018-04-23 22:31:43 +00:00
cataloguing Bug 18593: Move suggestions when bibliographic records are merged 2018-04-23 22:29:01 +00:00
circ Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-07 09:36:02 +02:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-02-02 15:01:33 +00:00
debian Bug 19546: (QA follow-up) Make the returning cd more fool proof 2018-05-22 09:58:12 +00:00
docs Bug 7143: Update about page for new dev - Victor Grousset 2017-12-14 14:01:58 +00:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 19739: Add default ES configuration to koha-conf.xml 2018-04-24 00:15:57 +00:00
ill Bug 20556: Marking ILL request as complete.. 2018-05-22 10:15:22 +00:00
installer Increment version for 17.11.06 release 2018-05-22 07:52:58 -04:00
koha-tmpl Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-07 09:36:02 +02:00
labels Bug 19681: Correct result count formatting 2017-12-14 11:14:05 +00:00
members Bug 20701: (17.11 follow-up) Move csrf token after checkauth and use 2018-05-23 14:59:19 +00:00
misc Update release notes for 17.11.06 release 2018-05-22 12:06:47 +00:00
offline_circ Bug 19771: Fix crashing in pending offline circulation actions list 2018-01-23 02:00:20 +00:00
opac Bug 20763: Remove unecessary Koha::Patron fetch 2018-06-07 09:16:27 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 18541: (QA follow-up) Fix wrong variable name ($layout_xml vs $print_layout_xml) 2017-09-19 11:47:32 -03:00
plugins Bug 19088: plugins-upload causes error log noise 2017-08-30 15:05:56 -03:00
reports Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl 2018-02-22 00:59:34 +00:00
reserve Bug 18474: Restore multiple holds when patron is searched for 2018-05-14 14:05:17 +00:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 16:07:12 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20730: Move the authentication block before doing anything 2018-05-22 11:59:37 +00:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 18399: Add reasons in edit suggestion page 2017-10-11 13:05:39 -03:00
svc Bug 20088: Fix uninitialized warning from svc/holds 2018-02-02 15:09:40 +00:00
t Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-07 09:36:02 +02:00
tags Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20462: Ensure batch item deletion will not delete the same item twice 2018-05-14 14:14:14 +00:00
virtualshelves Bug 17214: Add records to lists by biblionumber 2017-10-27 14:10:26 -03:00
xt Bug 19262: Remove xt/author/pod_spell.t 2017-09-12 11:30:07 -03:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 17.11.06 release 2018-05-22 07:52:58 -04:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP
…
Makefile.PL Bug 7317: Interlibrary loans framework for Koha. 2017-11-09 11:42:12 -03:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 7317: Add partner_code checks to abot page 2017-11-09 11:42:14 -03:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo