gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,975 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
David Cook 35cbbd8de9 Bug 21005: Missing row/column defaults cause unexpected results in report wizards 
Some report wizards are missing row/column defaults, which sometimes return blank
pages (borrowers_stats.pl) or results always equalling 0, which a non-discerning
user may interpret incorrectly.

If the DEBUG environmental variable is enabled, missing row/column choices will
actually cause fatal software errors as well, which is also undesirable for users.

This patch adds default choices for row and column on
report wizards that had no radio buttons selected, so that a user
can't submit the form without choosing a row and column. This
prevents errors.

To test:
1) Apply patch
2) Visit /cgi-bin/koha/reports/issues_avg_stats.pl
3) Visit /cgi-bin/koha/reports/borrowers_stats.pl
4) Visit /cgi-bin/koha/reports/catalogue_stats.pl
5) Visit /cgi-bin/koha/reports/issues_stats.pl
6) Observe that default choices for row/column are there

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 6a451360b8)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 4edef31391)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2018-11-28 10:16:27 +01:00
C4 Bug 20592: Return early in ModItem if nothing to update 2018-11-28 10:10:15 +01:00
Koha Bug 21599: Fix item type creation by defining default values 2018-11-09 16:21:06 +01:00
OpenILS
…
acqui Bug 21587: don't drop patrons to notify in order creation 2018-11-26 07:27:32 +01:00
admin Bug 21417: EDI ordering fails when basket and EAN libraries do not match 2018-11-08 16:28:05 +01:00
api/v1 [17.11.x] correct duplicat keys in definitions.json 2018-11-02 15:18:20 +01:00
authorities Bug 21456: (QA follow-up) Catch missed case in authorities merge 2018-11-09 16:03:31 +01:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-24 11:41:37 +02:00
cataloguing Bug 20151: always use current language for stemming 2018-10-15 16:55:49 +02:00
circ Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems 2018-11-09 08:21:38 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-02-02 15:01:33 +00:00
debian Bug 17237: Remove CREATE USER 'user'@'%' line 2018-11-08 16:10:01 +01:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-28 07:44:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-09-21 11:57:55 +02:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-11 14:45:14 +02:00
installer Increment version for 17.11.12 release 2018-11-26 16:11:58 +01:00
koha-tmpl Bug 21005: Missing row/column defaults cause unexpected results in report wizards 2018-11-28 10:16:27 +01:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-24 11:52:13 +02:00
members Bug 21397: Mark "Routing list" tab as active when selected 2018-10-08 07:57:03 +02:00
misc Update release notes for 17.11.12 release 2018-11-26 16:25:42 +01:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-24 11:39:46 +02:00
opac Bug 21771: (follow-up) Revert the shift statement 2018-11-16 13:47:20 +01:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-28 15:13:11 +02:00
plugins Bug 19088: plugins-upload causes error log noise 2017-08-30 15:05:56 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-04 09:00:47 +02:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-08-27 14:45:26 +02:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 16:07:12 +00:00
rotating_collections Bug 21500: Remove warnings in rotating collections 2018-11-09 08:03:21 +01:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-10-10 12:07:06 +02:00
services
…
skel
…
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-09-21 12:14:19 +02:00
svc Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-11-09 09:33:39 +01:00
t Bug 20592: Add tests 2018-11-28 10:09:06 +01:00
tags Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
test
…
tmp/modified_authorities
…
tools Bug 21579: Make showdiffmarc.pl work for authorities and biblios 2018-11-09 15:03:03 +01:00
virtualshelves Bug 17214: Add records to lists by biblionumber 2017-10-27 14:10:26 -03:00
xt Bug 18959: Skip xt/author/Text_CSV_Various.t if Text::CSV::Unicode missing 2018-11-28 09:34:02 +01:00
.editorconfig
…
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Increment version for 17.11.12 release 2018-11-26 16:11:58 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 7317: Interlibrary loans framework for Koha. 2017-11-09 11:42:12 -03:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 7317: Add partner_code checks to abot page 2017-11-09 11:42:14 -03:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL
…
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl
…
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl
…
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo