gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 21320: Holds to pull should honor syspref AllowHoldsOnDamagedItems 

Test plan:

1. Set syspref AllowHoldsOnDamagedItems to Allow
2. Create a hold on record with item which is damaged
3. Verify that it doesn't appear in report
4. Apply patch and verify that it's now visible

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b23fe0b0b8)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 42e8d66369)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Dobrica Pavlinusic 2018-09-06 13:21:53 +02:00 committed by Fridolin Somers
parent f1afb946af
commit bb38fa0447
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
circ/pendingreserves.pl
View File

@ -91,6 +91,11 @@ if ($enddate_iso) {
my $item_type = C4::Context->preference('item-level_itypes') ? "items.itype" : "biblioitems.itemtype";
# Bug 21320
if ( ! C4::Context->preference('AllowHoldsOnDamagedItems') ) {
$sqldatewhere .= " AND damaged = 0";
}
my $strsth =
"SELECT min(reservedate) as l_reservedate,
reserves.borrowernumber as borrowernumber,
@ -130,7 +135,7 @@ my $strsth =
AND issues.itemnumber IS NULL
AND reserves.priority <> 0
AND reserves.suspend = 0
AND notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0
AND notforloan = 0 AND itemlost = 0 AND withdrawn = 0
";
# GROUP BY reserves.biblionumber allows only items that are not checked out, else multiples occur when
# multiple patrons have a hold on an item