gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
30,806 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Jonathan Druart 2aeacaa96e Bug 21230: Prevent Reserves.t to fail randomly 
The following test can fail if the hold has been generated with found => 'W':
 #   Failed test 'No tests run for subtest "_koha_notify_reserve() tests"'
 #   at t/db_dependent/Reserves.t line 675.
Can't call method "to_address" on an undefined value at
t/db_dependent/Reserves.t line 661.
 # Looks like your test exited with 255 just after 56.

We should call AddReserve instead.

Test plan:
0. Do not apply this patch
1. Do the following change:
    my $hold = $builder->build({
            source => 'Reserve',
            value => {
               borrowernumber=>$hold_borrower,
               found => 'W', # This line is added, do not forget the comma above
            }
        });
2. Prove it makes the test fail
3. stash the changes and apply this patch
4. Make sure the tests pass

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit c957b52ef8)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit c359d56f25)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2018-09-21 15:03:37 +02:00
C4 Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today 2018-09-21 12:24:45 +02:00
Koha Bug 18635: Koha::Patron->guarantees() should return results alphabetically 2018-09-21 14:32:12 +02:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 21033: Remove few warns in acqui/basket.pl 2018-09-21 14:18:02 +02:00
admin Bug 14446: Workaround to resolve uninitialized value in goto warning 2018-07-30 14:54:14 +02:00
api/v1 Bug 7317: (QA followup) Make query parameters consistent with other endpoints 2017-11-09 11:42:16 -03:00
authorities Bug 19583: Remove use of C4::AuthoritiesMarc 2018-05-14 13:19:48 +00:00
basket Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
catalogue Bug 20919: Remove unecessary search calls on the biblio detail page 2018-07-30 14:37:18 +02:00
cataloguing Bug 21053: Encode URI characters in plugin 008 2018-09-21 11:30:18 +02:00
circ Bug 21056: Add another flush later 2018-09-21 12:35:48 +02:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 19230: Preventing warn when deleting course 2018-02-02 15:01:33 +00:00
debian Bug 20795: Inform the user about this change, add to pod 2018-09-21 14:43:48 +02:00
docs Bug 20906: Prevent test failures due to stricter perl 2018-06-28 07:44:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 21031: Apache Rewrite rules don't work for API when using anything but Debian package Plack configuration 2018-09-21 11:57:55 +02:00
ill Bug 20556: Marking ILL request as complete.. 2018-05-22 10:15:22 +00:00
installer Bug 21077: Fix database documentation for statistics.type 2018-09-21 11:54:30 +02:00
koha-tmpl Bug 21164: Fix alignment on new basket form in acquisitions 2018-09-21 14:41:17 +02:00
labels Bug 19681: Correct result count formatting 2017-12-14 11:14:05 +00:00
members Bug 20008: Fix restrictions added from memberentry.pl if TimeFormat is 12hr 2018-07-18 16:17:04 +02:00
misc Bug 21035: Handle new lines when running reports 2018-09-21 14:10:59 +02:00
offline_circ Bug 19771: Fix crashing in pending offline circulation actions list 2018-01-23 02:00:20 +00:00
opac Bug 21018: Allow uris defined in the item 2018-08-28 15:17:48 +02:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-08-28 15:13:11 +02:00
plugins Bug 19088: plugins-upload causes error log noise 2017-08-30 15:05:56 -03:00
reports Bug 16653: (QA follow-up) Avoid a warning and remove unused variables 2018-07-04 09:00:47 +02:00
reserve Bug 20724: Move the ReservesNeedReturns logic to AddReserve 2018-08-27 14:45:26 +02:00
reviews Bug 19808: Handle deleted reviewers gracefully - reviews/reviewswaiting.pl 2017-12-21 16:07:12 +00:00
rotating_collections Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
serials Bug 20730: Move the authentication block before doing anything 2018-05-22 11:59:37 +00:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-09-21 12:14:19 +02:00
svc Bug 20760: Fill authorised values in svc framework 2018-06-18 08:01:48 +02:00
t Bug 21230: Prevent Reserves.t to fail randomly 2018-09-21 15:03:37 +02:00
tags Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 20564: Don't use system to unzip files 2018-09-20 16:10:18 +02:00
virtualshelves Bug 17214: Add records to lists by biblionumber 2017-10-27 14:10:26 -03:00
xt Bug 20906: Fix translatable-templates.t 2018-06-28 07:44:34 +02:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 21226: DBRev 17.11.09.001 2018-08-30 09:14:09 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 7317: Interlibrary loans framework for Koha. 2017-11-09 11:42:12 -03:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 7317: Add partner_code checks to abot page 2017-11-09 11:42:14 -03:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-10 13:51:33 +00:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-06-24 12:00:42 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo