gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 20760: Fill authorised values in svc framework 

To test:
 1 - Map a marc field to an authorised value in the default framework -
say 300$c -> CCODE
 2 - Open the advanced cataloguing editor
 3 - Create a new field 300$c - note there is no dropdown
 4 - browse to: /cgi-bin/koha/svc/cataloguing/framework?callback=define
 5 - Note the many instance of
Koha::Schema::ResultSet::AuthorisedValueCategory->HASH...
 6 - Apply patch
 7 - Restart memcached and plack
 8 - reload/recreate record in rancor
 9 - Note that 300$c is now a dropdown as expected
10 - repeate 4
11 - note the authorised values look correct in response

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit ac390bd228)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
This commit is contained in:
Jonathan Druart 2018-06-04 13:02:33 -03:00 committed by Fridolin Somers
parent df301bff9d
commit 4e240ba05a
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
svc/cataloguing/framework
View File

@ -6,6 +6,7 @@ use CGI;
use C4::ClassSource;
use C4::Context;
use C4::Biblio;
use C4::Koha;
use C4::Service;
use Koha::Database;
use Koha::Libraries;
@ -51,21 +52,9 @@ foreach my $class_source (sort keys %$class_sources) {
push @{ $authorised_values->{cn_source} }, { value => $class_source, lib => $class_sources->{$class_source}->{'description'} };
}
my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : "";
my $results;
if( $branch_limit ) {
$results = $schema->resultset( "AuthorisedValue" )->search(
{ "authorised_values_branches.branchcode" => { "=", [ $branch_limit, undef ] } },
{ join => "authorised_values_branches", order_by => "lib" } );
} else {
$results = $schema->resultset( "AuthorisedValue" )->search(
undef,
{ order_by => "lib" } );
}
foreach my $result ( $results->all ) {
$authorised_values->{$result->category} ||= [];
push @{ $authorised_values->{$result->category} }, { value => $result->authorised_value, lib => $result->lib };
my $avs = C4::Koha::GetAuthorisedValues();
for my $av ( @$avs ) {
push @{ $authorised_values->{$av->{category}} }, { value => $av->{authorised_value}, lib => $av->{lib} };
}
$response->param( framework => \@tags, authorised_values => $authorised_values );