Koha-clms/t/db_dependent
Jonathan Druart 91c087cebc Bug 17560: Hold fee placement at point of checkout
Currently, Koha charges all patrons a hold fee in all circumstances, if
a hold fee is applicable to their patron category.
This is immediately applied at point of request.
However, it would be useful to let patrons make requests without a
charge
being incurred until they physically have the item in their hands and
checked out to their cards.

The hold fee will only be added to the account  as soon as the item is
checked out to the requesting patron.
With this scenario, we will be certain that patrons have the correct
item, and they are happy with what has been supplied.
It also means that patrons can place holds via the OPAC without reaching
the usage limit that has been selected.

Test plan:
0/ All the following steps must be done with a patron using a patron category with a hold fee
1/ Make sure that the existing options for HoldFeeMode work as before
2/ Select the third option "any time a hold is collected"
3/ Place a hold on an item
4/ Note that the patron has not been charged
5/ Check this item from the staff interface
6/ Note that the patron has been charged
7/ Place another hold
8/ Use the self checkout feature at the OPAC for the checkin
9/ Note that the patron has been charged and a message is displayed to
inform about the fee.

Sponsored-by: Cheshire Libraries

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2017-03-31 12:06:04 +00:00
..
Acquisition Bug 18115 - Fix use of Objects as hashref in acqui/addorderiso2709.pl - Bug 15503 followup 2017-03-22 18:58:54 +00:00
Auth
…
Authorities Bug 18070: Extend sub merge to remove fields for deleted authorities 2017-03-03 18:12:09 +00:00
Biblio
…
Circulation Bug 18242: [SOLUTION 2]Add tests 2017-03-22 17:38:13 +00:00
Creators Bug 18044: Add a test 2017-02-07 17:46:00 +00:00
Exporter Bug 17196: [QA Follow-up] Wrong module in Record.t 2017-01-13 13:49:29 +00:00
Holds Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Items Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping 2016-10-21 15:23:06 +00:00
Koha Bug 17736: [Follow-up] Rename to current_holds 2017-03-31 12:02:14 +00:00
LDAP
…
Labels
…
Letters Bug 17971: Add support for objects represented by fk 2017-03-31 11:11:41 +00:00
Members Bug 18009 - IssueSlip.t test fails if launched between 00:00 and 00:59 2017-02-14 13:59:23 +00:00
OAI Bug 16172: fix OAI Server tests broken by bug 15946 2016-03-31 16:51:38 +00:00
Patron Bug 17486: [QA Follow-up] Changes as to set_userenv 2017-01-13 12:32:20 +00:00
Record Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests 2016-10-21 15:13:55 +00:00
Reports Bug 12787 [QA Followup] - Retain change to Reports_Guided.t 2016-04-22 00:54:36 +00:00
Reserves Bug 17560: Hold fee placement at point of checkout 2017-03-31 12:06:04 +00:00
SIP Bug 15006: Centralize timeout logic and allow zero client timeout 2016-07-15 14:11:05 +00:00
Search BUG 8010: Correct a few syntax errors, and moved tests 2017-03-22 19:01:28 +00:00
Serials Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Template/Plugin Bug 17796: Replace Koha::Issue[s] with Koha::Checkout[s] 2016-12-20 15:13:28 +00:00
Utils Bug 18094: Add tests to highlight the problem 2017-03-22 21:12:43 +00:00
XSLT_Handler
…
api/v1 Bug 17932: (followup) Fix /patrons endpoint 2017-02-17 15:33:00 +00:00
data
…
selenium Bug 13691: Add changes for 3.22 2016-07-08 20:36:57 +00:00
www Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t 2016-11-04 11:08:41 +00:00
00-strict.t
…
Accounts.t Bug 17894 - Remove and replace WriteOffFee 2017-01-19 11:15:26 +00:00
Acquisition.t Bug 18256: Koha::Items - Remove GetItemsCount 2017-03-22 19:18:15 +00:00
AdditionalField.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Amazon.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
ArticleRequests.t Bug 14610 - Add unit tests 2016-10-26 12:15:15 +00:00
AudioAlerts.t
…
Auth.t Bug 18275: Regression test 2017-03-20 13:00:01 +00:00
Auth_with_cas.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Auth_with_ldap.t Bug 17615 - Fix unit tests 2017-01-20 13:37:34 +00:00
AuthorisedValues.t Bug 17642: Do not explode if no authorised value exist 2016-11-18 15:52:01 +00:00
AuthoritiesMarc.t Bug 18014: QA follow-up: Use ok() instead of is() for '>' comparison 2017-02-14 14:01:11 +00:00
BackgroundJob.t Bug 17426: Do not set AutoCommit in tests 2016-10-21 14:34:21 +00:00
Barcodes.t Bug 15878 - Updated unit tests for hbyymmincr barcodes 2016-05-23 17:42:10 +00:00
Barcodes_ValueBuilder.t
…
Biblio.t Bug 18284: [QA Follow-up] Add test descriptions 2017-03-22 10:26:05 +00:00
Bookseller.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Breeding.t
…
Budgets.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
Charset.t Bug 18269: Move field mappings related code to Koha::FieldMapping[s] 2017-03-31 10:20:00 +00:00
Circulation.t Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods 2017-03-31 10:13:35 +00:00
ClassSource.t Bug 16860: Remove the comment about the warning 2016-07-08 13:29:50 +00:00
ColumnsSettings.t Bug 16177: Fix tests for ColumnsSsettings.t 2016-04-01 19:08:23 +00:00
Context.t Bug 16813: Allow empty string for OPACBaseURL 2016-07-15 15:02:13 +00:00
Contract.t Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
CourseReserves.t Bug 17716: (followup) Remove dep on existing data and tidy 2016-12-05 15:32:57 +00:00
DecreaseLoanHighHolds.t Bug 16387: Fix default shortened loan period time 2017-02-07 17:54:21 +00:00
Filter_MARC_ViewPolicy.t Bug 11592: Add should_hide_marc method to filter 2016-09-08 11:54:16 +00:00
Fines.t
…
FrameworkPlugin.t
…
Heading_MARC21.t
…
Hold.t Bug 14642: (QA followup) Add tests for Koha::Hold->delete 2016-08-17 18:43:13 +00:00
Holds.t Bug 17736: [QA Follow-up] Solve warning from qa tools on Holds.t 2017-03-31 12:02:15 +00:00
HoldsQueue.t Bug 17196: Move marcxml out of the biblioitems table 2017-01-13 13:49:26 +00:00
Holidays.t Bug 16376: (regression tests) 2016-12-09 15:25:01 +00:00
ILSDI_Services.t Bug 17836: (ILSDI) Regression test 2017-01-20 13:44:57 +00:00
ImportBatch.t Bug 9259: Use is instead of is_deeply 2016-07-08 13:43:53 +00:00
Installer.t Bug 17234: Need to separate KEY and FOREIGN KEY checks 2017-01-12 12:43:10 +00:00
Items.t Bug 17512: Improve handling dates in C4::Items 2017-02-14 13:57:49 +00:00
Items_DelItemCheck.t Bug 14504: Changes missed while fixing patches 2016-08-26 12:07:27 +00:00
KitchenSinkPlugin.kpz Bug 17368: Update KitchenSinkPlugin.kpz 2016-10-21 14:48:53 +00:00
Koha.t Bug 17627: Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes 2017-02-17 15:31:32 +00:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 17255 - Upgrade Elastic Search code to work with version 5.1 2017-02-07 17:17:54 +00:00
Koha_Elasticsearch_Indexer.t Bug 17372: Standardize Elasticsearch paths 2016-10-11 01:07:03 +00:00
Koha_Misc_Files.t
…
Koha_SearchEngine_Elasticsearch_Search.t Bug 18068: ES - Fix location and (home|holding)branch facets 2017-02-17 11:34:41 +00:00
Languages.t Bug 16866: Catch warning t/db_dependent/Languages.t 2016-07-08 14:50:18 +00:00
Letters.t Bug 17970: Add tests to highlight the problem 2017-03-31 11:10:57 +00:00
Linker_FirstMatch.t Bug 16868: Silence error t/db_dependent/Linker_FirstMatch.t 2016-08-04 20:04:24 +00:00
Log.t Bug 16829: Unit tests for logaction's 'interface parameter' 2016-08-17 18:01:50 +00:00
MarcModificationTemplates.t Bug 15669: Add a test for GetModificationTemplates 2016-03-03 22:11:44 +00:00
Members.t Bug 17578 [QA Followup] - Update number of tests 2016-12-16 13:14:50 +00:00
MungeMarcPrice.t Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search 2016-03-03 20:39:01 +00:00
NewsChannels.t Bug 17960: Rename opac_news.new with opac_news.content 2017-02-06 17:42:12 +00:00
Overdues.t Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
Passwordrecovery.t Bug 18025: Fix test 2017-02-17 11:24:39 +00:00
PatronLists.t Bug 17486: [QA Follow-up] Changes as to set_userenv 2017-01-13 12:32:20 +00:00
Patrons.t Bug 17742: Use TestBuilder to create the library and patron category 2016-12-28 13:34:21 +00:00
Plugins.t Bug 15879: Add Tests 2017-01-11 14:03:00 +00:00
QueryParser.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
Record.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 14048: (QA followup) Default to 1 if no default rule 2016-07-07 10:37:01 -06:00
Reports.t
…
Reserves.t Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds 2017-03-31 12:02:14 +00:00
RotatingCollections.t
…
Search.t Bug 17917: [QA Follow-up] Reprove Search.t 2017-01-20 13:39:36 +00:00
Serials.t Bug 15030: Add tests 2017-02-07 17:43:49 +00:00
Serials_2.t Bug 7677: UT: Remove $dbh->rollback 2016-09-12 09:13:58 +00:00
Service.t
…
ShelfBrowser.t
…
Sitemapper.t Bug 17920: t/db_dependent/Sitemapper.t fails because of permissions 2017-01-20 14:04:21 +00:00
Stats.t
…
SuggestionEngine_ExplodedTerms.t Bug 16869: Silence and catch warnings in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2016-07-08 13:08:09 +00:00
Suggestions.t Bug 17099: C4::Koha - Remove GetSupportName and GetSupportList 2016-09-09 13:30:45 +00:00
Tags.t
…
Templates.t Bug 18010: Unit test for gettemplate 2017-03-23 00:36:12 +00:00
TestBuilder.t Bug 17726: [QA Follow-up] Add test descriptions 2017-01-20 13:43:18 +00:00
Upload.t Bug 17501: [Follow-up] QA Requests 2017-01-20 14:20:07 +00:00
UsageStats.t Bug 17736: Replace GetReservesFromBiblionumber with Koha::Biblio->holds 2017-03-31 12:02:14 +00:00
Virtualshelves.t Bug 16551: Display the name of lists to the search results at the OPAC 2016-09-25 15:43:07 +00:00
XISBN.t Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
XSLT_Handler.t
…
check_sysprefs.t Bug 17917: [AMENDED] Fix path issue in t/db_dependent/check_sysprefs.t 2017-01-20 13:39:37 +00:00
db_structure.t Bug 16173: db_structure.t shouldn't have a fixed number of tests 2016-04-01 19:14:53 +00:00
default_search_class.pl Bug 11998: Use t::lib::Mocks::mock_preference in tests 2016-03-15 07:08:28 +00:00
rollingloans.t Bug 17578: GetMemberDetails - Remove GetMemberDetails 2016-12-16 13:12:44 +00:00
sysprefs.t Bug 11998: Use Koha::Cache to cache sysprefs 2016-03-15 07:08:28 +00:00
zebra_config.pl
…