Bug 17970: Add tests to highlight the problem

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Jonathan Druart 2017-01-21 14:13:36 +01:00 committed by Kyle M Hall
parent 95e6f6a612
commit 52d5519743
1 changed files with 40 additions and 1 deletions

View File

@ -18,7 +18,7 @@
# along with Koha; if not, see <http://www.gnu.org/licenses>.
use Modern::Perl;
use Test::More tests => 79;
use Test::More tests => 80;
use Test::MockModule;
use Test::Warn;
@ -47,6 +47,7 @@ use Koha::Acquisition::Order;
use Koha::Acquisition::Booksellers;
use Koha::Acquisition::Bookseller::Contacts;
use Koha::Libraries;
use Koha::Notice::Templates;
my $schema = Koha::Database->schema;
$schema->storage->txn_begin();
@ -439,6 +440,44 @@ warning_like {
is($err->{'error'}, 'no_letter', "No TESTACQORDER letter was defined.");
}
subtest 'GetPreparedLetter' => sub {
plan tests => 4;
Koha::Notice::Template->new(
{
module => 'test',
code => 'test',
branchcode => '',
message_transport_type => 'email'
}
)->store;
my $letter;
warning_like {
$letter = C4::Letters::GetPreparedLetter(
module => 'test',
letter_code => 'test',
);
}
qr{^ERROR: nothing to substitute},
'GetPreparedLetter should warn if tables, substiture and repeat are not set';
is( $letter, undef,
'No letter should be returned by GetPreparedLetter if something went wrong'
);
warning_like {
$letter = C4::Letters::GetPreparedLetter(
module => 'test',
letter_code => 'test',
substitute => {}
);
}
qr{^ERROR: nothing to substitute},
'GetPreparedLetter should warn if tables, substiture and repeat are not set, even if the key is passed';
is( $letter, undef,
'No letter should be returned by GetPreparedLetter if something went wrong'
);
};
{
warning_is {