Commit Graph

10310 Commits

Author SHA1 Message Date
Garry Collum e277ad95eb Bug 2889: Added highlighting to smart-rules.tmpl
Removed unused toggle variable form smart-rules.pl and added highlighting to smart-rules.tmpl through template __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:38 +02:00
Joe Atzberger 5fc37a04b4 Pull the last OPAC-specific tmpl vars out of gettemplate.
These don't belong every template, only on OPAC:
~ opacstylesheet
~ opaccolorstylesheet
~ opacsmallimage

The latter 2 were already being populated in C4::Auth anyway.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:38 +02:00
Matthias Meusburger 84e6a5decd bug 3271 : Added tooltip when adding to a list with no item selected (same as for cart)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:38 +02:00
Galen Charlton b5c8b19e2a bug 3263: fixed ersatz references to AmazonContent
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:38 +02:00
Galen Charlton 84fe754654 bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>

[1] Three new system preferences to enable particular
bib record views in the staff interface:

viewMARC
viewLabeledMARC
viewISBD

Implements enhancement 2642.

[2] New button in the regular and cataloging search results
   pages in the staff interface to allow the operator to redo
   the search against Z39.50 targets instead of the Koha database.

[3] Added copyright date and edition to cataloging and Z39.50 search results.
    Implements enhancement 2640.

Feature sponsored by MassCat.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Ryan Higgins a6df74d80b bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Chris Nighswonger 2d0476d6d9 Bug 2500 Tweaking DDCN Split for Hyphenated Volumn Numbers
Presently 252.051 T147 v.1-2 is split as

252.051
T147
v.1
-2

This patch corrects the algorithm so that it splits as

252.051
T147
v.1-2

It also updates Labels_split_ddcn.t to include this particular case.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Jesse Weaver c1e46fd1cd Small documentation improvement for C4::Service
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Galen Charlton 60447f3a64 fix uninitialized value warnings during COinS generation
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Joe Atzberger 41568f5ddd Cleanup waitingreserves.pl and .tmpl
Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Galen Charlton d1c1150e31 bug 3219: handle variation in Amazon responses
An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN.  Changed parsing so that
those responses are no longer treated like pseudohashes.

This fixes the following crash:

[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl

Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:37 +02:00
Garry Collum 880037b710 Bug 3261: Fix for invalid XHTML on Personal Details page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:36 +02:00
Joe Atzberger 426c8b474e Cleanup view_holdsqueue.pl and .tmpl (minor)
Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:36 +02:00
Galen Charlton 755bf6aca7 minor fix - don't declare variables in a conditional
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:36 +02:00
Chris Cormack 82b3646e2e Fixing a bug that crept in with a cherry-pick 2009-09-16 23:19:36 +02:00
Garry Collum a7fc4f4c63 Bug 3241: Place hold button appears on results page if opacuserlogin is off
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:35 +02:00
Galen Charlton dad23d185c quell warning if format parameter isn't passed to opac-search.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:35 +02:00
Daniel Sweeney fcdf913432 Added barcode query back to circ/ysearch.pl for patron proxies.
This is to allow patron proxy relationships to be built using the patron barcode.

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:35 +02:00
Joe Atzberger d742109542 @renew_failed can cause enormous performance-killing array.
The array was populated and values flagged with an accessor, like:
    for (@failedrenews) { $renew_failed[$_] = 1; }
But this means that an array of possibly hundreds of thousands of elements
would have to be auto-populated for high itemnumbers.  A hash is the correct
structure.  We also haven't checked the user input for validity, so we do not know
for sure that @failedrenews really does contain just itemnumbers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:35 +02:00
Galen Charlton ea3bd3ac1a updated JSON and JSON::XS package reqs for Debian lenny
By default, the JSON module will automatically use
JSON::XS if available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Frédéric Demians 0f956b9c7e Bug 3169 - Comply with new Google Book branding guidelines
It adds pretty huge image 'Google Preview' on google
book jacket.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Chris Cormack 17e6dc4b2d Whoops extra } crept in when fixing a merge conflict, removing it
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Chris Catalfo 505087abc4 Bug 1907 partial fix: prevent warnings on undefined params.
This patch adds default blank values for a couple of params the script might receive which were producing warns in the error log. Also wraps GetMarcBiblio in an eval.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Joe Atzberger a67ca33b45 Script to check for corruption of marcxml, and optionally to attempt fix.
When marcxml cannot be parsed into a MARC::Record object, the biblio is
undisplayable and it obviously breaks many features in Koha.  This script
can test to parse every marcxml, and alert on failures.  Optionally, the
marcxml can be replaced from the marc field.

See extensive perldoc for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Galen Charlton 20a408a1b4 bug 3211: fix XHTML validation errors in MAR21 bib leader plugin
Note that as a result of this patch, not only will the
page use valid XHTML, but the intranet stylesheets are
now used, IMO improving the display of the form.

This patch also fixes the descriptions of the Leader/09
and Leader/17.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Galen Charlton db8ddfc002 bug 3209: add 'p' (mixed materials) to MARC21 Leader/06 dropdown
Also made the following updates to the MARC21 leader plugin

[1] Changed description of Leader/08 to 'Type of control'
[2] Fixed typo in description value for 'z' in Leader/17
[3] Updated Leader/19, which is now 'Multipart resource record level'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Galen Charlton 141d0fad0d bug 3120: tweak splitting of Dewey call number
If a call number prefix contains a hyphen, try not to
split on the hyphen.  For example, rather than
splitting the call number 'CD-ROM 787.87 EAS'
like this:

CD
-ROM
787.87
EAS

it should be

CD-ROM
787.87
EAS

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Frédéric Demians 2403255d0b Bug 3213 - UNIMARC/MARC21 selection
Modify how XSLT stylesheet are choosen
depending on 'marcflavour' syspref.

DOCUMENTATION: XSLTResultsDisplay and XSLTDetailsDisplay
sysprefs aren't MARC21-only anymore.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:34 +02:00
Michael Hafen 2fceb4da7a Tweak offline_circ - honor itemBarcodeInputFilter and add to Makefile.PL
Add the ofline_circ directory to Makefile.PL as needing to be installed.
Add calls to barcodedecode() on issueing and returning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:33 +02:00
Galen Charlton 26fb6c57d9 fix all templates errors reported by xt/author/valid-templates.t
In process, removed four disused HTML templates and one
disused script, serials/receipt.pl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2009-09-16 23:19:33 +02:00
Chris Cormack 3b02ff1f3a Fix for opac-detail being broken after merging 2009-09-16 23:19:33 +02:00
Henri-Damien LAURENT 305dbbead0 Revert "followup previous patch - remove disused $opacstylesheet"
This reverts commit 59b8fd2383053698996ffd2f6d936d8fcb20ca76.
c4/Output would not compile
2009-09-16 23:19:33 +02:00
Nahuel ANGELINETTI f813c38ee7 (bug #3497) show publication year, or copyrightdate
This change the shelf view in opac, to show publication year, in the column "Year"(that was previously copyrightdate), and is there is no publication year, show copyright date.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Nahuel ANGELINETTI e42e720c6d (bug #3459) fix opac-topissue to take care of ccode
This bugfix, add a conditionnal sql request, that get the "ccode" document type if AdvancedSearchTypes is positionned to ccode.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Nahuel ANGELINETTI fae56bb880 (bug #3458) fix die and unimarc 700-4 plugin
This patch, fix the unimarc 700-4 plugin, adding the plugin_parameters() function.
And add an eval, that permit to have error in plugin, but don't die the editor.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Nahuel ANGELINETTI 7794cf2eb3 (bug #3432) fix return of lost items
This patch delete some useless code, and fix the problem that if a lost item is returned, the lost flag is not deleted.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Nahuel ANGELINETTI 5da38d9ce6 (bug #3409) fix return rules for transfert
This patch add the use of CircControl and HomeOrHoldingBranch for return and transfert rules.
* ItemHomeLibrary goes to item{HomeOrHoldingBranch}
* PatronLibrary goes to the borrower library
* PickupLibrary depends where the items was checked out, and the actual library.

This add a little improvment that does not re-request each time the circcontrol syspref.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Matthias Meusburger a81d341989 Removing unused files from the serials module
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Nahuel ANGELINETTI 78a2b2cb1e (bug #3573) use delimiter syspref generating overdues csv
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:32 +02:00
Henri-Damien LAURENT b450285003 Adding autotruncation
Allow autotruncation to be set on its own
This simply reprocess operands in order to add * at lefthandside
It is a problem with non LTR scripts. But works fine with all the latin scripts

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Nahuel ANGELINETTI 1471d30dfb (bug #3541) show reserved items as not available
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Nahuel ANGELINETTI d298b87548 [3.0.x](bug #3242) send email when hold is placed
This add a new letter in database, and each time a new hold is placed, a new mail is enqueued.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Jean-André Santoni 6823b2387c [3.0.x](bug #3560) This add a filter to search by itemtype
The value builder for 4XX should be able to filter results by itemtype.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Jean-André Santoni 5c7283d0cf [3.0.x](bug #3555) This sets the default branch to the logged user branch when IndependantBranches is active
In the advanced search form, when IndependantBranches is activated, the default
branch should be set to the logged user branch.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Jean-André Santoni c7b7007b60 [3.0.x](bug #3552) This mark mandatory fields with a red asterisk
Many librarian ask for a way to know if a field is mandatory before validation.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Nahuel ANGELINETTI 1874d5d1ba (bug #3557) fix bor_issues_top
Just add the condition where column is "None".

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Nahuel ANGELINETTI faa394ecd4 (bug #3553) do not allow users to create code-less frameworks
This patch, disallow the users to create frameworks without frameworkcode.
It adds some javascripts checks, and some perls checks(for non-javascript users).

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:31 +02:00
Jean-André Santoni 89d3293666 [3.0.x](bug #3549) Sorted framework options in the dropdown menu
In addbook.pl, the framwork options are sorted in random order. They should be
sorted in alphabetical order of value or code.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:30 +02:00
Nahuel ANGELINETTI 75b5e00152 (bug #3546) fix issues_stats
This fix the order of columns.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:30 +02:00
Nahuel ANGELINETTI f9ef9de6c1 (bug #3512) fix acquisition reports and group by
This fix, just change a grep value that make different way to calculate the table depending on the choosen column and line.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:30 +02:00