Commit Graph

15293 Commits

Author SHA1 Message Date
Christophe Croullebois d3462cdf80 Bug 7350: In neworderempty.pl duplicating an item does not preserve select box selections
cloneNode() does not preserve select box selections, I have created a function to duplicate them : "clone_with_selected".
It is included in "cloneItemBlock", that's all.
Now the values selected in ddl are duplicated as the imput-texts are.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit a47f59f72f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:54:00 -05:00
Chris Nighswonger f50e1ec348 Bug 7359 - Begin migration to a new "Koha" namespace from the old "C4" namespace
The Koha namespace is for Perl modules that meet the following mandatory
conditions:

* use "strict" and "warning" pragmata
* include valid POD
* include complete and functioning documented test cases
* not create circular dependencies
* use Object Oriented (OO) style everywhere possible
* minimize exports
* maintain mod_perl, etc. compatibility
* separate data access methods from business logic

Modules in C4 can use (and are encouraged to use) routines in
the Koha namespace.  Modules in Koha should not in general use C4
modules; any C4 module that is safe to be depended on by a Koha
module is a candidate for being renamed to Koha.

The advantage of carving out a new namespace is that it doesn't
require that we refactor the entirety of C4 to support persistance or
to untangle the dependency tree.  Instead, the only C4 code we would
have to reimplement for the Koha namespace right away would be
authentication, basic session management, and basic output.

(Gratuitous use made of gmcharlt's recommendations found in the
post mentioned below.)

Related info:

http://lists.koha-community.org/pipermail/koha-devel/2011-March/035302.html
http://wiki.koha-community.org/wiki/Namespace_QA_Rules

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit a984129e05)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:54:00 -05:00
Paul Poulain 03e1c36dce Bug 6836 follow-up fixing POD
this should please jenkins
(cherry picked from commit 19e3607c49)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:54:00 -05:00
Marcel de Rooy 4235bb17e8 7367 Removing reintroduced debugging statement from Auth.pm
Commit 07d1eae7cc removed this statement from the module, but some months later commit 7b12e07d3b reintroduced it again while reindenting code ;)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(cherry picked from commit 9c0ce2bf3b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:54:00 -05:00
Paul Poulain a616321929 Bug 7157 follow-up: j2a.pl executable again
This patch just update the permission of the script, that must be executable
(cherry picked from commit e8b83c665a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:20 -05:00
Liz Rea 14396956c9 Bug 7157 - Improve the j2a.pl cronjob
- Calculates updates date based on the upper age limit defined in the patron categories.
- Allows libraries to work on all branches or only one.
- Allows libraries to specify which Adult patron category to update child categories to.
- Allows libraries to specify a single Child patron category to update to an adult category.
- Has a test mode to display what transforms would be done on the database without executing the changes.

Includes improved help, copyright statement, and uses warnings. Also incorporates Paul's suggestions regarding --help and --man, changes -fromcat and -tocat to -f and -t, and removes a redundant update to categorycode (per M. deRooy).

To test:

Create two patron categories, a child and an adult category. Make sure they
have an upper age limit.

Create or modify some patrons in multiple branches that fall into the category
of "my birthdate is less than or equal to today's date minus the upper age
limit"

1. Run the script with no flags - nothing should  happen, it will suggest you try the --help flag.
2. Run the script with the --help flag - you should see the help
3. Run the script with the -f=<child category> -t=<adult category> -v -n - should show you results from all branches but take no action and tell you what its computations are.
4. Run the script with the -f=<child category> -t=<adult category> -b=<branchcode> -v -n - should show you results from your specified branch, but take no action and tell you what it's computations are.
5. Run the script with the -f=<child category> -t=<adult category> -v -b=<branchcode> - should show you the computations and tell you how many patrons were modified in your single branch. It will not show you the information on which patrons were updated.
6. Run the script with the -f=<child category> -t=<adult category> -v - should show you the computations and tell you how many patrons were modified across all branches.
7. Run the script without the -v flag, if you care what the non-verbose output looks like.

Fixed in this revision: Known limitation - if you give it an unknown tocat, it will fail with a rather ugly error.

Minor changes to the commit message to reflect new longopts (which I missed the last time)
There is more this script could do, please feel free to take it and run.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Bug 7157 : Follow up, fixing FSF address

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit fe1a642a1a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:20 -05:00
Colin Campbell 960da426a8 Bug 6752: Be stricter with utf-8 encoding of output
use encoding(UTF-8) rather than utf-8 for stricter
encoding
Marking output as ':utf8' only flags the data as utf8
using :encoding(UTF-8) also checks it as valid utf-8
see binmode in perlfunc for more details
In accordance with the robustness principle input
filehandles have not been changed as code may make
the undocumented assumption that invalid utf-8 is present
in the imput
Fixes errors reported by t/00-testcritic.t
Where feasable some filehandles have been made lexical rather than
reusing global filehandle vars

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 263dded818)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:19 -05:00
Julian Maurice 0508e6fb86 Bug 6836: test case readingrec.pl
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I tested the functionality and tested translation.
All important strings are in the template and can be translated.
Good work!
(cherry picked from commit 7d0761bbe9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:19 -05:00
Owen Leonard 8edc97a838 Bug 6836: followup CSS work
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
(cherry picked from commit fb928d48fc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:19 -05:00
Julian Maurice 5f36947783 Bug 6836: Add jQuery dataTables plugin
This patch add the javascript library, a CSS (and image files from
datatables.net) and another javascript file which provides some extra
features.
It also add a Perl module C4::Utils::Datatables which provides helpful
functions for server-side processing

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
(cherry picked from commit 8298250c49)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:51:18 -05:00
Chris Cormack 1bba820ca7 Bug 6836: Adding dependency on Modern::Perl
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit c1ee7a750f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:48:26 -05:00
Chris Cormack 3c52fd6f8e Updating perlcriticrc to allow Modern::Perl to suffice instead of use warnings; and use strict;
http://bugs.koha-community.org/show_bug.cgi?id=6836

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
(cherry picked from commit c77b8756f7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:48:26 -05:00
Paul Poulain e26279c11d history.txt removing a useless tab
(cherry picked from commit 572233de4a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:38 -05:00
Liz Rea c0744f9e57 Bug 6350 - Adding new developers to history.txt Jesse Maseto Connor Dewar Sam Sanders
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c7c892ae34)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:37 -05:00
Alex Arnaud 77c1513408 bug 7343 - Fix empty values in statistic 1 and 2 dropboxes in neworderempty
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested. Comments have been incorporated. Marked as Passed QA.

http://bugs.koha-community.org/show_bug.cgi?id=7342
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 37c446b7ac)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:37 -05:00
Garry Collum d39fb1ff42 Bug 7098: Adds koha_url elements to sco.css.
The 'Powered by Koha' link was not styled in self-cko.  The koha_url elements were missing from sco.css.  The elements within opac.css were copied and added to sco.css.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit ac31b07400)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:36 -05:00
Marcel de Rooy 16f466ea78 6829 Follow up
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Needed this second follow up to remove 952-0 from the display again, coming up after the first follow up.
Changed a second test in accordance with first follow up.
Removed a useless 10th loop to create a tab10XX that is not in the template.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit f18e14883f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:36 -05:00
Frédéric Demians a0080586e4 Bug 6829 Follow up patch
To reproduce the bug:

- Open OPAC MARC View for a specific biblio record
- Fields which are affected to tab 0 are all hidden

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch fixes bug for 0xx fields in OPAC MARC view.
Note: the problem only exists for 0xx fields with real subfields,
control fields display correctly, fields like 040 only display
after patch was applied.
(cherry picked from commit 263e5724eb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:36 -05:00
Colin Campbell 5bed69ff23 Bug 6790: Remove unnecessary variable from getroutinglist return
getroutinglist returns a count variable to indicate how many elements
are in the array. This is almost always a serious code smell. (We are
programming in a list manipulating language) The routine was executing
am unnecessary loop just to maintain that var.
Removed the variable from the routine and perldoc
refactored calls of the routine removed the c-style loops for
more idiomatic and maintainable for loops
renamed some opaquely named variables
removed a call to the routine where nothing was done with the data
moved some html out of the calling script and into the template

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit d2c24f3bbf)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:35 -05:00
Chris Cormack 5427909359 Bug 7402 : Fixing the date formatting so links to the invoice page work
This depends on bug 929

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Uses the new TT plugin to display the date, while using iso format
to build a correct URL to the invoice page.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit b32d2d2165)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:35 -05:00
Paul Poulain 5e32902941 Bug 5473 follow-up : removed warn & replace some tabs by 4 spaces
(cherry picked from commit f961638465)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:35 -05:00
Srdjan Jankovic deba3f0032 bug_5473: Update items when receiving shipments
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Tested by recieving multiple items with the AcqCreateItem
preference set to 'placing and order' and 'receiving an item'
In both cases the pricing and vendor is brought over to the
item record so I'm signing off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 92ca5a13e5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:42:34 -05:00
Julian Maurice c4ed20603b Bug 6694: Problem with casAuthentication syspref
A missing test in checkauth caused anonymous session to be destroyed and
re-created at every call when this syspref was set.
Almost the same issue is also fixed in check_api_auth, which caused
C4::Service->init to fail.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 8ffbf4e88c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-19 15:36:55 -05:00
Paul Poulain 50ffaec272 BZ6115: Acquisition reports : date filter & sorting don't work
* the filter on dates don't work
* when displaying by day or month, it was 100% alphabetic, april was before
january for example. Adding the month number before the month name to get
proper sorting
* removed many commented warn & lines

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ceb5757573)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-02 20:34:44 -05:00
Paul Poulain 45877c2a26 Olivier Crouzet is 168th !
(cherry picked from commit b35233acbf)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-02 20:34:42 -05:00
Paul Poulain 01829af25e BZ4376 Minor change in GetMarcAuthor
A minor change in the GetMarcAuthors function of C4/Biblio.pm allow differentiate the type of authors in the templates

This change allow doing things like this in the templates:
<TMPL_IF EXPR="tag == 700" && code eq 'a' >
 <strong>Author:</strong>
<!-- TMPL_ELSE -->
 <TMPL_IF EXPR="tag == 710" && code eq 'a' >
  <strong>Corpotation Author:</strong>
<!-- /TMPL_IF -->
<!-- /TMPL_IF -->

(html template syntax, but also applicable to template toolkit)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as claimed and doesn't break existing functionality.
(cherry picked from commit b70e4f3d6d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-02 20:34:41 -05:00
Owen Leonard 88ee85b33a Fix for Bug 7083 - [SIGNED-OFF] Show creator name on list of public lists
Show the name of the patron who created each list on the list
of public lists. Also:

- correcting unescaped ampersand in the template
- making conditional a check on a variable that doesn't always
  exist, causing noisy errors in the log

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
After applying the patch a column for "Created by" is added to the display of
public lists, and the errors in the log are silenced. On the "Your lists"
tab, the link on the list name now has an escaped ampersand.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 2951d83e9d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-02-02 20:34:41 -05:00
Chris Nighswonger 0b9a914d03 Updating Version Number to 3.06.03.000 2012-01-27 09:14:57 -05:00
Chris Nighswonger f064f9c5d5 Release Notes for 3.06.03.000 26 Jan 2012 15:06:56 Z 2012-01-26 10:06:56 -05:00
Frédéric Demians 5a57875407 Version 3.6.3 Strings Update
(cherry picked from commit bbf0f71d59f14ef78a32ef191c62e7e5b2c333ef)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-26 09:52:42 -05:00
Chris Nighswonger f2a9b64b2d Revert "Bug 7266: flags debarred, suspended, gonenoaddress in overdue"
This reverts commit 057b4ae129.

Reverting this commit from 3.6.x as it is dependent upon 6328
2012-01-18 11:08:58 -05:00
Chris Nighswonger 048cd82afe Release Notes for 3.06.03.000 18 Jan 2012 14:25:43 Z 2012-01-18 10:11:06 -05:00
Marcel de Rooy 3756d185e8 Bug 7439 Follow up for mailmap
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:06 -05:00
Jared Camins-Esakov b8e73c00b1 Bug 7439: Add mailmap for jcamins
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:06 -05:00
Adrien Saurat eb5c940cd1 Bug 7435: corrects Fund selectbox in addneworder
Prevent disabled funds to appear in the Fund
select box.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 04400d9926)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:05 -05:00
Chris Cormack e62a1ab956 Bug 7276 : Follow up, adding a sub to clear the cache
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 94516e7f2a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:05 -05:00
Henri-Damien LAURENT 6a86b550cd Bug 7276 : member entry Performance improvement
Before this patch : 9619 borrowers added in 31 Minutes, After : 68 seconds.
This adds Hashref to table structure in C4::SQLHelper to speed up bulk edits.

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6c38cc23d9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:05 -05:00
Frédéric Demians 19fb959d6b Bug 6885 Follow up patch, invert tested condition
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Not sure the brackets are nessecary, but I think I remember learning
bitwise operators have a lower priority than other relational
operators so wanted to make sure we notted the result of the bitwise
and, not the flag

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 6fd3635a59)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:04 -05:00
Adrien Saurat 057b4ae129 Bug 7266: flags debarred, suspended, gonenoaddress in overdue
This patch makes these flags functionnal.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 74984f5cf3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:04 -05:00
Ian Walls aac43adb01 Bug 7097: HidePatronName not hiding on issue history
HidePatronName wasn't being respected on a titles Checkout History tab.  This patch
exports the preference to the template (if set), and then toggles the display between
patron cardnumber (if 'on') or the name (if 'off')

To test:

Enable HidePatronName
Go to the Checkout History tab of an item that has been checked out before
You should see the patron's cardnumber instead of their surname, firstname

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 5fde469429)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:04 -05:00
Jared Camins-Esakov 021ea1afd5 Bug 7332: Translated title (MARC21 242) not shown
The cataloger-supplied translated title stored in MARC21 field 242 was not being
displayed when XSLT was enabled.

Test plan:
1) Enable XSLT for OPAC Details and Results, and Intranet Details.
2) Create or add a record with a 242 field
3) See that the translated title is not displayed in OPAC Details or Results, or
Intranet Details
4) Apply patch
5) See that the translated title is now displayed in OPAC Details and Results,
and Intranet Details

Signed-off-by: Duncan Tyler <duncan@duncan-SoT.wgtn.cat-it.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 9156de6384)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:03 -05:00
Magnus Enger adf2e2551a Bug 6787 - Fast Add framework for NORMARC
The new framework will be called "Hurtigkatalogisering".

To test:
- Make sure the nb-NO translation is installed
- Run through the web installer on an empty database
- Select nb-NO as the installation language
- Select NORMARC as the marcflavour
- Include normarc_fastadd_framework in the installed data
- Check that the framework looks ok in:
-- More > Cataloguing
-- More > Administration > MARC framework

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, not problems found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 629f3f322c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:03 -05:00
Garry Collum f317028fa7 Bug 7277: Fixes display of subtitles in opac.
Adds comma and space to results display in opac between title and subtitles.
Also removes extra space before the subtitle in the results display of the staff pac.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 0ad771a68b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:03 -05:00
Katrin Fischer e0d88c5d6e Bug 4300: Fix display of textual holdings (866)
Fixed problems:
- only $z, but not $a was shown
- only first $z for each 866 field was shown
- each 866 field produced a ; even if no $z was present

After patch was applied:
- OPAC displays 866 $a and $z, separating each field with ;
- Staff displays 866 $a, $x and $z, separating each field with ;

Example(s) for testing:
866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing
866 $a1-86 (1941-1987)
866 $a--86 (1941-1897)$xinternal note
866 $zfirst note,$zsecond note

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 7caec5a45f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:02 -05:00
Dobrica Pavlinusic 17b3c7ce91 Bug 7247 - rebuild_zebra.pl -v should show all Zebra log output
Currently, -v option resets Zebra log output to default system values.

This produce amount of log specified in system defaults which is usually
too low for debugging.

This change explicitly forces all Zebra log output which create much more
chatter so it triggers with verbosity level 2

Test scenario:
1. pick koha site to reindex
2. use -v -v options to rebuild_zebra.pl to see additional output

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Verified help corrections and  loglevel 2 output vs. loglevel 1 output. No issues found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 90d68d6f5c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:02 -05:00
JAMES Mason c7eda06d91 Bug 6466 - hung socket read causes SIP tests to fail
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit b0a4233366)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:02 -05:00
Ian Walls 2dd0af76a4 Bug 5533 followup: reinstate Lost status editing
The original patch for 5533 removed the Lost status from the edit items screen; new items were not affected,
and batch changes could still be made, so this was not a consistent change.

This patch removes the filter that hid the Lost status dropdown, but then changes the default MARC framework
to hide this field by default (value -5).  New installations will not see this status in the editor, unless
they manually activate it.  This will enforce the semantics of using the "mark lost" options by default, but
provide a workaround for libraries that understand and accept the consequences of manually editing this field.

To test:

1.  on an existing install, edit an item.  you should have the Lost status visible
2.  on a new install, editing or creating an item should not show the Lost status at all

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 3062405c09)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:01 -05:00
Ian Walls c0cdbed5da Bug 7407: HidePatronName not working on 'on hold for' messages
HidePatronName was not working on 'on hold for' messages, only 'checked out to'
messages.  This resulted in the patrons name showing if the item was on hold for
them.

T:T scope issue; needs to be within itemloo.  This patch does that.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit b08ccda99d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:01 -05:00
Sam Sanders d297f4d267 bug 5327 add tests for C4/BackgroundJob.pm
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/db_dependent/BackgroundJob.t
All tests complete successfully.

Note: Test 11 does not tell what it's about, but it has been there before.
(cherry picked from commit dbb29b4042)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:01 -05:00
Connor Dewar e44ed03423 Bug 5327 Added unit tests for C4/Reports.pm
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/Reports.t b/t/Reports.t
All tests complete successfully.
(cherry picked from commit e96c92d077)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2012-01-18 10:11:00 -05:00