Commit Graph

16380 Commits

Author SHA1 Message Date
Chris Cormack c753b016ca 3.8.3 Release notes 2012-07-21 09:25:49 +12:00
Chris Cormack 24e5d0e464 Bunping db version for release 2012-07-21 09:24:46 +12:00
Chris Cormack 7e5826a72b Merge remote-tracking branch 'tamil/3.8.3-translate' into 3.8.x 2012-07-21 09:15:09 +12:00
Frédéric Demians 87e292777c Koha 3.8.3 Translation Update 2012-07-20 20:07:33 +02:00
Jared Camins-Esakov c2f9331e16 Bug 8386: Error in duplicate detection message for authorities
If you create a new authority record and the name already exists in
your database, you get a duplicate warning. This is good, but there is
a small error in the message:

Duplicate record suspected
Is this a duplicate of HASH(0x47fa670)?

This patch corrects the error message to show the title.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Error message correctly shows the name after applying this patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-18 19:59:30 +12:00
Owen Leonard 6b80d0d681 Bug 8398 - Missing image file in staff global css
This patch fixes a regression introduced by the fix for
Bug 6855 (bullet point showing in wrong place on error message)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855

The patch removes the re-introduced reference to a
background image which has since been removed. Testers should
check that this patch does not re-introduce Bug 6855.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I checked the styling of the error messages in Chromium and Firefox.
The logs are no longer complaining about the missing image.
Looks good to me.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-18 19:57:13 +12:00
Owen Leonard bfcb15eeed Fix for Bug 6855 - List bullet showing in wrong place on error message
Added some more specific CSS to help Webkit browsers display
the lists bullets correctly.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased 9 June 2012. Signing off as well, since the rebase and test
were trivial.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-18 19:56:54 +12:00
Chris Cormack f6e238b410 Bug 5644 : Fixing the test
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-17 17:39:47 +12:00
Chris Cormack af07ec2a6b Bug 5644 : Fixing dropbox mode calculation
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-17 17:39:16 +12:00
wajasu e66b380ead Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-17 17:33:41 +12:00
Katrin Fischer fa238b1856 Bug 6394: purchase order has French strings hard coded in
On the purchase order it said 'publié par' - instead of 'published by'.

The layout files for PDF generation in basket groups contain lots of English
strings, this change makes the template more consistent.

Currently the files are not translatable. The only way is to add translated
files to your installation.

To test:
Print a basket group as PDF. Verify string is ok for both possible settings
of system preference OrderPdfFormat:
- pdfformat::layout3pages
- pdfformat::layout2pages

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-14 15:00:16 +12:00
Dobrica Pavlinusic 10ff4bd461 Bug 8315 - remove use C4::* version
This patch touches a lot of code, but basically it removes version
information from use C4::* in our code.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
All script still compiles after the patch (confirmed by pre-applypatch hook)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-14 10:26:07 +12:00
Robin Sheat 5cb0834f4d Bug 8235 - allow a whitelist of modules that aren't in Debian
This allows modules that aren't in the main debian repos to be handled
by the list-deps script when building a control file.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-12 11:07:33 +12:00
Kyle M Hall ff3cba4f9f Bug 7848 - Issues data missing from circulation notices
For the CHECKIN and CHECKOUT notices, any data that is issue specific
does not show. For example, date due.

For CHECKOUT, this is caused not passing in the issues table as part
of the 'table' hash used by C4::Letters::GetPreparedLetter.

For CHECKIN notices, we need the old_issues table instead, as the item
has already been returned.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, correct information shows in notices.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-12 10:43:40 +12:00
Jared Camins-Esakov 4e2b90506d Bug 8383: Add test to check that Perl scripts compile
This patch adds t/db_dependent/00-strict.pl which tests that all Perl
scripts compile. I chose to use Test::Strict so that in the future we
can also have the test check that "use strict" and "use warnings" are
enabled.

To test:
1. Run t/db_dependent/00-strict.pl.
2. Run around waving your arms in the air that we have a couple of
   scripts that don't compile.
3. Actually, that's about it. You could test my patch for bug 8384 next.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Moved test to t/db_dependent

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	C4/Installer/PerlDependencies.pm
2012-07-11 08:49:19 +12:00
Mirko Tietgen 67ead476aa Bug 7143 – Bug for tracking changes to the about page
This patch updates the German translators. To be applied after attachment 10681.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-11 08:46:26 +12:00
Chris Cormack 673bea61ce Bug 7143 : Adding Stacey Walker to the history
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-11 08:45:55 +12:00
Mark Tompsett 2c2f919b8a Bug 8356 - moveitem.tt and linkitem.tt have cataloging typo Changed urls from cataloging to cataloguing
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
correct typo

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-11 08:38:55 +12:00
Jared Camins-Esakov f6e45171ba Bug 8384: Some Perl scripts do not compile
Fix syntax errors preventing the scripts misc/translator/text-extract2.pl
and misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl from compiling.

Remove misc/migration_tools/build6xx.pl entirely since it refers to
columns that no longer exist in the Koha database, and has seemingly
had broken encoding since Koha switched from CVS to git (or before!).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Rebased as the TalkingTech code doesn't exist in 3.8.x
2012-07-11 08:21:29 +12:00
Marcel de Rooy 600a069cc9 Bug 3280 Followup for privacy issue on X-Orig-IP in mail header
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-10 06:40:44 +12:00
Frère Sébastien Marie d8feddd48a Bug 3280 : Restrict Send basket feature
In order to prevent spamming using sendbasket.pl, some counter-measure are done:
 - permit send basket only for authenticated user
 - permit send basket only if basket contains items
 - use username & email for 'Reply-To' field (with fallback to KohaAdminEmailAddress)
 - add field X-Orig-IP with IP of sender
 - add field X-Abuse-Report with KohaAdminEmailAddress

Note: we don't use forged 'To' address with patron email in order to
prevent be marked as spam (by SPF for example).

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-10 06:40:07 +12:00
Chris Cormack b0d735a0a6 Revert "Bug 5981 - OPAC: Add limits to search history"
This reverts commit 08994647f7.

Conflicts:

	installer/data/mysql/updatedatabase.pl
2012-07-08 06:15:36 +12:00
Alex Arnaud bc42bf97cb Bug 7299 pass itemnumber in ILSDI holditem service
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 21:33:26 +12:00
Marc Veron 29b1860526 Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl
Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ )

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 21:30:06 +12:00
Chris Hall 2b8b926783 Bug 8323 fixing year sorting of a list
Signed-off-by: Marc Veron <veron@veron.ch>

Works as expected.

Caveat: If you edit the list in Opac, change the sort and then klick 'Save',
the List always is displayed in title order. This is du to the fact that
save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults
to 'title').
If you go back to lists, choose the list from List name, the param is
correct and the list displays in expected order.

It took quite a time to track  that down, I first thought that opac-shelves.pl
was broken.

However, current bug 8323 is not affected, signing off.

Marc

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 15:10:40 +12:00
Julian Maurice ccf44db16f Bug 7286: rebuild_zebra_sliced for biblios and authorities
Complete rewrite of rebuild_zebra_sliced.zsh (renamed to .sh). Main
improvements are:
  - both biblio and authority records are handled
  - records are exported only once

It also add an option --skip-index to rebuild_zebra.pl that permit to
use rebuild_zebra.pl as an 'export only' script.

Description:
Index Koha records by chunks. It is useful when some record causes
errors and stop the indexation process. With this script, if indexation
of one chunk fails, chunk is splitted in 2 (or 3) chunks, and
indexation continue on these chunks.
rebuild_zebra.pl is called only once to export records.
Splitting and indexing is handled by this script (using yaz-marcdump and
zebraidx).

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 15:07:43 +12:00
David Cook 5286c144ce Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 12:00:20 +12:00
Chris Cormack 0351ea525e Bug 5327 : Follow up for TTParser test 2012-07-07 11:35:47 +12:00
Duncan Tyler 796127e4b9 Bug 5327 : Added coverage to unit test for TTParser
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test passes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 09:49:41 +12:00
Stacey Walker a44b3652d2 bug 5327: added some tests for C4/Items.pm
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 09:29:32 +12:00
Chris Cormack 4380280ada Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 09:24:45 +12:00
Colin Campbell 14fc219391 Bug 7619 Use CRLF as default terminator
Most units require or tolerate CRLF as the terminator
Using only \r causes many including 3M units to signal errors
due to delay this resets CRLF to be default but adds a single
constant variable and explanation so that if you have a
"strictly conforming" unit (the 'Baby' is the only I have encountered
you know where to make the change

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-07 09:18:40 +12:00
Lyon3 Team 3417e7a46a Bug 8242 : Permission for change password button in members toolbar should be borrowers instead of staffaccess
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-05 08:24:09 +12:00
Chris Cormack b0d926a3c3 Fixing version number 2012-07-05 07:30:38 +12:00
Alex Arnaud 08994647f7 Bug 5981 - OPAC: Add limits to search history
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch.

Patch works nicely, tested with different searches and limits.

Note: Sort options don't get into the history still.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	installer/data/mysql/updatedatabase.pl

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-05 07:29:36 +12:00
Paul Poulain fc28be8ac3 bug 7630 follow-up : welcome #186 Mark Tompsett
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-05 07:23:31 +12:00
Mark Tompsett 5dd3e5bc9e Bug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to its own conditional $template->param()
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-05 07:22:46 +12:00
Jonathan Druart aa84adb88e Bug 8217: Followup: move code to the document.ready function
Patch for 3.8

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-07-02 21:40:27 +12:00
Paul Poulain 9285b2899f bug 6350 (history.txt) fixing typo
decmember is not a month afaik ;-)
2012-06-30 10:19:02 +12:00
Chris Cormack 42a46b481a Bug 6350 : Updating history
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

Conflicts:

	docs/history.txt
2012-06-30 10:18:28 +12:00
Jared Camins-Esakov 19ad4e1125 Bug 8311: Fix scoping error in C4::Auth
There is a mis-scoped function call in C4::Auth, on line 154, where
GetMembers is called without explicit scoping and before
'require C4::Members;'. This does not actually have any functional
ramifications as far as I can tell, but it would be a good idea to fix
it.

This patch also corrects a bit of indenting in that area, because it was
an unnecessary challenge to understand the code with the mis-indenting.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-30 09:46:06 +12:00
Mason James 6e5962988c Bug 8315 - fix 'C4::Output 3.02' errors in Koha
modified:   opac/opac-ratings-ajax.pl
	modified:   opac/opac-tags.pl
	modified:   tags/review.pl

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-30 09:33:07 +12:00
Mason James 174e5ed63d Bug 8313 - add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature
Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-29 23:08:13 +12:00
Colin Campbell cce20f27e7 Bug 6939 DefaultClassificationSource should be default in 942
A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-29 23:02:43 +12:00
Owen Leonard ba8ce32ab0 Bug 8288 - showmarc.tt should not include full doc-head-close.inc
showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-29 22:57:36 +12:00
Sophie Meynieux 83874c6214 Bug 8191 : Adding a new value to 8 position of coded data field 100
From july 2012, unimarc norm evolves and the value k "monograph with both publication date and print date" must be added for this position.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked the new value shows up and is correctly copied into the field.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-26 13:41:20 +12:00
Jared Camins-Esakov 8bdd072676 Bug 8255: allow local cover images to be cached
At the moment, local cover images cannot be cached by the web browser
or any intermediate reverse proxies. This results in an unnecessary
load on the server, and is entirely unnecessary.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-26 13:37:25 +12:00
Marcel de Rooy ee53a0c6fa Bug 7143 Followup for timeline
Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-26 13:34:32 +12:00
Marc Veron c007d2fb3e Bug 7368 - General staff client typo omnibus
Corrects 2 typos, see comment #9

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-26 12:03:03 +12:00
Owen Leonard 08d45e7767 Bug 8194 - Layout problem on subscription add when showing manual history
Markup errors were causing display problems when the "manual history"
section is shown.

To test, apply the patch, load the subscription add page, and check
the "manual history" checkbox. The "Serials planning" section
should appear directly below the "manual history" section.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-06-26 11:42:03 +12:00