gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
49,749 Commits 39 Branches 720 Tags 6 GiB
Commit Graph

34 Commits

Author SHA1 Message Date
Pedro Amorim 5f659acb2b Bug 34448: Update cypress tests 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 767a004f03)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-09-15 10:08:30 +00:00
Pedro Amorim 17a013b72a Bug 34466: Cypress tests 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 68baf8a7c1)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit e4ddce3f98)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-09-08 09:47:26 +00:00
Tomas Cohen Arazi 0a757c856a Bug 33416: Fix Searchbar_spec.ts 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5a39823dbc)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
(cherry picked from commit 5eec29d2da)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-06-13 09:04:56 +00:00
Jonathan Druart c521213b14 Bug 33416: Fix Agreements.ts 
<failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a
fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2167028025)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
(cherry picked from commit e1fbe67683)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-06-13 09:04:55 +00:00
Matt Blenkinsop 6d567185f0 Bug 33064: Update cypress tests 
This patch amends Searchbar_spec.ts to account for the new licenses option

Test plan:
1) Run yarn cypress open
2) Select the Searchbar_spec.ts test
3) The test should pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5b3d848b2e)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 14:15:28 +00:00
Pedro Amorim f1bc806ade Bug 33490: Add test 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 80d73b87c4)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:22:37 +00:00
Martin Renvoize 61d4a4ffa4 Bug 33490: Make url consistent 
This ensures we populate the max_expiration_date param on the browser
url for consistency with selected dates.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit f9cb6b823e)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:20:44 +00:00
Martin Renvoize 4b22dff729 Bug 33490: Unit tests 
This patch adds cypress tests for the filter by expired functionality in
the ERM Agreements page.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 6f68b350ba)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:20:10 +00:00
Pedro Amorim b6d543fc27 Bug 33408: Remove obsolete tests and template sys pref code 
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0f01c16ba1)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:16:18 +00:00
Pedro Amorim 8c410fdec3 Bug 33408: Prevent access to erm module by URL if sys pref is disabled 
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0efb53b3a2)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:16:01 +00:00
Jonathan Druart 86d99a5613 Bug 33408: Mock ERM sysprefs from cypress tests 
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2579b95db9)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-05-15 13:15:25 +00:00
Jonathan Druart fd07365543
Bug 33066: Fix cypress tests 
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0a89bf85e0)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2023-05-11 17:01:28 +01:00
Jacob O'Mara 50ec3f8891 Revert "Bug 33416: Fix Searchbar_spec.ts" 
This reverts commit 5eec29d2da.

Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-10 16:00:01 +01:00
Jacob O'Mara 4011dbe023 Revert "Bug 33416: Fix Agreements.ts" 
This reverts commit e1fbe67683.

Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-10 16:00:01 +01:00
Tomas Cohen Arazi 5eec29d2da Bug 33416: Fix Searchbar_spec.ts 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 5a39823dbc)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-09 21:46:05 +01:00
Jonathan Druart e1fbe67683 Bug 33416: Fix Agreements.ts 
<failure message="Timed out retrying after 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying a
fter 10000ms: Expected to find element: `#agreements_list table tbody tr:first`, but never found it.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 2167028025)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-09 21:45:55 +01:00
Tomas Cohen Arazi 3dbbe2b627 Bug 33402: (follow-up) Move Searchbar_spec.ts 
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7c8c983795)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-09 21:39:39 +01:00
Jonathan Druart 25abcc024f Bug 33402: Move ERM Cypress tests to their own directory 
We need to move the existing Cypress tests (that are ERM only, t/cypress/integration/*.ts )
to their own subdirectory, eg t/cypress/integration/ERM

Test plan:
Confirm that the cypress tests are still passing after this change:
  perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 3143549403)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-05-09 21:38:31 +01:00
Matt Blenkinsop cffc3331e5 Bug 33422: Add cypress test 
This patch adds a cypress test to check whether the "active" class is correctly updating when navigating

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0b16749efb)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
 2023-04-16 18:37:50 +01:00
Pedro Amorim b428bd0b2a
Bug 33282: Feed an array of titles so that no dialog message appears 
Including but not limited to the one we're testing for

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b88d364018)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2023-03-24 10:35:16 +00:00
Pedro Amorim 25a0f210ba
Bug 33282: Move get_title to index.js to be invoked by different specs 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit f718fe6a0a)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2023-03-24 10:35:15 +00:00
Pedro Amorim bfeabc271a
Bug 33282: Remove useless intercept 
JD amended patch: replace "redundant" with "useless". It's not the same
intercept, but we don't need the one removed by this patch.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a56cbc6d47)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2023-03-24 10:35:14 +00:00
Pedro Amorim 89c685039d
Bug 33282: Rename Dialog.spec.ts to Dialog_spec.ts 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7c5d0a208d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
 2023-03-24 10:35:13 +00:00
Pedro Amorim 401b17bc06 Bug 33235: Fix cypress tests 
Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them.

* Apply patch
* Run cypress tests and verify all pass

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 16e6d93763)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-03-17 17:16:05 +00:00
Jonathan Druart 57dbb67e60 Bug 32991: Add cypress tests for the dialog box 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dc40b5dd08)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
 2023-03-16 19:23:58 +00:00
Pedro Amorim 91e2554685 Bug 32991: Fix cypress tests. Added new test for when deleting from show view. 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 48b39533f6)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
 2023-03-16 19:23:18 +00:00
Jonathan Druart 9333b9c17b Bug 32925: Add test 
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit b312b63136)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
 2023-02-28 19:09:02 +00:00
Tomas Cohen Arazi 996527b28e Bug 32898: Avoid hardcoding user/pass in tests 
This patch makes the authentication parameters be configurable through
env. Before this, it was hardcoded to koha/koha, which only works if the
ktd defaults haven't been tweaked.

If no env is defined, it fallsback to koha/koha.

In order to pass the ktd configured params, the tests need to be run
like:

$ yarn cypress run --env KOHA_USER=$KOHA_USER,KOHA_PASS=$KOHA_PASS

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 53bebb413a)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
 2023-02-24 10:59:48 +00:00
Jonathan Druart 28033aea4e Bug 32898: ERM - Improve fetch 
... and fix cypress tests

The main problem was that there were no more checkError call for fetchLocalTitleCount
and the error was not displayed on the UI.

This commit is doing several things:
- Refactor fetch.js to call the same fetch method (myFetch) in order to
deal with the error in a single place
- Have a new myFetchTotal JS function to get the X-Total-Count header
from the response and get the benefit of the previous refactoring
- Rename fetchCountLocalPackages with fetchLocalPackagesCount to match fetchLocalTitleCount
- Use fetchLocalPackagesCount on the Package list view
- Use checkError from components using fetch directly. Ideally the could
should be moved to fetch.js and myFetch should be used.
- checkError get a new flag in parameter to ask for the response instead
of the result (ie. the JSON of the response). That's useful when we need
the response status or the headers
- Make checkError throw a proper exception to stop propation. This
modify the error we display on the UI, it's why we have the following
changes in cypress tests:
-            "Something went wrong: Internal Server Error"
+            "Something went wrong: Error: Internal Server Error"
That's not ideal, we should have our own JS exception to avoid that
"Error" (coming from the toString call on the error)

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit a294c5e901)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
 2023-02-24 10:57:54 +00:00
Jonathan Druart 3094ce15c0 Bug 32898: Fix Cypress tests 
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 61656983f2)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
 2023-02-24 10:57:23 +00:00
Jonathan Druart a711e153d6
Bug 32131: Make sure we login before we restore original pref's value 
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
 2022-11-17 13:39:46 -03:00
Jonathan Druart fc48e6117f
Bug 32131: Move set_ERM_sys_pref_value to before 
We cannot (yet) move login to before, but we can set the pref before all
the tests. We need to login in before anyway to retrieve the value of
the pref.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
 2022-11-17 13:39:45 -03:00
Pedro Amorim 5d794c99cc
Bug 32131: Cypress tests are failing if ERMModule is off 
This patch solves this by enabling the system preference before each test,
right after login. It also sets the system preference back to its original
initial value after the tests finish running.

To test:
1) Disable ERMModule system preference
2) Run cypess tests: yarn cypress open / yarn cypress run
3) Verify that tests run successfully
(Optional): While tests are running, visit the system preferences panel and verify that the system preference is now "Enable".
4) Wait for the tests to finish and confirm that the system preference is set back to its original "Disable" value.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
 2022-11-17 13:39:45 -03:00
Jonathan Druart 4f1f8bb4ea
Bug 32030: Move cypress to t/ 
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
 2022-11-08 09:44:51 -03:00