gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 33235: Fix cypress tests 

Some inconsistencies leftovers from 32495 and 32997 were causing cypress tests to fail, this fixes them.

* Apply patch
* Run cypress tests and verify all pass

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 16e6d93763)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
This commit is contained in:
Pedro Amorim 2023-03-15 14:23:37 -01:00 committed by Matt Blenkinsop
parent ee68d7f8d4
commit 401b17bc06
4 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
t/cypress/integration/Agreements_spec.ts
View File

@ -187,7 +187,7 @@ describe("Agreement CRUD operations", () => {
cy.get("#agreements_add").contains("Submit").click();
cy.get("input:invalid,textarea:invalid,select:invalid").should(
"have.length",
3
2
);
cy.get("#agreement_name").type(agreement.name);
cy.get("#agreement_description").type(agreement.description);
@ -515,7 +515,7 @@ describe("Agreement CRUD operations", () => {
statusCode: 500,
error: "Something went wrong",
});
cy.contains("Accept").click();
cy.contains("Yes, delete").click();
cy.get("main div[class='dialog alert']").contains(
"Something went wrong: Error: Internal Server Error"
);
@ -563,7 +563,6 @@ describe("Agreement CRUD operations", () => {
cy.get('#agreements_show .action_links .fa-trash').click();
cy.get(".dialog.alert.confirmation h1").contains("remove this agreement");
cy.contains("Yes, delete").click();
cy.get("main div[class='dialog message']").contains("Agreement").contains("deleted");
//Make sure we return to list after deleting from show
cy.get("#agreements_list table tbody tr:first")

1
t/cypress/integration/Licenses_spec.ts
View File

@ -309,7 +309,6 @@ describe("License CRUD operations", () => {
cy.get('#licenses_show .action_links .fa-trash').click();
cy.get(".dialog.alert.confirmation h1").contains("remove this license");
cy.contains("Yes, delete").click();
cy.get("main div[class='dialog message']").contains("License").contains("deleted");
//Make sure we return to list after deleting from show
cy.get("#licenses_list table tbody tr:first")

1
t/cypress/integration/Packages_spec.ts
View File

@ -353,7 +353,6 @@ describe("Package CRUD operations", () => {
cy.get('#packages_show .action_links .fa-trash').click();
cy.get(".dialog.alert.confirmation h1").contains("remove this package");
cy.contains("Yes, delete").click();
cy.get("main div[class='dialog message']").contains("Local package").contains("deleted");
//Make sure we return to list after deleting from show
cy.get("#packages_list table tbody tr:first")

1
t/cypress/integration/Titles_spec.ts
View File

@ -498,7 +498,6 @@ describe("Title CRUD operations", () => {
cy.get('#eholdings_title_show .action_links .fa-trash').click();
cy.get(".dialog.alert.confirmation h1").contains("remove this title");
cy.contains("Yes, delete").click();
cy.get("main div[class='dialog message']").contains("Local title").contains("deleted");
//Make sure we return to list after deleting from show
cy.get("#titles_list table tbody tr:first")