Matt Blenkinsop
bbc3041a6c
Bug 38010: Translation fix
...
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:29 +02:00
Matt Blenkinsop
fb4f2e42b1
Bug 38010: Migrate to_api logic to GET endpoint
...
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:28 +02:00
Jonathan Druart
c5819f40a8
Bug 38010: Embed baskets+count and subscriptions+count
...
We don't need to whole list of baskets and subscriptions
(cherry picked from commit 391b4d3b32b57c97bfb7e66ab394020ae7eed0e5)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:28 +02:00
Jonathan Druart
a780f0396f
Bug 38010: Fix LeftMenu
...
(cherry picked from commit a78af54eebf07a623779f4642bcdad28f35e662f)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:27 +02:00
Matt Blenkinsop
9105ba1e63
Bug 38010: (QA follow-up) Move syspref values to config endpoint
...
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:26 +02:00
Jonathan Druart
1e780ea61d
Bug 38010: Add tests for embed contacts,interfaces,aliases
...
(cherry picked from commit cae75569e6e8f2bfe5a2e6d3acc111485f81cc1e)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:25 +02:00
Jonathan Druart
9c1f586b3d
Bug 38010: Fix wrong use of scalar in the REST API controller
...
It was wrong, we need to use scalar on the array, not the arrayref
(otherwise it will always be true)
No change in behaviour expected here, just some code cleaning
(cherry picked from commit 7abbcb7ba73da13d988202aaf06ba239e21692da)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:25 +02:00
Jonathan Druart
859d4d6847
Bug 38010: Fix links to the manual
...
The way we deal with routes for VueJS is messy and will need to be
reconsidered, but it's not within the scope of this patch.
(cherry picked from commit 2558583ef0fbf149664a3d9a2e3cec081ac505ff)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:24 +02:00
Jonathan Druart
3677a4490e
Bug 38010: Code improvement
...
(cherry picked from commit a14f1898672950be9d9097bc7b5dd56392a241b0)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:23 +02:00
Jonathan Druart
9df1a2562b
Bug 38010: Remove op=do_search from the 'Invoices' link
...
So we don't see "no result for your search"
(cherry picked from commit 1cc3dabaa25d503b6b6b7d49d81c9bf739013d10)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:23 +02:00
Matt Blenkinsop
cbb7219de5
Bug 38010: (QA follow-up) Remove extra sidebar_menu class
...
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:22 +02:00
Matt Blenkinsop
0dc0e565c3
Bug 38010: (QA follow-up) Add missing filter to main-container.inc
...
Amended-by: Jonathan Druart
-[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 | $raw %] <script src="[% islands %]" type="module">
+[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %] <script src="[% islands | $raw %]" type="module">
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:21 +02:00
Matt Blenkinsop
2286b1c55e
Bug 38010: (QA follow-up) Add a Link component
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:20 +02:00
Jonathan Druart
56efd7638f
Bug 38010: Improve show/hide password icon
...
Use font-awesome-icon tag and add "hide"
Also prevent the scrollbar to jump when the link is clicked (removing
href)
(cherry picked from commit 78876ee276cf0af6e307cd7a033bbbe2842e1dc1)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:20 +02:00
Matt Blenkinsop
3b1aed7fe5
Bug 38010: (QA follow-up) Add a 'Show password' option
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:19 +02:00
Matt Blenkinsop
8e17c636ef
Bug 38010: (QA follow-up) Add new apache redirect
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:18 +02:00
Matt Blenkinsop
36367bc316
Bug 38010: (QA follow-up) Stop breadcrumbs from keeping filters
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:18 +02:00
Matt Blenkinsop
c078585a8c
Bug 38010: (QA follow-up) Email type checking and UI fixes
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:17 +02:00
Matt Blenkinsop
7d0b44d9dc
Bug 38010: (QA follow-up) Add a config endpoint for permissions
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:16 +02:00
Matt Blenkinsop
1393aa163c
Bug 38010: (QA follow-up) Convert delete modal to use the API client
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:16 +02:00
Matt Blenkinsop
30606d2373
Bug 38010: (QA follow-up) Rebase on main
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:15 +02:00
Matt Blenkinsop
64a43ee022
Bug 38010: (QA follow-up) Handle form parameters in the browser
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:14 +02:00
Matt Blenkinsop
6fa18591cb
Bug 38010: (QA follow-up) UI fixes
...
This patch addresses
- Translation issues in VendorList
- Removing the pagers from the contracts table
- Removing redundant code from the vendors template file
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:13 +02:00
Matt Blenkinsop
a327810e9f
Bug 38010: (QA follow-up) Adjust mapping for the manual
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:13 +02:00
Matt Blenkinsop
e3d53ca75f
Bug 38010: (QA follow-up) Fix issues on vendor edit page
...
This commit addresses the following:
- Prevents form submission when hitting enter in the alias field
- validation for the discount field
- restores delete functionality to interfaces
- fixes the broken edit button on the list view
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:12 +02:00
Matt Blenkinsop
10c35e60f2
Bug 38010: (QA follow-up) Fix issues in Show component
...
This patch addresses the following:
- website links were buttons so we now can pass a css class to the toolbar buttons again
- contact options have been formatted to have the correct margin
- the dropdown-item class has been added to the dropdown button list
- entries in the dropdown were opening in a new tab, they are now a callback to avoid this
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:11 +02:00
Matt Blenkinsop
88b7598b73
Bug 38010: (QA follow-up) Move island hydration to container wrapper
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:11 +02:00
Matt Blenkinsop
bbbf71f971
Bug 38010: (QA follow-up) Redirect Home component to List
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:10 +02:00
Matt Blenkinsop
8f93413671
Bug 38010: (QA follow-up) Update routes to include 'acquisition'
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:09 +02:00
Matt Blenkinsop
7f9b15673e
Bug 38010: (QA follow-up) Fix toolbar on VendorShow
...
The delete button was missing from VendorShow and bug 37301 has been removed as a dependency so some small fixes were required for that
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:08 +02:00
Matt Blenkinsop
964c160f64
Bug 38010: (QA follow-up) Add unit tests
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:08 +02:00
Matt Blenkinsop
6e68311ad7
Bug 38010: (QA follow-up) Convert vendor menu to Vue island
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:07 +02:00
Matt Blenkinsop
df7584147c
Bug 38010: (QA follow-up) Rebase for bug 38854
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:06 +02:00
Matt Blenkinsop
52ee9805d7
Bug 38010: (QA follow-up) Rebase for bug 37930
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:06 +02:00
Matt Blenkinsop
e85ae2c02c
Bug 38010: (QA follow-up) Remove unnecessary code from booksellers.pl
...
Bug 38010: (QA follow-up) Fix QA tests
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:05 +02:00
Matt Blenkinsop
1a4eda23f6
Bug 38010: (QA follow-up) Rebase acquisitions amd vendor menus
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:04 +02:00
Matt Blenkinsop
54070647d5
Bug 38010: (QA follow-up) Use format_price
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:03 +02:00
Matt Blenkinsop
4dcaa37cc0
Bug 38010: (QA follow-up) Fix vendor show component
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:03 +02:00
Matt Blenkinsop
0d64a17c48
Bug 38010: (QA follow-up) Fix delete button
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:02 +02:00
Matt Blenkinsop
2b3bb63c29
Bug 38010: (QA follow-up) Restore navigation links
...
This patch restores any links that previously pointed to booksellers.pl as this script is still in use. All references to supplier.pl remain pointed at the new Vue app
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:01 +02:00
Matt Blenkinsop
e511d36482
Bug 38010: (QA follow-up) Fix new vendor form
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:01 +02:00
Matt Blenkinsop
7afe584dbc
Bug 38010: (QA follow-up) Template fixes
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:19:00 +02:00
Matt Blenkinsop
f1b9e5c527
Bug 38010: Change how interface details are displayed
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:59 +02:00
Matt Blenkinsop
fa6fbd9a89
Bug 38010: Apply format_date to vendor contracts
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:58 +02:00
Matt Blenkinsop
251bf0cc10
Bug 38010: Remove unnecessary buttons
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:58 +02:00
Matt Blenkinsop
6015c1c52c
Bug 38010: Only allow one primary contact
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:57 +02:00
Matt Blenkinsop
0b032c2585
Bug 38010: Check for invoices before allowing vendor deletion
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:56 +02:00
Matt Blenkinsop
ebb1e2a978
Bug 38010: Check for baskets for receive shipments button
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:56 +02:00
Matt Blenkinsop
29ca78bb48
Bug 38010: Prevent vendor contacts from duplicating
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:55 +02:00
Matt Blenkinsop
027582efef
Bug 38010: Fix navigation links
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-05-02 17:18:54 +02:00