Commit Graph

9097 Commits

Author SHA1 Message Date
Joe Atzberger afb5166070 Squash warnings by checking if $type is defined before comparing it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:53:23 +01:00
Owen Leonard eaf82964fb This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:53:14 +01:00
Henri-Damien LAURENT c84ad27fbf Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:52:26 +01:00
John Beppu 83ef48aa68 bug 2707 - overdue rules not being deleted
* I added some code to detect the rows which were blank,
  and I deleted them upon saving the form.
* Updated to get the categories from the database
  instead of hardcoding them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:16:04 +01:00
Joe Atzberger 558546fc33 Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:15:55 +01:00
Joe Atzberger (siptest 028b15253a followup - make barcode_to_borrowernumber an internal function
Set this function apart with _ since it is not OO like the rest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:14:25 +01:00
Clay Fouts 727cbd2241 bug 2729: redundant call to C4::Biblio::get_biblio_authorised_values
Removes redundant and expensive call to C4:Biblio:get_biblio_authorised_values

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:14:19 +01:00
Owen Leonard 5f9935be9c Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:14:12 +01:00
Owen Leonard 8879c0de66 Terminology and spelling corrections. Fixes Bug 2724.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:14:06 +01:00
Owen Leonard 69d02de492 Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:14:03 +01:00
Michael Hafen e3528b3e83 Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:13:57 +01:00
Galen Charlton 9c998bac03 bug 2682: followup - only do lc() on $op once
Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:13:02 +01:00
Owen Leonard a2c7956faa Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:12:49 +01:00
Joe Atzberger 2a12fec0f8 Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:12:34 +01:00
Allen Reinmeyer 17e956aeed Bug #2709 Cannot add from Search to New list
While a new list was created, no subsequent call to add the biblio number was made,
thus a new empty list would be created every time.
Under the existing list add, the same code to add items would also apply to a new list,
so I refactored out the logic to add items and made a new subroutine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:12:01 +01:00
Galen Charlton 8cbffd719b followup to Calendar overhaul
correct an errant "SELECT FROM" that slipped in

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:11:40 +01:00
Joe Atzberger ae9a0c8f5f Begin Calendar overhaul, turn on warnings.
Reuse SQL with placeholders where possible.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:11:37 +01:00
Galen Charlton d35bed6b40 bug 2543: follow-up patch
Add 'use C4::Reports' lines that original patch
omitted.

Note that original patch prevented these two reports
from even compiling.  Not good.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:11:32 +01:00
Jesse Weaver b69e271424 fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:11:26 +01:00
Joe Atzberger c57d2de516 Patch security hole in vestigial report.
IMHO, this report should be removed in entirity because of its faulty
construction and total inability to distinguish between register "tills".
That is, it appears to be a valid accounting measure but isn't.
In any case, it let's not let just anybody run it!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:11:22 +01:00
Henri-Damien LAURENT d64859b727 Steamlining javascript for cloning additem block and tweaking style.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:04:57 +01:00
Owen Leonard 9731a400d6 Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:03:19 +01:00
Owen Leonard bb3d1d8012 Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:03:11 +01:00
Owen Leonard 28861c99a0 Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:02:48 +01:00
John Beppu a00f3e19b8 1571
made the description show up by running the query w/ the required number of params

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:02:34 +01:00
Allen Reinmeyer 0da07d19ba Bug #2030 z3950 search function does not filter
Entering a term in the z3950 search box does not filter the results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:02:15 +01:00
Galen Charlton 9d81a40be4 bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:02:08 +01:00
Owen Leonard 14e7cff150 OPAC-side ISBN display fix (Bug 2592)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:02:00 +01:00
Owen Leonard d7b9360fc0 Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:01:57 +01:00
Owen Leonard e439ec4298 Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:01:51 +01:00
Ryan Higgins a8d24fdeaf Bug 2660: Add command-line options to overdue notice script.
This commit adds two options to the overdue_notices.pl script.
The notices are now generated in one of two modes: default or triggered.
In default mode, every time the script runs, a notice is generated if an item
is overdue within a notice date range.  This mode is suitable for a weekly cron
(or manual run), but the notice triggers should be syncronized with the cron script such that
the script is run once per notice date range.  Otherwise, duplicate messages will
be generated ( or no notice generated if a notice date range passes without the script being run).
Triggered mode is suitable for a nightly cron job: a notice is generated only on those
days that an overdue item enters a notice date range.  This mode is susceptible to message
loss when the cron script fails to run, or when notice triggers are edited.

A second flag is added: --list-all, which causes items.content to list all currently overdue items.
Without this flag, only items that are overdue within the given notice's date range are listed on
that notice.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:01:22 +01:00
Nahuel Angelinetti 3c6dc64db7 Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:01:09 +01:00
Galen Charlton da6174c8d3 followup - use &amp; in place of &
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:01:03 +01:00
Joe Atzberger 497a2d8e26 Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them.  The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:00:51 +01:00
Michael Hafen 308b409cc5 fix calls to get_template_and_user in label-item-search.pl
remove extra flagsrequired line.
move call in first branch to the top.
  This will be important is IndepenantBranches code is later added to,
for example, C4::Items::get_itemnumbers_of()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 15:00:44 +01:00
Michael Hafen 5da53136d8 bug in 'Add/Change link to item details...' I missed Previous checkouts area
This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:52:08 +01:00
Ryan Higgins 6cb546ecab Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive
removing requirements for parameters &  management respectively for these two tools.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:52:06 +01:00
Michael Hafen e41cf34933 Adding a few columns to members/readingrec.pl
Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:51:16 +01:00
Michael Hafen 2844db2ede In members/readingrec.pl use itemcallnumber is classification isn't set
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:51:00 +01:00
Galen Charlton d10e97bf00 bug 2659: fix crash in OAI-PMH interface
When retrieving a record via the OAI-PMH interface, if one of the fields used
to prepare the DC metadata is not defined in the MARC framework (e.g.,
biblioitems.publicationyear in the default MARC21 framework), an OAI GetRecord
can fail with the following error:

> Can't call method "as_string" on an undefined value at
> /usr/share/koha/opac/cgi-bin/opac/oai.pl line 59.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:50:50 +01:00
Michael Hafen 2892f6e69b bugfix: Sort previous borrowers descending in Items.pm for moredetail.pl
The list of previous borrowers on moredetail.pl shows the three oldest
rather than the three most recent as I expected.  This changes the sql
to order descending so we get the three most recent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:50:48 +01:00
Galen Charlton 21d009766f bugfix: reenable listing suggestions by anyone
Change in parameter name in template not reflected
in script.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:50:39 +01:00
Henri-Damien LAURENT a70145f26a Displaying branchnames rather than branchcodes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:50:00 +01:00
Michael Hafen c8f2092ebe Don't pull all of biblioitems in GetItemsInfo
Pulling marc and marcxml for some 1200 copies takes a lot of RAM.  Lets
not do that.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:57 +01:00
Nahuel Angelinetti 846121e4ce Fix the CSV export, provide it in UTF-8
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:43 +01:00
Galen Charlton a79b784f9c debugify a warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:37 +01:00
Galen Charlton d23632a77d bugfix: fixed reference to sort2 column in query
Fixes following error when using the patron statistics report:

DBD::mysql::st execute failed: Unknown column 'sort' in 'where clause' at /home/gmc/koha/dev/reports/borrowers_stats.pl line 127

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:26 +01:00
Owen Leonard fe7d78892b Some changes to improve display on Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:04 +01:00
Owen Leonard 99f92cc8a5 Changes to prevent javascript errors in Internet Explorer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:49:01 +01:00
Galen Charlton e5bc07dbc6 followup on Owen's patron attributes patch
Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 14:48:54 +01:00