- XSLT didn't contain the class markup which acts as a hook
for the JavaScript highlighting system.
- Standard results page also contained a typo which
prevented data other than title and author from
being highlighted
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit b558c0db5a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
line breaks, improving table width and horizontal scrolling.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit f987d35a22)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Trying to see the wood from the trees
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 9e5366734b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
* New code *must* have an accurate copyright statement;
it isn't 2000-2002 any more.
* Enable warnings in new code, don't do
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 0187e38ad7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Also added some test facilities
wr73785
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit e2e1dfd86e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
for no benefit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c95b5153e0)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
More podchecker cleanups to eliminate warnings / errors
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit efa66f1f55)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
working through the master branch to eliminate all
podchecker warnings/errors
Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9fa574f609)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Script to test modules compile, when used with a pre-commit hook this
can test before a commit
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7ecf2c2dc4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5e1b8167c2)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Rebased to current HEAD, small error fixed.
Should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 863830f3f9)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
MARC editor code not needed here.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 2c794d1af7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This is the sibling to the fix for this bug for the bib
editor. However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks. See bug 4887.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit daabd936d6)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Thx to Brooke for helping with the wiki.
This is the last patch.
We will have to change some more links, after translate.koha.org was moved.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d829dc1c6a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Loop on results should stop before $i==@servers. Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a3ceef434e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of by translation scripts.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c616cb5081)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Also fixes the same bug on the Itemtypes administration page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fbbab73492)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 072896d66b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
The way an existing value was tested was wrong. 0 is a valid value but a
false value for Perl.
=> replace privious proposal.
[3.2] Should also apply.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 07cfc5d69c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 6df634855c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9f688ad92b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35cf30ef15)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8dded0c269)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Suppress Browse Shelf link on OPAC detail page when there is no item
call number.
[3.2] Should also apply on 3.2
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e40b180d1d)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
The function was too complex for so simple stuff, not we check if one of all items of the record can be issued.
[Note by Galen Charlton: not only does this patch simplify the routine,
it also makes it behave correctly.]
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 363c1ca9f9)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This patch adds the standard date format hint used elsewhere
in the interface.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 51405bcce4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This was due to poorly constructed SQL which returned duplicate values for
certain fields. This patch corrects that SQL.
NOTE: There is also a formatting problem with the message prefs display table
when it is displayed in moremember.pl. This is due to there being no logic to
tell the table in that context to display checkboxes as appropriate. This patch
does not fix that. Bug 5328 has been opened for this problem.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 321eed9833)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This patch also fixes an unreported bug where switching from any
other framework to 'Default' would bring up no MARC data.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b0e29e5595)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Applied Owen's patch to current head, updated de-DE translation. The pull down values are now translated.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd28366523)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Galen Charlton
Colin Campbell
Owen Leonard
Nicole Engard
Srdjan Jankovic
Chris Cormack
Andrew Elwell
Katrin Fischer
Frédéric Demians
Chris Cormack
Marcel de Rooy
Chris Nighswonger
Nahuel ANGELINETTI
ByWater Solutions