Small fix with thanks to Galen.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1bd67e28e5)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Adding "readonly" class to readonly fields to guarantee
that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
fields for additional visual feedback
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 240ce5a31c)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b050029c65)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Searches such as au,phr and kw,wrdl were passing through the regexes
that should replace colon with equals
add wrdl and phr
use trn so not just rtrn is spotted
Where we were checking for multiple spaces specify that in the
regex not just two spaces
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b97c4dba7a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Ok it wasn't an april fools trick, but just a typo, april fools trick
sounds better though right?
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0fa9ade9ff)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4b69538f9b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Fixes the doubled up display of the publisher.
This patch fixes the bug in both the OPAC and staff client
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c0272a6b66)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
I can't see any good use for a back button here, so I'm taking it out.
An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fa43573b58)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This was due to passing off the biblionumber to GetFines rather than the itemnumber.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c1463e7255)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Adding "Lists that include this title" links
- Also correcting minor XHTML error in the same section of opac-detail.tmpl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0a26982378)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Removing 'suggestions waiting' link from left-hand menu. A plain
'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
on the Acquisitions home page. This will show, with a count
of pending suggestions, only if suggestions are turned on and
there are pending suggestions.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d9de6ebab3)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page. For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used. Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.
My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d9db65a17e83f64c5858c6fd7ad8dc0d1e7660ab)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3357d811ee)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Auth.pm put the noItemTypeImages preference under "intranet only."
Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d4f02c469b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit fcb3668512)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
This fix adds only public notes. A div is added as a hook for styling
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit be54744836)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Also corrects framework display in the case of the default
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1586306866)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
If no failures are to be added to the to the strings for redirect
the corresponding variables are undefined causing warnings
to be logged. Initialize them so that the error log is not
being filled with trivia.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bd93bfdbc4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Rebased to HEAD, should also apply to 3.2
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d39dd6d857)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Patch rebased to HEAD, should also apply to 3.2
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit ed0ccd9f57)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- XSLT didn't contain the class markup which acts as a hook
for the JavaScript highlighting system.
- Standard results page also contained a typo which
prevented data other than title and author from
being highlighted
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit b558c0db5a)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
- Adding inline preview/import menu to match cataloging z39.50 search
- Improving behavior of inline menu on both pages
- Adding white space to ISBN/ISSN output on both pages to allow
line breaks, improving table width and horizontal scrolling.
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit f987d35a22)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Trying to see the wood from the trees
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 9e5366734b)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
* New code *must* have an accurate copyright statement;
it isn't 2000-2002 any more.
* Enable warnings in new code, don't do
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit 0187e38ad7)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Also added some test facilities
wr73785
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
(cherry picked from commit e2e1dfd86e)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
for no benefit
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c95b5153e0)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
More podchecker cleanups to eliminate warnings / errors
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit efa66f1f55)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
working through the master branch to eliminate all
podchecker warnings/errors
Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)
Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9fa574f609)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Script to test modules compile, when used with a pre-commit hook this
can test before a commit
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7ecf2c2dc4)
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Chris Nighswonger
Marcel de Rooy
Owen Leonard
Colin Campbell
Chris Cormack
Galen Charlton
Chris Nighswonger
Katrin Fischer
Katrin Fischer
Nicole Engard
Srdjan Jankovic
Andrew Elwell
Katrin Fischer