Commit Graph

8961 Commits

Author SHA1 Message Date
Joe Atzberger 8c1bb827ff Remove double conditional, fix one FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Joe Atzberger cbd6368f58 Minor cleanup, updated POD.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Owen Leonard 084b442038 A few more en-US spelling corrections; Markup corrections; Standardizing on "email" instead of "e-mail"; Copying isbn-formatting from opac-detail.pl to detail.pl;
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Galen Charlton 60b676c34c bug 2585: fix search links for names (XSLT OPAC display)
Fix malformed OPAC search syntax that caused this bug:

When using the default stylesheet for MARC21 XSLT OPAC details display, the
search links for name headings (from 100, 700, 710, 710, 111, and 711) that are
linked to authority records don't work.  When the user clicks on such a link,
they are directed to the advanced search form instead of the search results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Joe Atzberger (siptest a3c16d48e8 Correct application of noissues flag in SIP.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Danny Bouman 36fbcb8d1e bug2580: category name and home library will now correctly display on all patron tabs
This patch fixes several improperly named variables and includes the home library variable on the pages that were missing it. The category
description was added to the GetMemberDetails function since a couple of the pages using that function required the variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Michael Hafen 69a77be139 bugfix: need to return something if an itemtype doesn't have an image
I noticed that on the search pages if an itemtype doesn't have an image it's information doesn't make it out the the template.  I don't understand why, but this fixes it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Henri-Damien LAURENT aa9e3d0f7b bug fix 2590 :
seems that when itemtypeimagelocation returns undef, the hash is messed up.
put it at the end of the hash and everything is fine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Jesse Weaver de6db90b73 fix for bug 2577: Cannot delete patron in IE
Internet Explorer seems to have a problem with JS array and object constructors that have a comma at the end. There may be other JavaScript files that have this problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Joe Atzberger ec0618b441 Remove unnecessary EXPR.
There are two problems with this EXPR:
 (1) It's unnecessary, and
 (2) It's an EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Galen Charlton 817446903d HTML fixes for matching-rules.tmpl
* maxnorms, maxoffset => maxlength
* no escape attribute in <input> elements

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:29 +01:00
Joe Atzberger 323db040ad HTML validation adjustments to about.pl
Corrects the Tidy errors:
line 428 column 19 - Error: "tr" not finished but containing element ended
line 428 column 19 - Error: end tag for "tr" omitted, but OMITTAG NO was specified
line 426 column 25 - Info: start tag was here
line 452 column 31 - Error: end tag for "strong" omitted, but OMITTAG NO was specified
line 452 column 12 - Info: start tag was here
line 518 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag
line 525 column 17 - Error: document type does not allow element "ul" here; missing one of "object", "applet", "map", "iframe", "button", "ins", "del" start-tag

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Galen Charlton aefd2b3223 remove debug warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Joe Atzberger 707fcf4446 Validation fix, include required "type" in link tag.
This removes validation warnings like:
  Warning: <link> inserting "type" attribute

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Joe Atzberger adaf879d59 Documentation update (test-single not single-test)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Henri-Damien LAURENT 3fd62098ce Bug fixing : 2516
There was a problem with names ordering in circ/circulation.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Owen Leonard f5f870491d Fixing markup errors, tweaking show/hide javascript.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Owen Leonard be54a1109b More markup corrections for better validation.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Owen Leonard 907a5985cb Putting icon sets into tabs. Makes the interface more compact, and much better when editing authorized values for which icons are inappropriate.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Danny Bouman 9330ecd7a0 bug 2569: added the zipcode to display along with the patron address
Added the zipcode to display along with the patron address when you are viewing a Patron from the intranet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Galen Charlton e64115c88f fixing permission 2008-10-28 22:09:28 +01:00
Michael Hafen 237b44121c change link to moredetail.pl. In other places it's called with itemnumber=
Change the link to moredetail.pl from item= to itemnumber=
I saw the link on boraccount.pl as itemnumber= and thought it should be that way here too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:28 +01:00
Michael Hafen 5ee4e08f8b Add/Change link to item details (catalogue/moredetail.pl) for circulation and patron details
This adds the link to item details to circulation.pl
and changes the link on member details to include the itemnumber and #item... in the link.

Forgot the returns.pl.  Will do that in the next patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Michael Hafen eae1168df8 Added link to catalogue/moredetail.pl on the returns page for each returned item
Had to add itemnumber to the hash of returned item information.

Links to moredetail.pl with itemnumber and #item in the url.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Henri-Damien LAURENT d9f37c23b2 modification to show the library and not the username of the person at OPAC.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Galen Charlton 1ed9c8d729 bug 2568: set default value of intranetuserjs to blank
The intranetuserjs syspref allows a Koha administrator
to insert arbitrary JavaScript into the staff page header.
Now that this syspref is functional again, this patch
changes the installation scripts so that the default
value is blank - any JavaScript we ship with Koha should
be in the templates, not in a syspref.

Documentation changes: none per se.  However, I do want to
point out that the intranetuserjs syspref is a bit of a
dangerous one - enter a value with incorrect syntax, and
you could make it difficult to access the staff interface -
and should probably be marked as an advanced option.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Owen Leonard 1355541fa0 Fix for Bug 2557, "Guarantor information - error messaee when clicking borrower# link." Also correcting a couple of minor markup errors.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Owen Leonard 542bf18e3b Fixing tablesorter, display of renew links
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Owen Leonard a83f798573 Spelling corrections: organisation->organization, authorise->authorize, catalogue->catalog
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Michael Hafen 6f576252ba If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl
put it to use.
This happens in members/boraccount.pl if a fine is attached to a
barcode.

This patch makes moredetail.pl show only the item specified by
itemnumber.

Implements some changes to the patch suggested on
patches@koha.org
give visual cue on UI and a link out.
More friendly pruning of the other items.

Thanks to Galen Charlton and Joe Atzberger

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Galen Charlton 3839cf458e Revert "If itemnumber is sent to catalogue/moredetail.pl use it"
Applied wrong version of patch.  Oops.

This reverts commit 9eb1465b28.
2008-10-28 22:09:27 +01:00
Joe Atzberger 2a8ba38bd3 Fines fixes: apparent problems with fines prevent processing.
CalcFine returned values that mismatched expectations in fines.pl.

fines.pl refactored: added debugging, prevent needless recreation of
Calendar objects by storing them in hash by branch.
Still outstanding problems with fines, including the output of a field
that has no other references in Koha (so is always undef) and the
incorrect description of FinesMode.

Calendar exported "new" erroneously.  I also cleaned up the queries to
avoid needlessly compiling additional statement handles.

Please test and consider application to 3.0 maintenance.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:27 +01:00
Michael Hafen cce9d3156e If itemnumber is sent to catalogue/moredetail.pl use it
If itemnumber is part of the url for catalogue/moredetail.pl put it to use.
This happens in members/boraccount.pl if a fine is attached to a barcode.

This patch makes moredetail.pl show only the item specified by itemnumber.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Galen Charlton 3fde5cca1a bug 2466: regression test
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Galen Charlton b2da2158d6 bug 2466: fix clearing item field
When editing an item in the cataloging and serials
item editors, clearing a field now works.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Joe Atzberger cde99f86fa Usage option correction (-h not -n)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Joe Atzberger c72d04af84 Bug 2419: require Exporter
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Galen Charlton ae172a74ed bug 2552: correct issue history display
The loan history for a bib can be incorrect if the bib's
biblioitemnumber is not the same as its biblionumber.
This was due to a bad join in GetBiblioIssues().

Credit to Michael Hafen for patching a similar bug,
which inspired me to check for other bad joins.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
MJ Ray d141fac835 Update INSTALL.debian to mention a2dissite default
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Owen Leonard d91e6574cf Style correction in member entry form; Enabling intranetuserjs in doc-head-close.inc.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Jesse Weaver 8a740c7cbe fix number two for bug 1204: Lists of issues and overdues on opac-user.pl
This makes opac-user.pl sort the output from GetPendingIssues itself, by descend
ing due date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:26 +01:00
Michael Hafen d06179e56a bug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns
the sql seems to assume that biblionumber and biblioitemnumber are always the same, which in my case they aren't.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Owen Leonard ff953199a2 Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Owen Leonard e9ef701363 Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Owen Leonard e295bfdb59 Spelling correction. Fixes Bug 2501.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Galen Charlton 0d711a4c61 bug 2545: fix XSLTDetailsDisplay
Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Jesse Weaver 799c32eb0f Fix itemtype image problem in moremember.pl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:25 +01:00
Galen Charlton 2ef43f56f0 bug 2509: fix file permissions
Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:24 +01:00
Galen Charlton 0e92cff8ab bug 2540: allow download of report
$error return C4::Reports::execute_query is
always defined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:24 +01:00
Jesse Weaver 18ba0fb44d fix for bug 1101: Renew All for the OPAC
This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-10-28 22:09:24 +01:00