Commit Graph

32361 Commits

Author SHA1 Message Date
Marcel de Rooy 82a55e971c Bug 21774: Cloned item subfields disappear when editing an item
Bug 10306 changed behavior on cloning item subfields by no longer splitting
constructions like 'A | B' in item fields like ccode.

If it is really recommended to clone item subfields, I am not so sure
about. But this patch at least restores the possibility to do so while
we discuss if we should ;)

Test plan:
[1] Run Items.t
[2] Make an item subfield repeatable in framework. And test edit items.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected. Also fixes the display of collections on the items
table (on editing items).

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5f34dd06ec)

Conflicts:
	t/db_dependent/Items.t
2018-12-12 17:27:44 +00:00
“Lucas Gass” 919e9567a6 Revert "Bug 21774: Cloned item subfields disappear when editing an item"
This reverts commit d6fe416578.
2018-12-12 17:19:57 +00:00
“Lucas Gass” 436731c537 Revert "Bug 21529: (follow-up) USE raw filter"
This reverts commit 7d7f110cef.

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>
2018-12-12 16:52:39 +00:00
“Lucas Gass” 7f992d9d80 Revert "Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags"
This reverts commit dab7e22c68.

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>
2018-12-12 16:51:58 +00:00
Nightly Build Bot c89029f8da Bug 17111 - Automatic debian/control updates (oldstable/18.05.x)
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
2018-12-11 23:15:18 +00:00
Nick Clemens 8ce960d709 Bug 21649: [18.05.X] Pass guarantee info to template when adding child
To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates

Signed-off-by: “Lucas Gass” <lucas@bywatersolutions.com>
2018-12-10 19:16:43 +00:00
Marcel de Rooy d6fe416578 Bug 21774: Cloned item subfields disappear when editing an item
Bug 10306 changed behavior on cloning item subfields by no longer splitting
constructions like 'A | B' in item fields like ccode.

If it is really recommended to clone item subfields, I am not so sure
about. But this patch at least restores the possibility to do so while
we discuss if we should ;)

Test plan:
[1] Run Items.t
[2] Make an item subfield repeatable in framework. And test edit items.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Works as expected. Also fixes the display of collections on the items
table (on editing items).

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5f34dd06ec)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 22:01:16 +00:00
Marcel de Rooy 99436fa499 Bug 21867: Replace remaining document.element.onchange calls in marc_modification_templates.js
Replace onchange() by jQuery change().

Test plan:
Go to marc mod templates. Add, edit and delete. Check if works and no js
errors.
git grep -l -E "onchange\(" should not have occurrences outside lib.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit be78d3177e)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 21:44:07 +00:00
Marcel de Rooy 45b7f17038 Bug 21819: (QA follow-up) Replace onchange() in touched code
AFAIK we should not call document...onchange() and assume that it works.
Apparently, it does at least in some browsers. But we are not sure.
We could easily replace them here by the documented jQuery counterpart.

Note: If you try git grep -l -E "onchange\(" you will find some
occurrences in two libraries and only in one js file (this one).
We should replace all occurrences here; will open a new report for that.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Verified that the change event was triggered: span should expand/collapse.

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit aeaf74b7cc)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 21:38:47 +00:00
Andreas Roussos 57e031929d Bug 21819: Marc modification templates action always checks Regexp checkbox
When editing a MARC modification template action, the 'RegEx'
checkbox to the right of the 'to field' textboxes will always
appear checked, even if no regular expression has been added.

This patch fixes that.

Test plan (steps 1-5 are copied from the original report -- thanks Pasi!):
1) Go to Tools > Marc modification templates, and create a new template
2) Add a new action to the template
3) Edit the action so it's "Move" field to another field.
   Do not check the RegEx checkbox after the "To" field.
4) Save the action.
5) Edit the same action again. The checkbox is now checked.
6) Apply the patch and hit Ctrl-F5 to do a hard refresh in your browser.
7) Edit the action you saved in 4): this time the 'RegEx' checkbox
   should be unchecked.
8) For completeness, add a regular expression to the "Move" action
   created in 3) and click on 'Update action'. When you re-edit this
   action the 'RegEx' checkbox should be checked.

Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a9fc00db03)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 21:38:25 +00:00
Nick Clemens 391e7f7188 Bug 21854: Use template plugin to display category description
Rather than getting the description in the script and passing, we should
just use the tmeplate plugin to get the description from the category
code.

To test:
1 - Find a patron, note their category
2 - Visit Tools - Batch patron modification
3 - Enter barcode of patron above
4 - Note category does not show in the display of patrons to be modified
5 - Apply patch
6 - Reload the page, note the patron category displays
7 - Modify the patron (anything but category)
8 - Check that category still diplays correctly in results

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Andreas Roussos <arouss1980@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit df68391a5e)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 21:27:15 +00:00
Nick Clemens cf8a03db2c Bug 21837: Don't set holdingbranch filter using selected homebranch filter
To recreate:
1 - Open the overdues report (don't worry if you don't have results)
2 - Choose to filter by homebranch
3 - Note the holdingbranch filter is set to the selected homebranch
4 - Apply patch
5 - Clear filters
6 - repeat
7 - only homebranch is set

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 81ac96abec)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 21:21:36 +00:00
Jonathan Druart dab7e22c68 Bug 21529: (bug 13618 follow-up) Display print notices with HTML tags
Replace a wrong html filter with raw.

Test plan:
Define a HOLD or DISCHARGE notice template, with html tags.
Generate them and confirm that html tags are displayed (which restore
the existing behaviour prior to bug 13618)

Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b704a1adfc)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:46:15 +00:00
Andrew Isherwood 7d7f110cef Bug 21529: (follow-up) USE raw filter
In order to be able to make use of the $raw filter, we need to USE it
first

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a1d24a2b61)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:44:58 +00:00
Mark Tompsett 21536e3314 Bug 21853: (follow-up) to solve printpdf error
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Theoretically this follow-up makes no difference. All modules only export
printpdf and now we are just asking explicitly for printpdf. But if it
resolves some exception on the rule..

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 5b62714e47)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:32:00 +00:00
Julian Maurice 320f9bf3d2 Bug 21853: Fix PDF export of basketgroups
In recent versions of Perl, '.' is not included by default in @INC. This
breaks PDF export of basketgroups.

This patch moves acqui/pdfformat/*.pm files in Koha namespace so that
they can be 'require'd without manipulating @INC

Test plan:
1. Turn off Plack/Starman and test PDF export for every value of
   OrderPdfFormat system preference
2. Turn on Plack/Starman and test PDF export for every value of
   OrderPdfFormat system preference
3. Test on a dev install and a standard/package install

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 3c18d4c18f)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:30:57 +00:00
Mirko Tietgen 857b1524a9 Bug 21567: Move Koha_ExternalContent_OverDrive.t to db_dependent
This tests pass on the build step only because they are skipped, due to
the absense of Test::DBIx::Class library.

It makes sense for them to be in the db_dependent directory, as they are
not completely mocked (re: external world interactions).

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4e78070b80)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:19:59 +00:00
Katrin Fischer cdf27235f4 Bug 21815: Rephrase HidePersonalPatronDetailOnCirculation
Makes it a little easier to translate, also fixes whitespace and capitalization.

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 43d8946d59)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-07 18:17:19 +00:00
Nick Clemens 1d797a8e5c Bug 20598: Update number of tests
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 119653a3a1)

Conflicts:
	t/db_dependent/Circulation.t
2018-12-04 19:00:35 +00:00
Marcel de Rooy 2c77175467 Bug 20598: (QA follow-up) Tiny fixes
[1] Correct POD for _FixOverduesOnReturn
Is called by AddReturn, AddRenewal and LostItem.
Also tested in Circulation.t btw

[2] $dbh is not used in _FixOverduesOnReturn
[3] Moving all parameters to the first line.
[4] Variable $uquery is not used too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 867f88076e)
2018-12-04 18:51:54 +00:00
Kyle M Hall 25ea817edf Bug 20598: Unit test
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit b9ed7699e3)
2018-12-04 18:50:46 +00:00
Kyle M Hall 180909e7a7 Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled
Test Plan:
1) Ensure WhenLostForgiveFine is disabled
2) Create an overdue with a fine
3) Mark it lost with longoverdue.pl
4) Note it is still marked as an accruing fine
5) Apply this patch
6) Repeat steps 1-3
7) Note it is no longer an accruing fine!

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Followed the test plan and it works.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 461a6f53b8)
2018-12-03 19:24:49 +00:00
Marcel de Rooy 2d1332938c Bug 18677: (QA follow-up) Trivial fixes to Chargelostitem.t
Kind of funny that we did not touch this test here. But it passed!
Trivial fixes:
[1] Typo precessfee
[2] Typo the linked
[3] Add rollback

Test plan:
Run t/db_dependent/Circulation/Chargelostitem.t

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit fab9936ddb)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-03 19:05:57 +00:00
Jonathan Druart 8b02c6c3a1 Bug 18677: Remove new issue_id param from charlostitem
We have the itemnumber no need to pass the issue_id, we can retrieve it
from chargelostitem

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 3475670881)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-03 19:05:32 +00:00
Jonathan Druart 6adfbd33f1 Bug 18677: Make the tests pass
Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit cd250dae36)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-03 19:04:44 +00:00
Kyle M Hall b876d09e35 Bug 18677: issue_id is not added to accountlines for lost item fees
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Michal Denar <black23@gmail.com>

[EDIT:]
Patch should have increased the number of tests obviously.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit cde7a8e72c)

Signed-off-by: Jesse Maseto <jesse@bywatersolution.com>
2018-12-03 19:03:54 +00:00
Katrin Fischer 0cc87bd3fb
Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit
The checkout form will be removed if various conditions are
met: Restrictions, a fine above noissuescharge etc.

Bug 19933 changed the conditions, so a restriction will no longer
block checkouts, if the fines are below the set limit.

To test:

- Add a restriction
- Confirm the checkouts form is replaced by a message
- Add a fine below the noissuescharge limit
- Confirm that the form reappears
- Apply the patch
- Check that the checkout form is gone now
- Remove restriction - form should reappear
- Add to the fine, so it's above the limit
- Form should disappear

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 99013d6896)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-30 14:13:40 +00:00
Martin Renvoize bc614e6f1a
Update release notes for 18.05.06 release
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-26 12:14:29 +00:00
Martin Renvoize ef8b7013ee
Increment version for 18.05.06 release
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-26 12:09:46 +00:00
Martin Renvoize c48c4b8ad0
Translation updates RMaint followup for Koha 18.05.05
Fix a C string failure in pt-BR-MARC21

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-26 12:07:23 +00:00
Koha translators 7722123b57
Translation updates for Koha 18.05.06
(cherry picked from commit 702986783d44e06fc5b111c986f1d38b64bebcaf)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-26 11:53:41 +00:00
Nick Clemens c86ed52356
Bug 7143: Update about page for new dev Thatcher Leoonard
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 505e10585c)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:11:38 +00:00
Tomas Cohen Arazi 45eb022786
Bug 21749: (QA follow-up) Add more tests for ImportFramework
This patch adds tests for:
- Output of ImportFramework on fields removal and error conditions (file
  not found)
- Different file format behaviour (csv, xml and ods are tested).

To test:
- Run
  $ kshell
 k$ prove t/db_dependent/ImportExportFramework.t
=> SUCCESS: All green :-D
- Sign off :-D

Note: the biblio_framework* files are based on the original one on the
patchset, and exported in 17.11 with different formats.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit ecf68132b7)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:10:58 +00:00
Jonathan Druart 64405cf906
Bug 21749: Fix import of CSV biblio framework
Bug 9701 added 2 new columns to the table marc_tag_structure which broke
the import of biblio frameworks if the CSV file was generated with a
previous version.

Test plan:
- Export a biblio framework from 17.11
- Import it into 18.05+

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

https://bugs.koha-community.org/show_bug.cgi?id=21740

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 2d1b80d216)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:10:37 +00:00
Jonathan Druart 9e46509487
Bug 21749: Add tests for ImportFramework
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit cbb90000fd)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:10:08 +00:00
Thatcher Leonard 121ba294c4
Bug 18584: Our legacy code contains trailing-spaces
This patch removes trailing spaces from acquisitions-search.inc

Mentored-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e3e2afd88d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:07:33 +00:00
Dimitris Antonakis 5c04130720
Bug 17597: Outdated translation credits
Updated translation credits for the Greek language.

Signed-off-by: Andreas Roussos <arouss1980@gmail.com>
Works as expected, hyperlink to openhub tested OK.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 446142cd2b)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:04:24 +00:00
Jonathan Druart a9aec18538
Bug 21282: Sync ordered and spent values with acqui home
The order list for each fund calculates using the ecost tax excl., but
it should be tax incl.
At the moment this means that the sum on the start page table and the
order list don't match up.

Test plan:
- Create and receive orders
- Values on acqui home and ordered/spent should be the same

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 9d595e36a7)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 16:00:43 +00:00
Martin Renvoize 64a2cdcb83
Bug 21777: (RMaint follow-up) Fix colspan in the footer
This reverts commit 64c1c84fe6.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-23 15:44:57 +00:00
Martin Renvoize aafa08631a
Bug 21777: (RMaint follow-up) Fix for bad merge conflict
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 15:26:16 +00:00
Tomas Cohen Arazi 64c1c84fe6
Bug 21777: (QA follow-up) Fix colspan in the footer
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit ea800323b7)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:31:56 +00:00
Nick Clemens 538dbc73db
Bug 21777: Fix circulation table alignment
TO test:
1 - Check out an item to a patron
2 - Note the columns are misaligned
3 - Apply patch
4 - Updatedatabase
5 - Reload the patron
6 - Note the table is fixed

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 8d4136c766)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:31:24 +00:00
Jonathan Druart d020334b6e
Bug 21777: Add a regression test
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4290426251)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:28:59 +00:00
Jonathan Druart 25fa542479
Bug 21787: Remove unecessary test from GetHardDueDate.t
See description on the bug report for more info.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit fa7b2ad08b)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:20:37 +00:00
Martin Renvoize f3c27b9979
Bug 21766: Correct filtering on AUDIO_ALERT_PATH js
I managed to introduce a bad filter whilst backporting bug 15734 to the
18.05.x series. This patch attempts to correct that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:16:24 +00:00
Jonathan Druart f050c4e1f6
Bug 21775: Logout before trying to login
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7f78d4a148)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:13:12 +00:00
Jonathan Druart f18ef61fcb
Bug 21775: [18.05.x] Add selenium tests for audio alerts
To prevent future regressions

(alternative to a58549422d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 14:11:40 +00:00
Jonathan Druart 26b9c4abac
Bug 21015: Remove unecessary 'use Koha::Schema' statements in t/
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 9fb827d59d)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 13:32:31 +00:00
Joonas Kylmälä f130fd6ec9
Bug 21015: fix performance issue with C4::Members
loading Koha::Schema ("use Koha::Schema;") takes significantly time as
it loads almost a couple hundred classes. Koha::Database has done that
already once and we can use it to get the ResultSet "Borrower" as
well, so let's use that. This also make the code more unified because
Koha::Database is used throughout the code instead of Koha::Schema.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 83e0765f44)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 13:32:12 +00:00
Katrin Fischer 8a98462739
Bug 12258: (QA follow-up) Add some missing rrrrrrs
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

https://bugs.koha-community.org/show_bug.cgi?id=21158

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit a83bc8ca4c)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-11-16 13:15:17 +00:00