Commit Graph

16047 Commits

Author SHA1 Message Date
Mason James 7eef4c8c70 Bug 5668 - Star ratings in the opac
patch applied to commit eb3dc448d2

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 14:40:49 +02:00
Chris Cormack f12a3cc7e7 Bug 7743 follow up fixing syntax to so templates pass test
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Failing test was: xt/author/valid-templates.t

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 14:30:35 +02:00
Chris Cormack 6f3123bbc6 Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac
signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
2012-04-10 13:45:00 +02:00
Chris Cormack 7f2ab970da Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
signed-off-by Jonathan Druart <jonathan.druart@biblibre.com>
2012-04-10 13:44:53 +02:00
Colin Campbell 94ee4697af Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such
Intention of code is that data is output in utf-8 requires an
encoding layer to ensure that. ':utf-8' flags the stream as utf-8
but does not ensure output characters are correctly encoded

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 13:41:58 +02:00
Adrien Saurat abf03414c3 Bug 7871: prevents crash when suggestion linked to erased budget
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 13:41:16 +02:00
Julian Maurice 680e92115f Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber
This sub only takes one parameter

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:57:29 +02:00
Paul Poulain 8a4b05b9d6 Bug 7886 follow-up DBRev number 2012-04-10 11:53:15 +02:00
Dobrica Pavlinusic d8e702dd25 Bug 7886 - C4/ShelfBrowser slow SQL performance
ShelfBrowser uses two SQL queries with syntax

WHERE ((cn_sort = ? AND itemnumber < ?) OR cn_sort < ?)
AND homebranch = ? AND location = ? AND ccode = ?

homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
index_merge intersect(items_ccode,homebranch,items_location)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:37:01 +02:00
Katrin Fischer bd52531d69 Bug 7900: Link to vendor from subscription detail is broken
To test:
- Add a serial subscription with a link to a vendor
- Check the subscription detail page for the name and link to the vendor
- Check that the link works correctly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:35:18 +02:00
Colin Campbell e7971380e8 Bug 2505 : Switch on warnings in circ/returns.pl
Removed a compile time warning caused by a void context
in a bit of too clever obscure code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:30:30 +02:00
Colin Campbell 6078c1acf6 Bug 2505 : use warnings in smart_rules.pl
Fix some careless code redeclaring a variable
declaring a variable in a condition
so that these don't generate errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2012-04-10 11:30:20 +02:00
Mason James beb0678bfc Bug 2505 - enable Perl warnings in all modules and scripts
enable warnings, and correct perlcritic's 'Loop iterator is not lexical' errors in C4/Ris.pm

	modified:   C4/Ris.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:29:33 +02:00
Robin Sheat 804eb9cce1 Bug 7893 - add package dependencies
This adds some dependencies to the control file that are required.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:12:23 +02:00
Katrin Fischer bdf3453512 Bug 2780 - Capitalize strings consistently (home, about, login)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 11:10:02 +02:00
Paul Poulain 0ffd765824 Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-10 10:32:48 +02:00
Katrin Fischer 3213b34082 [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some strings:
* itemcallnumber => item call number
* Profile marcfields=> Profile MARC fields
2012-04-10 10:18:54 +02:00
Katrin Fischer db4af00ce1 [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some vocabulary replacing "shelf" by "list"
2012-04-10 10:16:41 +02:00
Katrin Fischer 55756fc0fb [SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:16:05 +02:00
Katrin Fischer 189c0875c1 [SIGNED-OFF]Bug 2780: Capitalize strings consistently
Fixes some more strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:13:20 +02:00
Katrin Fischer b89da29e01 [SIGNED-OFF]Bug 2780: Capitalize strings consistently
Some missing strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-10 10:12:37 +02:00
Paul Poulain 8e9fc9b385 Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-10 10:04:51 +02:00
Katrin Fischer 0e5b3f3df3 Bug 2780 - Capitalize strings consistently - various
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:16 +02:00
Katrin Fischer 07eeb4b187 Bug 2780 - Capitalize strings consistently (serials)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:15 +02:00
Katrin Fischer 12e4651746 Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:13 +02:00
Katrin Fischer 892d64aa6c Bug 2780 - Capitalize strings consistently (patron cards)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:12 +02:00
Katrin Fischer 968d2b4954 Bug 2780 - Capitalize strings consistently (offline circulation)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:11 +02:00
Katrin Fischer bae9aacb3f Bug 2780 - Capitalize strings consistently (members)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:09 +02:00
Katrin Fischer 2caaf07450 Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:08 +02:00
Katrin Fischer 4de45e4309 Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Fixes some missed strings.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
2012-04-10 10:04:06 +02:00
Owen Leonard 643c80663d Bug 2780 - Capitalize strings consistently (Labels templates)
Correcting capitalization in Labels templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:53 +02:00
Owen Leonard 151d57330c Bug 2780 - Capitalize strings consistently (Labels help)
Correcting capitalization in Labels help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:52 +02:00
Owen Leonard 651e81e677 Bug 2780 - Capitalize strings consistently (Misc. help pages)
Correcting capitalization in various help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:50 +02:00
Owen Leonard da51d835cb Bug 2780 - Capitalize strings consistently (Circulation help)
Correcting capitalization in Circulation help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:48 +02:00
Owen Leonard 95fe4e8453 Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help)
Correcting capitalization in Authorities and Cataloging help pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:46 +02:00
Owen Leonard f2da059165 Bug 2780 - Capitalize strings consistently (Admin help)
Correcting capitalization in Administration help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:37 +02:00
Owen Leonard a32ca9d525 Bug 2780 - Capitalize strings consistently (Acqui help)
Correcting capitalization in Acquisitions help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:35 +02:00
Owen Leonard c0401d62aa Bug 2780 - Capitalize strings consistently (Installer)
Correcting capitalization in Installer templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:33 +02:00
Owen Leonard f38ae56b8f Bug 2780 - Capitalize strings consistently (Error pages)
Correcting capitalization in staff client error pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:32 +02:00
Owen Leonard 9abca40960 Bug 2780 - Capitalize strings consistently (OPAC includes)
Correcting capitalization in OPAC includes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:31 +02:00
Owen Leonard 00a13c5725 Bug 2780 - Capitalize strings consistently (Circulation)
Correcting capitalization in Circulation templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:30 +02:00
Owen Leonard c9f5ba7e8c Bug 2780 - Capitalize strings consistently (Cataloging pages)
Correcting capitalization in Cataloging templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:29 +02:00
Owen Leonard 08f4f94801 Bug 2780 - Capitalize strings consistently (Cataloging plugins)
Correcting capitalization in Cataloging plugins. Also
correcting some instances of invalid HTML.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:27 +02:00
Owen Leonard 7e9533870c Bug 2780 - Capitalize strings consistently (Catalog pages)
Correcting capitalization in the staff client catalog pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:26 +02:00
Owen Leonard 10f29a1dae Bug 2780 - Capitalize strings consistently (Staff client cart)
Correcting capitalization in the staff client's cart templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:24 +02:00
Owen Leonard addb9ed527 Bug 2780 - Capitalize strings consistently (Authorities pages)
Correcting capitalization in Authorities templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:23 +02:00
Owen Leonard f3a3d7a42d Bug 2780 - Capitalize strings consistently (Admin pages)
Correcting capitalization in Administration templates.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
2012-04-10 10:03:21 +02:00
Owen Leonard f87085e65e Bug 2733 - Can't print patron account
Changing "print page" link to "print summary." I hope this will
alleviate the suggstion that the option prints the current page.

- Changed "Quick slip" to "Print quick slip" to make it consistent
  with the other options in the menu

- Corrected the case of other text strings as required by
  Bug 2780.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 18:30:35 +02:00
Paul Poulain 2a6f09cdc8 Merge remote-tracking branch 'origin/new/bug_2780' 2012-04-06 18:28:07 +02:00
Owen Leonard 3a0b35cfbc Bug 2780 - Capitalize strings consistently (OPAC pages)
Correcting capitalization in OPAC templates

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passes tests, changes look consistent by reading through the patch.

What a doozy!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
2012-04-06 18:27:55 +02:00