Commit Graph

12985 Commits

Author SHA1 Message Date
Paul Poulain 7a072f6cb4 adding some copyright BibLibre statements
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d22001b1c4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:23:08 -05:00
Paul Poulain ef094f737d Bug 5726 : MT1059 Follow-up : Fix merge reference selection presentation
A change in global-staff.css messed the merge reference selection presentation

    Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3a29f37dff)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:21:50 -05:00
Paul Poulain 7943d9cc4a Bug 5718 : fix permission of moveitem = edit_items needed
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d251585f71)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:21:36 -05:00
Chris Cormack 101184107d Bug 2742 : Fix typo
(cherry picked from commit 403f53c0d8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:21:10 -05:00
Frédérick Capovilla 0745a40135 Bug 5616: Corrects an utf-8 encoding problem in cardviews
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 07731037ee)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:16:54 -05:00
Chris Nighswonger 14a2c4433d Updating Version Number to 3.02.03.002 2011-02-09 12:14:19 -05:00
Colin Campbell d354b3c32f Bug 2742 Correct language names in install
Correct native versions of Danish and Dutch

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1a06829f6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-09 12:12:15 -05:00
Chris Cormack 9ed4374971 Updating history docs
(cherry picked from commit 0060b10af9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:24:36 -05:00
Paul Poulain 853246b196 Bug 5700: MT4004 : additem.pl Some Status were not defaulted to the correct value Status 0 was lost because test was done on value and not on the fact that a value was defined or not. when value is 0 then it was not used as default value for
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 14422c8ed9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:19:01 -05:00
Paul Poulain 0c567653ae Bug 5699: don't discard $3 when building a record (UNIMARC specific)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60e0a76fc0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:18:46 -05:00
Chris Cormack de0a16e966 Bug 5691 - Delete all items respects independentbranches system preferences
Squashed commit of the following:

commit 66cdb8804136803a3f626d183c8f192f61f3c7b1
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:55:10 2011 +1300

    Bug 5691: Updating copyright statement

commit 79ef6c269afc9c644c51709a7657542a0fc6d7d6
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:52:13 2011 +1300

    Bug 5691 - Fixing a syntax error and tidying up some formatting

commit a66485dba113c05ed51a3b4ff19f788e335aa1f6
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Tue Oct 5 17:23:55 2010 +0200

    (MT #1365) Delete all items

    Using DelItemCheck in cataloguing/additem.pl
    when deleting all items

commit fe845fd48ab22ff82ad6d8971c468c327b49f3c4
Author: Christophe Croullebois <christophe.croullebois@biblibre.com>
Date:   Wed Sep 22 11:39:28 2010 +0200

    (MT #1365) Delete all items

    Now if IndependantBranches is on and a user try to delete all items, only the items of his branch will be deleted.
    A message explain this fact.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Followup: (MT #1365) Fixing up the English idiom
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a4cc394508)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:18:29 -05:00
Owen Leonard 2b43b47c5f Fix for Bug 5532 - sysprefs editor should show names of saved prefs
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7acfb3a17f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:18:11 -05:00
Owen Leonard 0a42fdd7f5 Fix for Bug 5689 - System preference notifications are not translatable
Defining strings in the template so that they can be translated.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aac253a5e0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:17:58 -05:00
Owen Leonard b158b4dac2 Fix for Bug 5115, Tags JavaScript includes many untranslatable strings
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dec6be9148)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:17:43 -05:00
Henri-Damien LAURENT 1e8ea0254e Bug 5690
MT3947: items.timestamp were not updated on edition

If items.timestamp is used in the framework and hidden
the fact that it is NOT deleted before update is done would input the previous timestamp,
which is not the desired behaviour.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60dd25b5c2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-07 18:17:22 -05:00
Chris Cormack 9facc26121 Fixing a syntax error, that snuck in with a merge
(cherry picked from commit e29aca325d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:03:46 -05:00
Owen Leonard 7f9eec6920 Fix for Bug 3319 - Need error message when adding patron and libraries are defined
- Hiding patron add toolbar when branches or categories are undefined
- Blocking patron entry form if branches or categories are undefined
- Removing nonfunctional template logic for displaying missing category
  error message.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e6a3029470)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:03:30 -05:00
Frédéric Demians 156a6bb1a0 Bug 3212 Force leader 9 position to 'a' for new biblios
When Creating a new biblio record, if the cataloguer doesn't use the leader
plugin, a biblio record can be saved with a leader not containing a 'a' in 9
position. If the biblio contains UTF-8 characters, its decoding can fail.

This issue applies to MARC-21 not UNIMARC.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f1f36a0c94)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:03:16 -05:00
Colin Campbell 619e788d4f Bug 5673: test guarantorid consistently
Incorrect checking of guarantorid was causing moremember.pl to
try and construct addresses using data from non-existent guarantors
ensure that test is consistently checking that value is defined and not
'', '0' or 0 [ i.e. what perl does for you anyway!!]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 49b5f77194)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:02:59 -05:00
Ian Walls f60ec1e18f Bug 2341: items marked 'on order' not reserveable from search results
Items created as part of the acquisitions process, and assigned the temporary notforloan value of -1,
cannot be placed on hold from the search results in either the OPAC or staff client (the link is missing).

This patch changes the evaluation of items->notforloan from a Boolean (if $items->{notforloan}) to a comparison
(if $items->{notforloan} > 0).  Any notforloan status with a negative value can therefore be reserved.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f692123bf1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:02:46 -05:00
Chris Cormack ddaf8ac147 Bug: 4263 - Repeatable subfields in items
Squashed commit of the following:

commit f441094d5095d165eab18340c983a831cce8f6e0
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Mon Jul 5 20:33:23 2010 +0200

    bug4263 followup : Can't blank subfields

    Previous bug4263 reintroduced bug 2466: fix clearing item field
    This keeps bug4263 followup to be assigned (donot blank dateaccessioned)
    But also allow to blank item subfields.

commit 92889b766c41b48bdd0e3a33ca4b183b1e259805
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Apr 23 13:54:30 2010 +0200

    (bug #4263) dateaccessionned is cleaned on item modification

    Every item modification, date accessionned is cleaned, if there is no modification made, we must'nt reset to "undef" the value.

commit 5abb2db16b2564d32e84b7cc680acbc301d73179
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Mar 2 09:57:33 2010 +0100

    (bug #4263) fix the edition of items with repeatable subfields

    The subfield management in item level is broken, fields are concatenated in one field, and if the librarian edit it, the values are not selected.
    This big patch fix three things:
     1) saving fields that are stocked in SQL(using koha2marc mapping) are now well cut and separated in _REAL_ subfields
     2) loading records with repeatable subfields are now well returned
     3) Editing items with repeatable fields works well

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Bug 4263 Removing extranious block of code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aa398ed055)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:02:05 -05:00
Chris Cormack d7e567302f Bug 4931: Stocking can be by homebranch or holding branch
Squashed commit of the following:

commit 105de81639cbac5084e4a5c099b19569043e69ff
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Jul 13 11:58:01 2010 +0200

    (bug #4931) fix forgottens input in buttons

    the previous patch missed an hidden input in next buttons that break next page. This fix it.

commit db00295a6b9d1d36fc888ba6a0558011fd6884ba
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Jul 2 15:27:59 2010 +0200

    (bug #4931) add the ability to choose home or holding branch in stocktaking

    This add radio box in stocktaking to base it on home or holdingbranch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>

Bug 4391 Followup: Adding back lost declaration of $branchcode
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35b47b6ff7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-03 08:01:48 -05:00
Chris Cormack 1e97507fc1 Updating history docs
(cherry picked from commit c269dfdeb4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-02 17:10:40 -05:00
Frédérick Capovilla f9cbf98a01 Bug 5661 Fix a problem when doing an authority search with no sort order
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 079796ed18)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-02 17:10:24 -05:00
Paul Poulain 9746035a75 Bug 5681: Fixes leading zeroes in Add Mulpiple Copies
From Biblibre:
I don't know why, but removing sprintf solves the problems with leading zeroes
and the problems with large values.

(written by jean-andré santoni)

Note from Chris:

The width is never set, so the sprintf always defaults to a float, which
trims the leading zeros. I am not smart enough to figure out how to set
a valid width when calling it, and removing the sprintf seems to work
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 for
test results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4f7bcdcbae)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-02 17:10:05 -05:00
Jared Camins-Esakov 2db0ea15f7 Bug 5683 - it is possible to save corrupt records
This patch makes it impossible to save records with variables fields that don't
contain any subfields. Prior to this patch, link_bibs_to_authorities.pl would
sometimes corrupt records.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 428556cd13)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-02 17:08:50 -05:00
Chris Nighswonger 5ab83557b5 Updating Version Number to 3.02.03.001
Updating Version Number to 3.02.03.001
2011-02-01 15:08:23 -05:00
Katrin Fischer 050b55f2ab Bug 4160: Currency conversion doesn't handle rates other than 100
Changes data type for currency.rate to accomodate bigger currency conversion rates.

FLOAT( 15, 5 )

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-01 15:07:32 -05:00
Reed Wade 2e611e5666 Bug 5665: Routing slip prints too wide for narrow printers
This patch switches off some min-width styling which causes right hand
of page to be clipped.

Work sponsored by Opus

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 241fa939b4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-02-01 14:49:38 -05:00
Chris Cormack e4b68e97fd Bug 5452 - Overdue date color in borrower's today issues
Patch sent by Fridolyn SOMERS, but not in git format
(cherry picked from commit 1c461680c8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-29 19:58:20 -05:00
Schuster bfcb2fff45 BUG 5649: Change wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page
Changes the wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 460a7b566b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-29 19:57:53 -05:00
Robin Sheat da11b6d986 Bug 5477 [SIGN-OFF] Fix test cases that require database access
This moves the DB-requiring tests out of the way, with the exception of
00-load.t which is used by the git hooks. For it, it makes it skip
loading problematic modules. This allows 'make test' to complete successfully
without a database configured, wich is a required part of making packages.

This has been tested against the v3.02.03 tag and the master branch.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9df2a4a8fc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-29 19:57:31 -05:00
Ian Walls cc3ba2c1ab Bug 5376: Batch Mod and Delete require superlibrarian permissions
This only occurs with IndependantBranches turned on; in an attempt to check that the items being
modified belonged to the user's branch, the code made a simultaneous comparison and assignment,
which is not permitted in all compilations of Perl.

Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 12c116236f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-29 19:57:12 -05:00
Frédéric Demians 07ba717450 Translation updates
- Two new languages:

  . sd-PK - Sindhi
  . is-IS - Icelandic

- Fix a naming error for nb-NO and nn-NO
(cherry picked from commit 671419dcce781aa01f300012f0f425c040749f73)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-27 07:36:50 -05:00
Galen Charlton de6a027bbf bug 5654: remove disused directory
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 34ba87625a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-26 17:36:01 -05:00
Chris Cormack 2c9721b8de Adding Jerome Charaoui to the history docs, 130 people have code in Koha now
(cherry picked from commit 7f4771588e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-26 17:35:39 -05:00
Chris Cormack 9638c4423a History updated
(cherry picked from commit 7d87094fc8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-26 17:35:23 -05:00
Jerome Charaoui 07c44ab9a8 Bug 5506 Fix installation of prefs translations in standard installs
[3.2] Should be applied

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1fc16ea543)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-26 17:35:09 -05:00
Chris Nighswonger 571957ae1a Updating Version Number to 3.02.03.000 2011-01-22 17:25:28 -05:00
Chris Nighswonger 07e66bb263 Release Notes for 3.02.03.000 2011-01-22 17:23:16 -05:00
Chris Cormack 649fd4952d Bug 5327 fixing missing number of tests
(cherry picked from commit d64008644a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:45 -05:00
Zach Sim ab3263e018 Added more unit tests to check when JSONStream should fail.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5f0f2e297a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:45 -05:00
Zach Sim 928165875c Bug 5327: Added unit tests to Output_JSONStream.t
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 434d9a3c66)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:45 -05:00
Chris Cormack bc1620b3d6 Bug 5327: small typo in the Members.t test
(cherry picked from commit 1c89ce34b9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:44 -05:00
johnboy 6bf8c7ae67 Bug 5327 Made test file for Accounts.pm
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 669280c7ab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:44 -05:00
Chris Cormack e4540c647e Bug 5327: Shifting and little tidy up of the members tests
(cherry picked from commit 314772637c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:44 -05:00
johnboy a22b4f3046 Bug 5327 Some tests added
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d567945517)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:44 -05:00
Chris Cormack f7a22b7a1b Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
(cherry picked from commit e03026adff)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:44 -05:00
Zach Sim 60b5c614a7 Added unit tests to test all of get_amazon_tld in Amazon.pm.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b56121db02)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:43 -05:00
Chris Cormack c6d6955761 Bug 5327: Little change to Record.t
(cherry picked from commit 23f92a8f8d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-01-20 17:59:43 -05:00