Commit Graph

57048 Commits

Author SHA1 Message Date
Emily Lamancusa 6dee4899d6
Bug 39185: Don't add select option if priority is 0
To test:
1. Place several holds on a biblio record
2. Check in items from that record and confirm some (but not all) of the
    holds
3. View the current holds on that record
4. Click on the drop-down to change the priority of a hold
--> Note that the drop-down contains one or more "0" options - one for
    each in-transit or waiting hold
5. Apply patch and refresh the page
6. Click on the drop-down again
--> The drop-down now contains the correct options
7. Use the drop-down and the "Update holds" button to change hold
    hold priorities a few times
--> Confirm that the priority is updated correctly

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:32 +01:00
Marcel de Rooy 56fd9a7c7d
Bug 30888: (QA follow-up) Correct dbrev 24.12.00.012
Also adds empty string as default value for deletedauth_header.marcxml
in TestBuilder.

Test plan:
Run dbrev.
Run t/db_dependent/TestBuilder.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 17:32:31 +01:00
Tomas Cohen Arazi a07368e5ce
Bug 36433: (follow-up) Include required library
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-27 13:55:16 +01:00
Lisette Scheer a524d94abb
Bug 37989: Add template toolkit to problem_report notice
This patch adds the ability to use template toolkit in the PROBLEM_REPORT notice

Test plan:
1. Turn on OPACReportProblem in the system preferences.
2. In the staff interface, create the following report:
  SELECT * FROM message_queue WHERE letter_id='PROBLEM_REPORT'
3. Log into the OPAC
4. Edit the PROBLEM_REPORT notice to include [% problemreport.username %] after the bespoke syntax for the username.
5. Report a problem
6. Run the report you created.
7. Observe the data. (Bug 37991, the title doesn't store properly)
8. Apply the patch
9. Restart all services (restart_all on command line Restart Services in sandbox options)
10. File a new OPAC problem report
11. Run your report. 2 usernames should now show.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:45:47 +01:00
Lucas Gass 75f3abd342
Bug 38670: Add 773$d to MARC21 record detail display for OPAC
Signed-off-by: esther <esther@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:45:47 +01:00
Lucas Gass dd21ba5d5d
Bug 38670: Add 773$d to MARC21 record detail display
To recreate:
1. Pick a framework and expose the 773$t ( title ), 773$g ( parts ), and 773$d ( Place, publisher, and date of publication )
2. Find a record and add some data to each of the fields in step 1.
3. Notice that the 773$d won't display.
4. APPLY PATCH and restart_all
5. Now the 773$d displays.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:45:46 +01:00
Johanna Räisä ec43f339d3
Bug 38253: (follow-up) add missing swagger definition
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:31 +01:00
Johanna Räisä 2071aae29f
Bug 38253: Add lowest priority REST API endpoint for holds
This patch adds a new endpoint to toggle the lowest priority of a hold via the REST API.

To test:
1) Apply the patch
2) perl build-resources.PL
3) prove t/db_dependent/api/v1/holds.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:31 +01:00
Katrin Fischer 94fdb27695
Bug 39200: (follow-up) Move intranet_includes in sysprefs.sql
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:30 +01:00
Emily Lamancusa 00fb10aaea
Bug 39200: Fix syspref order
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:30 +01:00
William Lavoie 20587212a3
Bug 39035: Adding print media query to hide cookie permissions
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:29 +01:00
Nick Clemens 70cb30ee6e
Bug 39186: Update styling of Cancel marked holds button
This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:28 +01:00
Katrin Fischer 707d3b3563
Bug 38108: (follow-up) Amend system preference description with "staff interface"
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:28 +01:00
Katrin Fischer 6b756e25cd
Bug 39200: DBRev 24.12.00.014
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:27 +01:00
Emily Lamancusa 606cd8d63e
Bug 38108: (QA follow-up) Use say_success in dbrev
Use say_success instead of say when outputting a line that the
system preference was added successfully

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:27 +01:00
Lucas Gass 04f398890e
Bug 38108: Add ability to show/hide table filters via system preference
To test:
1. APPLY PATCH, updatedatabase, restart_all
2. Search for the 'AlwaysShowHoldingsTableFilters' system preference. It should be set to 'Don't'.
3. Without changing the system preference, go to a record detail page.
4. The filters should not show by default.
5. Make sure that toggling the Hide filters/Show filters button still work as expected.
6. Set 'AlwaysShowHoldingsTableFilters' to 'Do'.
7. Now the filters should show by default when you load the table.
8. Make sure that toggling the Hide filters/Show filters button still work as expected.

Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:26 +01:00
Lucas Gass 9a55785c8b
Bug 38108: Add system preference AlwaysShowHoldingsTableFilters
Signed-off-by: Rebecca Coert <rcoert@arlingtonva.us>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:26 +01:00
Nick Clemens 177d648ded
Bug 39108: Prevent 'Ignore' on found hold from triggering a new modal
When ignoring a waiting hold, we don't need to take any further action, we
shoudlsimply close the modal

This patch adds JS to prevent form submission

To test:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
10 - Apply patch
11 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
12 - check in the item again, confirm the modal says "Item is already waiting"
13 - click Ignore, nothign happens! Orange you glad I didn't say banana?

Signed-off-by: Amanda Campbell <acampbell@hmcpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:25 +01:00
Martin Renvoize 9fdc303af4
Bug 38689: (follow-up) Add koha_object(s)_class defintions
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:25 +01:00
Frédéric Demians 8a8b41c344
Bug 36433: fix test failing on Jenkins
Transaction rollback not called.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-26 13:16:24 +01:00
Caroline Cyr La Rose 49c881c54a
Bug 36109: Typo corrections
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 18:30:17 +01:00
Martin Renvoize e1931dc168
Bug 36109: Convert sample ODUE notice to TT
This is an initial submission to convert the existing <<>> sample notice
to TT.

We could do more here, like including the due date and making the fines
display more clearly optional.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 18:30:16 +01:00
Katrin Fischer 14948638a1
Bug 26553: (follow-up) Fix translatability for strings in datatables.js
Updated single to double underscores in a few places.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:30:01 +01:00
Jonathan Druart cc09868152
Bug 26553: Split Export and restore "clear filters" - OPAC
"Clear filters" is not in main but should be (I don't really understand
why it is not displayed).

The Export options were not grouped within an "Export" button in main,
this patch restores that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:30:01 +01:00
Owen Leonard 6af26866e8
Bug 26553: (follow-up) Fix pending patron discharges
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:30:00 +01:00
Owen Leonard b0571aa1d3
Bug 26553: (follow-up) Fix patron attribute types page
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:30:00 +01:00
Jonathan Druart 5e398c50d8
Bug 26553: Restore default 'paging: false' - OPAC
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:59 +01:00
Jonathan Druart 445f09083e
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:59 +01:00
Jonathan Druart 7d0c0dc93e
Bug 26553: Bring default columnDefs back
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:58 +01:00
Jonathan Druart c8538203b7
Bug 26553: Replace KohaTable with kohaTable - curbside pickups
Adjust this new occurrence

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:58 +01:00
Jonathan Druart 1570b37352
Bug 26553: Remove columns_settings.inc - OPAC
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:57 +01:00
Jonathan Druart dfe23695b3
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:57 +01:00
Jonathan Druart 948366a509
Bug 26553: Replace KohaTable with kohaTable - OPAC
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:56 +01:00
Jonathan Druart 25b3fd015b
Bug 26553: Remove columns_settings.inc
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:56 +01:00
Jonathan Druart 2dc4288fe5
Bug 26553: Remove useless INCLUDE of columns_settings.inc - Staff
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:55 +01:00
Jonathan Druart 54e744d5ec
Bug 26553: Replace KohaTable with kohaTable
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

JD Amended patch: replace wrong occurrences of "kohatable" with "kohaTable"

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:54 +01:00
Jonathan Druart 8ff56432d1
Bug 38255: Fix additional-contents
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:54 +01:00
Jonathan Druart 98cddadda8
Bug 38255: Fix Cash registers
This patch fixes the following error:
 Uncaught TypeError: table.column is not a function

We needed to pass table.DataTable() to filterDataTable
I've decided to clean the code as it does not make sense to me:
filterDataTable is called from a single place, and clearFilter is not
needed (we should not interfer with the 'Clear filter' button here)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:53 +01:00
Jonathan Druart 64267981b9
Bug 38255: (follow-up) Replace dataTable constructor with kohaTable - Staff
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:53 +01:00
Jonathan Druart a5dbbf6dc7
Bug 38255: Exception - Item search
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:52 +01:00
Jonathan Druart 3bce221d51
Bug 38255: Allow instantiation without parameters
`$(node).kohaTable()` should work.

Without this patch we got `Uncaught TypeError: settings is null`

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:52 +01:00
Jonathan Druart d77ff41c3d
Bug 38255: Exception - Manage staged MARC records
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:51 +01:00
Jonathan Druart 27a132e199
Bug 38255: Fix JS error
Uncaught SyntaxError: redeclaration of let

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:51 +01:00
Jonathan Druart 9cc5e0f77c
Bug 38255: Exceptions
Those tables are using a svc script, not the REST API. It is not compatible
with kohaTable's default 'ajax' options.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:50 +01:00
Jonathan Druart 45f7b10541
Bug 38255: Early return if the node does not exist
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:50 +01:00
Jonathan Druart 8f8ad6a432
Bug 38255: Add kohaTable - OPAC
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:49 +01:00
Jonathan Druart f99fc3a44f
Bug 38255: Replace dataTable constructor with kohaTable - OPAC
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:49 +01:00
Jonathan Druart e9b8004d19
Bug 38255: Replace dataTable constructor with kohaTable - Staff
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-24 14:29:48 +01:00
Lari Taskula b4662eb60a
Bug 32440: Support purging statistics by type in cleanup_database.pl
Cleanup_database can delete all statistics entries more than X days
old. If one is using pseudonymization to create pseudonymized_transactions
data, then one may wish to use that cleanup_database function to delete
statistics entries that have been duplicated in pseudonymized_transactions.
However, not all types of transactions in statistics are duplicated in
pseudonymized transactions.

Pseudonymized_transactions currently only includes checkouts, returns,
and renewals.

This patch adds two additional parameters to cleanup_database.pl:

  1. --statistics-type

  Defines the types of statistics to purge. Will purge all types if
  parameter is omitted. Repeatable.

  2. --statistics-type-pseudo

  Grabs values from @Koha::Statistic::pseudonymization_types. At the
  time of writing this patch, they are:

  renew, issue, return and onsite_checkout

To test:
1. prove t/db_dependent/Koha/Statistic.t
2. Before applying this patch:
3. Create some statistics entry by checking out, renewing and checking in
   items.
4. perl misc/cronjobs/cleanup_database.pl --statistics 1 --verbose

Observe:
Purging statistics older than 1 days
n statistics would have been removed

Where n is the amount of statistics rows matching your test environment

5. Apply patch
6. Repeat step 4, observe same result
7. perl misc/cronjobs/cleanup_database.pl --statistics 1 --statistics-type-pseudo --verbose

Observe:

Purging statistics older than 1 days with types "onsite_checkout,renew,return,issue".
n statistics would have been removed

Where n is the amount of statistics rows matching your test environment
(order of listed types does not matter)

8. perl misc/cronjobs/cleanup_database.pl --statistics 1 --statistics-type test1 --statistics-type test2 --verbose

Observe:

Purging statistics older than 1 days with types "test1,test2".
n statistics would have been removed

Where n is the amount of statistics rows matching your test environment
(order of listed types does not matter)

9. perl misc/cronjobs/cleanup_database.pl --statistics 1 --statistics-type-pseudo --statistics-type test1 --verbose

Observe:

Purging statistics older than 1 days with types "test1,onsite_checkout,renew,return,issue".
n statistics would have been removed

Where n is the amount of statistics rows matching your test environment
(order of listed types does not matter)

10. Try previous cleanup_database.pl commands with --confirm flag and make sure correct rows are purged

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 16:41:29 +01:00
Lari Taskula e2221f5b04
Bug 32440: Add missing unit test for Koha::Statistic->pseudonymize()
To test:
1. prove t/db_dependent/Koha/Statistic.t

Observe

Subtest: pseudonymize() tests
    1..6
    ok 1 - some pseudonymization_types are defined
    ok 2 - Background job enqueued for type renew
    ok 3 - Background job enqueued for type issue
    ok 4 - Background job enqueued for type return
    ok 5 - Background job enqueued for type onsite_checkout
    ok 6 - Background job not enqueued for type not_gonna_pseudo
ok 2 - pseudonymize() tests

Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2025-02-21 16:41:29 +01:00