Commit Graph

9160 Commits

Author SHA1 Message Date
Henri-Damien LAURENT 620ead4445 Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Adapted for 3.0 : Henri-Damien LAURENT
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:11:42 +01:00
Joe Atzberger (siptest 7822223b72 Bugs 2541 and 2587 - AddIssue must return date object as intended.
SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:11:30 +01:00
Henri-Damien LAURENT 91d174462f [REPLACE previous] Removing map calls in void context
Thanks Joe.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:11:21 +01:00
Henri-Damien LAURENT a98226b64b Update MARC to add 099$c and 099$d fields, with :
This allow the acquisition date sorting in UNIMARC.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:11:12 +01:00
Henri-Damien LAURENT eb9fb8587c Updating default UNIMARC framework
The previous one was out of date and contained some errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:50 +01:00
Joe Atzberger 8cf20eb41b Bug 2801 and other cleanup.
In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:41 +01:00
Galen Charlton 07c2a7ba35 bug 2531 followup
* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:33 +01:00
Allen Reinmeyer af7c33b328 Bug #2531 Cannot delete private shelf
Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:23 +01:00
Ryan Higgins d082c0b19b Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:15 +01:00
Henri-Damien LAURENT 25ea703e30 problem saving authority with ? and other special characters [resend]
Filtering those signs in order not to have them interpreted.
Removing some warns

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:10:04 +01:00
Henri-Damien LAURENT cb2b141f8d Improving UNIMARC(A) compliance
Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:55 +01:00
Michael Hafen 29cfced581 Use biblioitems.itemtype as a default for items.itype
This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:47 +01:00
Jesse Weaver e6dc1ba7f8 fix for bug 2447: yuipath variable not getting passed to help pages
This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:39 +01:00
Frédéric DEMIANS 14c55e06aa Get back boolean button on OPAC Advanced Search page
With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:29 +01:00
Henri-Damien LAURENT b54363c13a bug fix 2765
Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:20 +01:00
Henri-Damien LAURENT 067ebee987 Bug 2790 no UNIMARC search on avail items [1/2]
Changing record.abs file to add the management of acquisition date,
modification date and lost

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:12 +01:00
Henri-Damien LAURENT 1f2232bb68 Bug Fix : 2494
Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:09:04 +01:00
Henri-Damien LAURENT 48d5b8dc01 Merging authorities caused an encoding problem in biblios
MARC::File::USMARC::decode is not aware of encoding as MARC::File::XML is
So it caused a problem when decoding information and updating biblios.
Now uses MARC::File::XML
Encoding is OK

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:08:54 +01:00
Henri-Damien LAURENT 30c8919dba Bug Fixing : export would export no biblios when
IndependantBranches set and user is kohaadmin
I think we can escape defaulting to the userenv Branch with
restricting the list to the user branch

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:08:45 +01:00
Henri-Damien LAURENT 6bad5bfc58 Bug Fix : 2686
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:08:17 +01:00
Henri-Damien LAURENT ad109791b9 Adding some Error proof on GetAuthority
return undef if there is a problem

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:08:08 +01:00
Henri-Damien LAURENT fc02ce517b merge_authority : Bug fixing
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:59 +01:00
Henri-Damien LAURENT 3747a599f9 Bug Fix : Adding Some error proofs to HaveSubscriptionExpired
Date::Calc::CalcDays was throwing error 500 when one serial had an undefined date.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:50 +01:00
Henri-Damien LAURENT ebe04d8446 Bug Fix : When Patron had overdues, it was possible to checkout
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:40 +01:00
Henri-Damien LAURENT 90143bd46b Using Warns would cause problems with NoZebra
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:30 +01:00
Henri-Damien LAURENT 57f53d05d5 Adding some fixing for NoZebra
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:21 +01:00
Henri-Damien LAURENT 8d82c2cd6b Minor Feature : username when cataloguing
biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:12 +01:00
Henri-Damien LAURENT 8cd4d221d8 Bug Fixing : searching on mainmainentry was disabled
Adding Heading-Main as new index code in order to search only on Heading-main when $a selected.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:07:03 +01:00
Henri-Damien LAURENT 1da977684c Restoring startsby search on authorities.
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:06:29 +01:00
Henri-Damien LAURENT fd0b82b613 creating update database for 3.0.1
- adds 2 new sys prefs AllowRenewalOverride and MergeAuthoritiesOnupdate AllowRenewallOverride
MergeAuthoritiesOnUpdate
- set null issues.issuedate to lastreneweddate
- Adding some changes in Database for bugfixes only UNIMARC

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 18:03:15 +01:00
Henri-Damien LAURENT 88a86c7aef Using Warns would cause problems with NoZebra
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 17:56:37 +01:00
Henri-Damien LAURENT 8d29c78cbb Bug Fix : 2494
Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2008-11-24 17:55:03 +01:00
Galen Charlton 93c98eec37 bug 2802 followup: remove another reference to "branches"
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 05:35:35 +01:00
Henri-Damien LAURENT fd59d25aad bug fix : 2805
deleting die on lack of user/password in config file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 05:35:26 +01:00
Owen Leonard ba9927f2cc Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 05:35:18 +01:00
Michael Hafen 2b50aebf6d add isbn to cataloging search results
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-19 05:34:59 +01:00
Nahuel Angelinetti 986f90f74b Do not show the language chooser
This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:01:06 +01:00
Galen Charlton 9d2449f9f3 moved Test_CSV_Various.t to xt/author
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:01:02 +01:00
Joe Atzberger e0d2d99cf1 Results of CSV module analysis, testing various CSV modules and configs.
The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode.  Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:00:58 +01:00
Marc Chantreux 9e5187e31c use DESTDIR now
takes carre of changes in Makefile.PL about debian install

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:00:53 +01:00
Frederic Demians 485cc141da Fixes bug #2788 - CoinS support
1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:00:47 +01:00
Frederic Demians b360534fc0 Bug #2794: Browse Shelf doesn't work with ISBN containing '-'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:00:44 +01:00
Henri-Damien LAURENT 8864471c4d adding "DROP TABLE" commands to several table definitions in kohastructure.sql
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 18:00:06 +01:00
Galen Charlton 20f0e908dc bug 1891 followup - remove dangling /TMPL_IF
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 17:52:15 +01:00
Ryan Higgins b65dbbf98d bug 1891 : bib-level itemtype was required in order to place a hold.
This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 17:51:56 +01:00
Galen Charlton 7c1bc8abc4 fix POD error
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 17:51:11 +01:00
Andrew Moore dc73ef953b Bug 2775: adding method to clean syspref cache in C4::Context
C4::Installer provides a way to update the kohaversion syspref. Now that
C4::Context caches syspref values, any updated value through C4::Installer
is not being seen.

This patch adds a method to C4::Context to allow you to clean that
cache. Then, it calls that method when the kohaversion syspref is changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-17 17:50:50 +01:00
Chris Cormack 73c23ec91a Updated Italian translation files
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 17:11:32 +01:00
Owen Leonard 711c9b91a0 Removing some unused stuff from print stylesheet, hiding Koha logo from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 17:11:30 +01:00
Nahuel Angelinetti 685f284606 Fix overdue list if you do not specify a branchcode.
Before, if you do not provide a "branchcode" you have an empty csv export.
Now, if you have an empty branchcode you have all overdues listed in csv.
(I made a typo error in code)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
2008-11-12 17:11:22 +01:00