Commit Graph

1877 Commits

Author SHA1 Message Date
Andrew Moore 5285bb04fe bug: 1953. using placeholders in C4::Acquisition::NewOrder.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:18 -05:00
Andrew Moore a610782e6c bug 1953: using placeholders in C4::Acquisition::GetParcel
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:17 -05:00
Andrew Moore 9cf2a4b730 bug 1953: using placeholders in C4::Acquisition::GetParcel
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:16 -05:00
Owen Leonard b853eed5f4 Some reworking of suggestions management interface in preparation for tackling hdl's proposal of wider scope. Includes change to Suggestions.pm to enable passing of borrowernumber to the template.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:15 -05:00
Henri-Damien LAURENT 097e8f1c52 bug fix : 1804 : Now empty authorities and empty search return results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:14 -05:00
Henri-Damien LAURENT 2007ce3a25 Some Bugfixing for Acquisitions : ModOrderReceive would create 2 lines in baskets And titles were displayed twice in parcel.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:11 -05:00
Joshua Ferraro 9d0fdfab5a don't show library facet if singleBranchMode is ON
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:40:57 -05:00
Andrew Moore 761656570b bug 1953: use bind variables in C4::Acquisition::GetPendingOrders
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:24 -05:00
Andrew Moore a5325c4fcc use bind variables in C4::Acquisition::GetPendingOrders
I improved the tests a bit for this module so that they at least skip
if there's not enough data in the database to test with.
I was unable to test the actual execution path through the change I actually made.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:23 -05:00
Owen Leonard 7ec49e693a Fix to enable OPACUserCSS preference (allows user to add CSS globally in the OPAC via an embedded style block)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:21 -05:00
Owen Leonard a4e22029cc Updates to tweak the way suggestions and suggestions links display when various suggestions-related prefs are on or off.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:16 -05:00
Chris Nighswonger 73dde7a03a Correcting warn concerning kohaversion.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:44:44 -05:00
Galen Charlton e4ea107c9b use bind variables in GetBorrowersWhoHaveNotBorrowedSince query
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:56 -05:00
Henri-Damien LAURENT 48856684f3 Assigning bug 1835 : change password would never log password change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:44 -05:00
Henri-Damien LAURENT 5904681fac CleanBorrowers fixing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:40 -05:00
Galen Charlton afb36c429e refactor C4::Log::logaction
This fix should resolve in whole or in part several bugs
characterized by the error message 'Can't use string ("0")
as a HASH ref while "strict refs" in use', including
bugs 1101, 1899, and 1910.

There are some possibilities for future work:

[1] Dealing with an operator override, e.g., where
    a circ operator needs to get a supervisor
    to enter a login and password and escalate
    the original operator's privileges for a
    transaction, e.g., to forgive a fine.  This
    is an enhancement, of course.
[2] Creating a dummy operator to represent
    batch job runs; or alternatively, give
    each batch job an option to log its work
    under a specified user ID.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 06:34:10 -05:00
Owen Leonard 80de0e0692 Fix for Bug 1951, OPACURLOpenInNewWindow doesn't do anything.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:45 -05:00
Chris Nighswonger f41109ee8e Bugfix to correct date format in query used in GetLogs()
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:09:57 -05:00
Chris Nighswonger 35df86da59 Correcting Logging on ModMember function so that the query is logged in the 'info' field.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:09:55 -05:00
Joshua Ferraro 492474cf36 don't include the item itself as an edition
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 10:40:30 -05:00
Joshua Ferraro 9b1d024b4c adding a <meta> field to make Koha's OPAC discoverable
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 10:40:17 -05:00
Andrew Moore a59c28db3e fixing bug 1801
adding some parameters to the call to opac-auth.tmpl in C4::Auth::checkauth
This displays the additional navigational links in the masthead on the login page to unauthenticated users.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 09:44:43 -05:00
Joshua Ferraro a7dbbe7697 fixes bug 1924: Language selection lists English only and that several times.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 00:10:48 -05:00
Joshua Ferraro db101d35d0 fix for bug 1781 for NOZebra=OFF
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 22:35:19 -05:00
Joshua Ferraro ed39d5bee4 remove warnings from Languages.pm
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:48:05 -05:00
Ryan Higgins 46826aaee0 Mod C4::Labels::add_batch to accept an array of items.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:32:31 -05:00
Ryan Higgins 760ce0b18c Partial commit to add Create-Label-Batch-from-Import-Batch
Import batch portion herein. Still need to touch Labels.pm .

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:32:30 -05:00
Joshua Ferraro 2b28689ae8 fixing bug 1754: Hide language chooser if only one translation is available
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 21:28:31 -05:00
Chris Nighswonger 90a8f310f3 Third installment Patron card generation feature
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 20:43:05 -05:00
Chris Nighswonger a988d199a2 First installment: Patron card generation feature
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 20:43:03 -05:00
Joshua Ferraro 9fcc38d441 fixing display of itemtypes and itemtype icons in virtual shelves
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 20:12:38 -05:00
Owen Leonard 8a01737202 Fix for Bug 1939, OpacMainUserBlock not displaying with news.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-17 16:28:57 -05:00
Joshua Ferraro f51890c407 Adding experimental OPACShelfBrowser feature -- to try, create a new syspref called OPACShelfBrowser, and set it to 1
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 20:26:30 -05:00
Joshua Ferraro 4c92790fc0 IMPORTANT: Upgrading to Amazon.com Associates Web Service 4.0
As announced this past February, Amazon.com will no longer be
accepting web services requests to Amazon E-Commerce Service
(Amazon ECS) version 3.0 beginning on March 31, 2008.

This patch upgrades to Amazon.com's Associates Web Service 4.0
for the following components:

1. Amazon.com Locale support for: Canada, Germany, France, Japan,
   UK, and US (see the new syspref called AmazonLocale)
2. Jacket Covers
3. Editorial Reviews
4. Customer Reviews
5. Amazon.com Similar Items

The following changes MUST be made to continue using Amazon.com
content:

1. Delete the system preference: AmazonDevKey (AmazonDevKeys used
   with AmazonECS 3.0 are no longer valid)
2. Add the system preferences: AmazonLocale, AWSAccessKeyID
   NOTE: steps 1, 2 are done by the web installer
3. Verify your AWSAccessKeyID:
   You may already have an Access Key ID. You can access your Access
   Key ID by going to http://aws.amazon.com, pointing to Your Web
   Services Account, then clicking View Access Key Identifiers.
   Depending on when you signed up for ECS 3.0, you may need to
   re-register for an AWS account, which includes an Access Key ID.
4. Enter your AWSAccessKeyID in the Koha syspref called
AWSAccessKeyID

For complete details on the changes in Amazon.com Associates Web
Service 4.0, and the migration process, please see: http://tinyurl.com/ysorqy

Other changes with this patch:
 * added $tabsysprefs{PatronsPerPage}="Patrons";
 * Moved OPAC Features to OPAC in sysprefs
 * removed experimental OPACXISBNAmazonSimilarItems and XISBNAmazonSimilarItems features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 12:27:55 -05:00
Joe Atzberger 45c007cc1e Search.pm - minor cleanup
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 08:40:39 -05:00
Joe Atzberger 600b47b08f C4::Search - vastly reduced calls to preference and repeatedly stepping through the same hashrefs to build keys
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 08:39:19 -05:00
Joe Atzberger 2626edb41e C4::Debug - should resolve conflict w/ CGI upload. Debug no longer uses CGI.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-16 08:32:20 -05:00
Galen Charlton 087f31062d fix initiation of transfer on return of non-issued item
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:20 -05:00
Galen Charlton 6e01d8ca9f fix crash when levying a rental charge
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:11 -05:00
Galen Charlton 3102fab410 check on max renewals now respects item-level item types
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:37:08 -05:00
Galen Charlton 0c156b1ef3 removed warns
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:40 -05:00
Galen Charlton 9222f7a6ca created old_issues and old_reserves tables
The new tables have the same structure and constraints
as the tables they archive with the following exceptions:

* borrowernumber and biblionumber in old_reserves can be
  NULL
* the FK constraints (e.g., for itemnumber) on old_reserves
  set the child column to NULL if the parent row is deleted
  instead of deleting the child row.
* there is no FK constraint on old_issues.branchcode, allowing
  a branch to be deleted without changing archived requests.

Some miscellaneous cleanup was done as part of this patch:

* GetMemberIssuesAndFines (C4::Members) now uses bind variables
* fixed POD for GetMemberIssuesAndFines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-15 08:36:31 -05:00
Chris Nighswonger 100e95484f Further adjustments on recent label improvments
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-11 06:16:58 -05:00
Ryan Higgins bd8f90387b Add Local-use statistical patron category_type
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-10 05:27:37 -05:00
Chris Nighswonger 11a213a82f Bumping DB to 061 - Adding the ability to choose font type to the Label tool.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:34 -06:00
Joe Atzberger 7e28158855 acqui/addorder.pl - use reliable GetBookSellerFromId instead of relying on name search.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-08 11:19:27 -06:00
Chris Nighswonger 55b353f79a Adding Update/Delete functions to patron image management on Details page
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-06 12:14:44 -06:00
Joshua Ferraro 8e156e4312 fixing a typo s/tab/tag/
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-05 00:02:28 -06:00
Joshua Ferraro c2e65e06c6 fix for warning in logs: Argument "\x{61}" isn't numeric in numeric eq (==) at /home/jmf/kohaclone/C4/Biblio.pm line 1008.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-05 00:02:11 -06:00
Galen Charlton 34ce43c8ba removed compile-time dep on a valid $dbh from C4::Dates
This replaces using the package variable $prefformat directly, and
specifically, doing a call to C4::Context->preference() during
module initialization.  That way, C4::Dates no longer has a
compile-time dependency on having a valid $dbh.

The inspiration for this is making it easier for
zebraqueue_daemon to have code that detects when
the database connection goes down and then try to
reconnect to the DB.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-04 22:25:04 -06:00