Commit Graph

7700 Commits

Author SHA1 Message Date
Andrew Moore 5285bb04fe bug: 1953. using placeholders in C4::Acquisition::NewOrder.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:18 -05:00
Andrew Moore a610782e6c bug 1953: using placeholders in C4::Acquisition::GetParcel
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:17 -05:00
Andrew Moore 9cf2a4b730 bug 1953: using placeholders in C4::Acquisition::GetParcel
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:16 -05:00
Owen Leonard b853eed5f4 Some reworking of suggestions management interface in preparation for tackling hdl's proposal of wider scope. Includes change to Suggestions.pm to enable passing of borrowernumber to the template.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:15 -05:00
Henri-Damien LAURENT 097e8f1c52 bug fix : 1804 : Now empty authorities and empty search return results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:14 -05:00
Henri-Damien LAURENT 6fc80555d1 Bug fixing : 1746 : password was not escaped.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:12 -05:00
Henri-Damien LAURENT 2007ce3a25 Some Bugfixing for Acquisitions : ModOrderReceive would create 2 lines in baskets And titles were displayed twice in parcel.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:11 -05:00
Henri-Damien LAURENT c6a268a343 bug fixing : when closing a basket, supplier was searched by name, not by id.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-21 21:45:10 -05:00
Joshua Ferraro 5f9c9c0f86 don't display the name of the library in singleBranchMode
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 09:14:01 -05:00
Joshua Ferraro 0eb7388f98 fixing singlebranchmode display issues
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 09:01:07 -05:00
Joshua Ferraro 56a2dddc77 adding OPACShelfbrowse to OPAC tab
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:41:25 -05:00
Joshua Ferraro 90bff5e0ac fixing availability limit
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:41:17 -05:00
Joshua Ferraro f85bb6d49a adding title indexes for 780
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:41:08 -05:00
Joshua Ferraro 9d0fdfab5a don't show library facet if singleBranchMode is ON
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:40:57 -05:00
Joshua Ferraro d4bde52e7a Adding a couple benchmark scripts
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:40:48 -05:00
Joshua Ferraro 8f4224c46f obey opaclanguagesdisplay syspref
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-20 08:40:36 -05:00
Andrew Moore 761656570b bug 1953: use bind variables in C4::Acquisition::GetPendingOrders
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:24 -05:00
Andrew Moore a5325c4fcc use bind variables in C4::Acquisition::GetPendingOrders
I improved the tests a bit for this module so that they at least skip
if there's not enough data in the database to test with.
I was unable to test the actual execution path through the change I actually made.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:23 -05:00
Owen Leonard 18512df857 Markup correction.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:22 -05:00
Owen Leonard 7ec49e693a Fix to enable OPACUserCSS preference (allows user to add CSS globally in the OPAC via an embedded style block)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:21 -05:00
Owen Leonard 4dfcf1d3a9 More changes to properly implement opacuserlogin preference.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:20 -05:00
Owen Leonard 4d7c20837d Changes to properly implement opacuserlogin preference.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:18 -05:00
Owen Leonard 0f1825d055 Changes to allow highlighting of current tab on user pages.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:17 -05:00
Owen Leonard a4e22029cc Updates to tweak the way suggestions and suggestions links display when various suggestions-related prefs are on or off.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:46:16 -05:00
Chris Nighswonger fffff30b13 Commenting out unused call to get_batches.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:44:46 -05:00
Chris Nighswonger 2ed253639b Modifications to viewlog.pl to keep it in the context from which it was called.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:44:45 -05:00
Chris Nighswonger 73dde7a03a Correcting warn concerning kohaversion.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 15:44:44 -05:00
Chris Nighswonger b28d306a94 Updating patronimages syspref to reflect current sysprefs.sql
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:14:20 -05:00
Galen Charlton e4ea107c9b use bind variables in GetBorrowersWhoHaveNotBorrowedSince query
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:56 -05:00
Galen Charlton 3eb7a607e5 more old_issues SQL cleanup
* no need to test for 'returndate is null' in queries
  on old_issues
* added more stylistic corrections

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:54 -05:00
Galen Charlton 0b7c80ee9f Revert "Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems at the same time as it is to items."
This reverts commit eaac37aa6ea8c4f2b79adaa4186bc08a9ac9efd4.

Rev 052 in updatedatabase.pl already adds more_subfields_xml
to deleteditems - the reverted patch would attempt to add
more_subfields_xml to deleteditems twice for anybody
upgrading from < 048.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:51 -05:00
Henri-Damien LAURENT 2026434ed7 More problems with old_issues.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:46 -05:00
Henri-Damien LAURENT 48856684f3 Assigning bug 1835 : change password would never log password change.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:44 -05:00
Henri-Damien LAURENT 82349a67cf Using old_issues table
need some testing on data since I donot have valid data in my fresh created database.

Note : Shouldnot updatedatabase also cope with data "moving"
when a table is created and that some data should go from one table to another ?

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:42 -05:00
Henri-Damien LAURENT 5904681fac CleanBorrowers fixing.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:40 -05:00
Henri-Damien LAURENT c7054a0247 Updatedatabase UPDATE For more_subfields_xml to be added to deleteditems at the same time as it is to items.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:38 -05:00
Henri-Damien LAURENT 1bd019a86c borr_issues_top : adapting to old_issues changes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:36 -05:00
Henri-Damien LAURENT ad767716dc Bug Fix : 1898 Replaces the previous commit : More fixes.
A) Fixing queries which were mysql old style
B) Fixing output.

+ Fixing queries the same way for bor_issues_top catalogue_out and issues_avg_stats

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 11:08:33 -05:00
Joshua Ferraro 394ff5fc27 fixing item-level_itype =ON imageurl in opac-detail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 06:44:00 -05:00
Galen Charlton afb36c429e refactor C4::Log::logaction
This fix should resolve in whole or in part several bugs
characterized by the error message 'Can't use string ("0")
as a HASH ref while "strict refs" in use', including
bugs 1101, 1899, and 1910.

There are some possibilities for future work:

[1] Dealing with an operator override, e.g., where
    a circ operator needs to get a supervisor
    to enter a login and password and escalate
    the original operator's privileges for a
    transaction, e.g., to forgive a fine.  This
    is an enhancement, of course.
[2] Creating a dummy operator to represent
    batch job runs; or alternatively, give
    each batch job an option to log its work
    under a specified user ID.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 06:34:10 -05:00
Owen Leonard d3e3cc1780 Cleanup of z39.50 search form, addition of checkall js. Addition of tablesorter js to z39.50 results.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-19 06:32:30 -05:00
Galen Charlton 79fd489c19 fixed create table statement for patroncards
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 17:00:42 -05:00
Owen Leonard f3dbe6c27b Adding tablesorter
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:51 -05:00
Owen Leonard 4e9846ac22 Bugfix for table sorting
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:49 -05:00
Owen Leonard 07f85bd3e5 Adding tablesorter
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:48 -05:00
Owen Leonard 1b9b33c8a1 Partial fix for Bug 1949, Bibliographic Address isn't properly displayed on OPAC result page. Changes will have to be made to script to prevent display of pipes between subfield repeitions.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:47 -05:00
Owen Leonard 80de0e0692 Fix for Bug 1951, OPACURLOpenInNewWindow doesn't do anything.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:45 -05:00
Owen Leonard d015460b5b Formatting and adding additional info to display of editions in the OPAC and the staff client.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:40 -05:00
Owen Leonard 23d695b37c Tweak to table-sorter css.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:18:38 -05:00
Chris Nighswonger f41109ee8e Bugfix to correct date format in query used in GetLogs()
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
2008-03-18 15:09:57 -05:00