Commit Graph

14978 Commits

Author SHA1 Message Date
Salvador Zaragoza Rubio 35eb4ced52 Bug 6475 - Edit it's not possible in subfield "0" in MARC framework
When trying to modify the subfield "0" on a field in the
MARC subfield structure admin -> Tag xxx Subfield Constraints,
the boolean condition on liblibrarian fails for the initial "0" value.
Modified condition to allow the value "0"

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 042f89e939)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-19 17:02:50 -05:00
Ian Walls 5d529084c3 Bug 7134: patron records getting corrupted birthdates
If no date of birth is provided in a new member form, the borrower gets the birthdate of "00/02/0", which
is obviously incorrect (the result of passing 0 to the database directly)

The fix is to remove a conditional check buried deep in C4::SQLHelper.  This is in a helper subroutine that was changed
for the Unified Member Search dev (bug 6253).  Reverting this small change to the conditional does not seem to break
search, but testing will be required.

To test:
1. apply patch, and create a new patron with blank birthdate.  The new patron should now have a blank birthdate instead of '00/02/0'
2. search for a borrower by 1 part surname, confirm search works
3. search for a borrower by 2 part surname, confirm search works
4. search for a borrower across firstname AND surname; confirm
5. search for a borrower and include categorycode/branchcode filters

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
I confirm all working tests 1-5
1. Created patron with blank birthdate - birthdate was blank
2. Searched for patron "henry james acevedo III" by using "acevedo" - result was correct
3. Searched for mr. acevedo using "Acevedo III" - result was correct
4. Searched for Henry James Acevedo III, Henry Acevedo and James Acevedo - results were correct
5. Searched for Mr Acevedo with the branch he was not in, with the branch he is in, with a category he was not, and a category he was. All results were correct.

also noted: inner searching seems to be working now? Example: Henry James (firstname) Acevedo III (surname) - searching James Acevedo brings back the correct patron.
Not complaining, just noting. :)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 440c0f21ee)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-19 17:02:47 -05:00
Paul Poulain 5006dd4858 updating history.txt : 3.6.0 & 3.4.6 & KohaCon11 & Joy Nelson 160th
(cherry picked from commit 2216cd4371)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-17 20:28:31 -05:00
Frédérick Capovilla 6f259d2a67 Make all strings translatable in marc21_field_007.tt
http://bugs.koha-community.org/show_bug.cgi?id=7033

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan:
- apply patch
- update po files using 'perl translate update <language-code>
- check po files for new strings from 007 plugin
- translate some / all of them
- update templates with changed po files 'perl translate install <language-code>
- verify 007 still works and got translated
(cherry picked from commit 8fde30912e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-17 20:28:22 -05:00
Liz Rea f67b30e318 Bug 7084 - Re-arranging results_summary for tags so that it applies where it is supposed to
To test:
Verify that New Tag text is the same size as all of the other surrounding text.
Verify that it is consistent in size with results that have existing tags.

See screenshot for what it looked like before:
http://screencast.com/t/hnt15kpS7SH9
Notice that the Add button and New tag text were slightly larger than the
similar constructions for results with existing tags. This patch should fix
that.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
I made sure I had a results list with on record with tags and one without.
Before applying the patch the "New tag" text and "Add" button were
inconsistent for the two records, after applying it they look the same. Nice!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 1d42be9e76)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-17 20:24:14 -05:00
Joy Nelson 7e12f5af01 Bug 7221: C4/Biblio.pm documentation is incorrect.
$dbh is not a valid first parameter.  Removed $dbh from line 392 to show correct syntax.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
(cherry picked from commit 1d0192b85c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-17 20:24:13 -05:00
Chris Nighswonger 06d787536c Bug 7207 - Reverting a portion of commit 607b5449bd which breaks the label export script.
squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern.

Don't change $_ in a list context

Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines.

Signed-off-by: Brendan <brendan@bywatersolutions.com>
(cherry picked from commit 7824a1bc8d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 12:38:24 -05:00
Owen Leonard 4c9e5d3082 Follow-up fix for Bug 5150 - Issuing should read Circulation
Really just a typo, but I found it when trying to chase
down instances of this bug, so here you go.
(cherry picked from commit 55162ca846)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 12:38:12 -05:00
Nahuel ANGELINETTI 8c4e0fbd23 (bug #4518) enhance 2.2 to 3.0 scripts
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e0b029a4f5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 12:37:59 -05:00
Katrin Fischer c7c50eff51 Bug 4161: Preselect active currency for new vendors
Currently when creating a new vendor in acquisitions the alphabetical first
currency will be preselected. For better usability and less mistakes the
active curency should be preselected.

To test:
Check your currency settings in administration.
Your active currency should not be the first in the list.

1) Create a new vendor
Verify the active currency is selected for list and invoice prices.

2) Check vendor summary page
Verify the correct currencies from the vendor record are shown here.

3) Edit vendor
Verify the correct currencies from the vendor record  are shown here.

Signed-off-by: Liz Rea <lrea@nekls.org>
Verified with tests 1, 2, and 3.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 5d5a047984)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 12:37:46 -05:00
Ian Walls ff96db8a54 Bug 2629: Add diacritic support for Ů (U with ring)
Adds Ů and ů support to word-phrase-utf.chr.  These characters are used in
Czech, for example the author Martinů, Bohuslav (1890-1959)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 1e2f697e3b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 12:37:29 -05:00
Ian Walls 604216acf6 Bug 5945: email not searchable in patron search
Adds 'email' to valid search parameters in members/member.pl

To test:
1. give a patron a unique email address in your test database
2. search on the full email; should work
3. search on the part of the email before the domain; should work

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit c3abbedebe)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:42:36 -05:00
Katrin Fischer 05f1a92c21 Bug 7138: Can't print basket group order pdf
PDF print of basket groups is broken.

To test:

1) Make sure OrderPdfFormat is set to pdfformat::layout2pages or pdfformat::layout3pages
2) Create a basket with orders
3) Close the basket and create a basket group checking the checkbox
4) Print the basket group as PDF

Before patch the file is broken and when opened in an editor contains an error message.
After the patch the PDF should be generated correctly again.

Thx to Chris for helping me to fix the problem.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 7a3dc5102e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:42:22 -05:00
Chris Cormack 9aba4077c2 Bug 6679: Fixing admin/aqplain :encoding(UTF-8) gives strict validation
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
tested with diacritics, no changes before and after the patch
(cherry picked from commit ee0627f20b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:41:51 -05:00
Chris Cormack 9e5da38f7c Bug 6679 : Tidying changed parts of file
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 3b0474950c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:41:38 -05:00
Chris Cormack 0f2500bd59 Bug 6679 : Don't declare variables in conditionals
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 21e4d79be8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:41:22 -05:00
Chris Cormack 093d5bb24d Bug 6679 : Not using strict .. bad script, no cookie for you!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit e8ea58270d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:41:06 -05:00
Chris Cormack b207487bbb Bug 6679 : Don't declare variables in conditionals Don't change $_ in a list context http://search.cpan.org/~elliotjs/Perl-Critic-1.116/lib/Perl/Critic/Policy/ControlStructures/ProhibitMutatingListFunctions.pm
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 607b5449bd)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:40:49 -05:00
Chris Cormack 01c462ff28 Bug 6679 : Declare variables outside of conditionals
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 6bb73a04c4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 08:40:34 -05:00
Ian Walls 598c008fa3 Bug 6390 Followup: Basket's authorisedby might not be a borrowernumber
aqbasket.authorisedby is not foreign key constrainted to borrowers.borrowernumber,
so if it's anything other than that, vendor search breaks by using an undefined value
(GetMember() on an invalid borrowernumber) as a HASH ref.

This patch sets the branchcode (the desired value from GetMember) to a blank value, then only
changes it if GetMember is defined.  In the case where the authorisedby librarian has been deleted,
or the value is otherwise invalid, and AcqViewBaskets is set to 'branch', the basket will not appear
except to superlibrarians

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Invalid borrowernumber in aqbasket.authorisedby no longer breaks search.
(cherry picked from commit 58bdfdb088)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:47:55 -05:00
Paul Poulain edcbd0cde0 Bug 7188: C4::Context::db_scheme2dbi does case-insensitive grep
Checking NYTProf in C4::Context, it appears that the /i flag is highly time-consumming
As we don't support anything outside from mysql, returning directly mysql directly

If in a future version PostgresSQL works, then we will have to update this sub. But if an ORM is introduced, this code will be removed completly anyway

Testing note:
Drops execution time of the line from 300ms to 20 microseconds (in my testing).
(cherry picked from commit 0f8db0c538)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:44:06 -05:00
Julian Maurice a6b7a1432a Bug 7185: Fix updatedatabase message for 3.6.0 release
Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
(cherry picked from commit e228f233e4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:43:40 -05:00
Paul Poulain 73139544c8 Bug 7184 raise mySQL error if debug is set
Before this patch, if a mySQL occured in Koha (any error), then the user was seeing nothing.
With this patch, if DEBUG is set in Koha VirtualHost, any mySQL error will make Koha die and display the SQL error

Step to test:
=== BEFORE PATCH ===
go anywhere, and change a mySQL statement to make it invalid.
Launch a page using the SQL you've made wrong, you'll see nothing, except you won't see the expected results

=== AFTER PATCH ===
Modify koha-httpd.conf, and add the following line, in the virtualhost (if it does not already exist)
SetEnv DEBUG 1
restart/reload Apache
Launch the same page, you'll get a Perl statement saying something like:

DBD::mysql::st execute failed: <<blablabla SQL error>> at <<where the error was raised line <<error line>>
(cherry picked from commit 016e66c6f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:43:25 -05:00
Liz Rea 916e103dfc Bug 7128 - adding some ID's to make styling opac-main.tt a bit easier
To test:
verify that the loggedin id is added when user is logged in
verify that the notloggedin id is evident when no user is logged in.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Bug 7128 : Follow up, adding the id to the case when a user is not logged in

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 4ccb8649f8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:43:10 -05:00
Katrin Fischer fe0afd3506 Bug 6994: Wrong 'no budget defined' alert
When ordering from an existing record the 'no budgets and funds defined' error
message was shown below the result list.

To test:
A) No budgets defined for this user and library
Basket summary page shows a warning instead of the link for creation
of orders.

B) Budgets and funds are properly defined for this user and library
Basket summary page shows links for order creation.
Before patch: A search for an existing record had the alert at the bottom
of the search result list.
After patch: The links for creation of orders are shown instead.

Signed-off-by: Liz Rea <lrea@nekls.org>
Verified A and B.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 488f4be865)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:42:46 -05:00
Frédérick Capovilla 99147d2603 Notify the user on his account page when his account is almost expired
New feature : If the "NotifyBorrowerDeparture" system preference is defined, a
notification appears in the user's account page if his subscription is almost
expired.

http://bugs.koha-community.org/show_bug.cgi?id=6978
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
works perfectly with date formatted DD/MM/YYYY as well
(cherry picked from commit e676e117fc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:42:34 -05:00
Ian Walls cf9fca42c3 Bug 6471: add tablesorter to Holds Queue
This patch adds the table sorter to Holds Queue.  Sponsored by Farmington Public Library.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 0ea8ff7c4c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:42:22 -05:00
Owen Leonard 5c2398c005 Fix for Bug 7085 - Problems with searching for orders in acquisitions
Changing "if ( defined $input )" to "if ( $input )" in the section
of the script which builds the order search query seems to give
successful searches where they didn't exist before. Searches from
the advanced order search screen work with title, author, vendor,
basket number, date, etc.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Searches for date ranges, title and author keywords give
me the correct results now.
(cherry picked from commit 0c0ddf9211)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:42:10 -05:00
Katrin Fischer 7622bedd30 Bug 7117: Bug 7117 - Small display problems when organising suggestion tabs by name
To test:
1) Add some suggestions
2) Go to suggestions in staff
3) Choose from filters 'suggested by' or 'managed by'
4) Compare names shown on tabs with names in list of suggestions

Before patch: tab name has the wrong order, while list name is correct.
After patch: all names should be consistent and correct.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit e660cef0e2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:41:55 -05:00
Marcel de Rooy 224d0ca819 7146 (Update timestamps when deleting a biblio)
Currently, when you delete an item, the timestamp column in deleteditems is
updated with current time. (This comes from an [unintentional] additional
update statement in DelItem.) It makes deletion time visible.
In the past, the marcxml was updated too at that moment, resulting in an
updated timestamp in biblioitems too. The timestamp in biblio was not touched.

If you delete a biblio however, the timestamps in deletedbiblio and
deletedbiblioitems do not reflect time of deletion. They still show the time of
last update before the record was deleted. This last update can be extracted
from MARC field 005 too.

This behavior is not consistent nor logical. I would suggest to add a statement
in DelBiblio to force updating the timestamp in deletedbiblio(items) too. It
makes the time of deletion visible in the record too. The time of deletion of a
biblio can be very useful for e.g. synchronizing purposes.

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 7ee0565f5c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:41:41 -05:00
Owen Leonard ca21067cb4 Follow-up fix for Bug 3958, Standardize vendor/supplier/bookseller terminology
Fixing two stray instances of "supplier."
(cherry picked from commit 0038b0df15)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:41:28 -05:00
Ian Walls 9452c84a9a Bug 7061: unnecessary global variables declared in C4::SQLHelper
Removes $tablename and $hash from global scope of C4/SQLHelper.pm.  They are never used;
all instances of $table are locally scoped to the subroutines, and $hash is never used.

This may help with persistance; if not, it's at least a bit of trivial cleanup.

To test:

1.  Search for a patron
2.  Create a Contract in Acquisitions
3.  Modify that Contract
4.  Delete that Contract

All instances should return error free.  This checks the subroutines of SQLHelper

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 36d8e5df96)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:41:14 -05:00
Frédéric Demians 0ec00cd1cb Bug 6989 Patron categories not properly displayed if not pure ASCII
C4::Category module returns badly encoded patron categories when they are
containing non pure-ASCII characters.

To reproduce this bug:

  - Go in Administration > Patron Categories
  - Add a new category. Give it this code for example:
    Café
  - Click on Patrons link on top menu
  - Click on New button

    => You get 'Café' displayed without accent

Signed-off-by: Piotr Wejman <ropuch@bagno.be>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit d998166ea3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:40:59 -05:00
Paul Poulain da2dfd0dce Bug 5885 : UNIMARC XSLT changes
dealing with some BNF/SUDOC invalid utf-8 (in title, the removed fields are used to mark non-sorted words)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

I can't test this works ok for UNIMARC, but it does not cause any
problems with the translation scripts or MARC21 so signing off
(cherry picked from commit cc6c1acb38)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:40:43 -05:00
Ian Walls d6e27f5cee Bug 7076: Lists render OPAC XSLT on staff side
Adds a small check in C4::VirtualShelves::Page::shelfpage to only render
OPACResultsXSLT if the $type is 'opac'.  Since parsing the XML is such an expensive
thing, and the resulting XSLTBloc is not used on the staff side, this will increase
performance for Lists in the intranet

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit a0a9368bec)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:40:30 -05:00
Frédérick Capovilla 12070db7d8 Follow-up patch : use the subfield associated with items.barcode
Instead of using the 'p' subfield directly, use the subfield letter
associated with the items.barcode column.

http://bugs.koha-community.org/show_bug.cgi?id=6963
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Test cases tested:
- 1 item, barcode empty
- 2 items, barcodes both empty
- 1 item, existing barcode
- 1 item, new barcode
- 2 items, one barcode empty, one existing

All test cases worked nicely and gave correct error messages.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 61e1eeee84)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:40:16 -05:00
Frédérick Capovilla 2f36d9b45f Bug 6963: Corrects a problem when a new order is created with a duplicate barcode.
If the AcqCreateItem preference is set to "ordering" and the barcode for
the new item is already in use, no error is returned, but an invalid
itemnumber is saved in the aqorders_items table and the item is never
created.

This patch adds a duplicate barcode verification in neworderempty.pl
_koha_add_item is also modified so it won't return an invalid ID when
an item can't be added.

http://bugs.koha-community.org/show_bug.cgi?id=6963
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan on second patch.
(cherry picked from commit 327be442bd)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:40:03 -05:00
Chris Cormack f9af3fc79b Bug 6895 : First attempt at fixing the diacritics bug
This is a fairly hacky solution, a counter patch would be more than
welcome

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Updated, translated and installed German po files after applying this patch.
No problems found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit afaf7eaffa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:39:50 -05:00
Maxime Pelletier 6eb4a7f583 Bug 7069: Put strings in "" instead of '' to fix the javascript not working when the translated string has a ' in it.
http://bugs.koha-community.org/show_bug.cgi?id=7069

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes '' to "" to make it work for strings which contain '.
Patch does NOT add new strings to the po files.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 7ff9d9d03c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:39:36 -05:00
Owen Leonard 75586d7ea7 Fix for Bug 6955, Toolbar on reading history broken
Table sorter script causes error if there is no <tbody> to sort.
JS errors cause the YUI toolbar js to abort, causing the problem
observed. When there are no results the whole table should be
omitted and a message displayed in its place.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
To test:
- check toolbar on top of patron reading history with no entries
- check toolbar on top of patron reading history after a few checkouts

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 54226b60f3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:39:23 -05:00
Maxime Pelletier b8c840734f Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments
http://bugs.koha-community.org/show_bug.cgi?id=6414
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>

Signed off with a note: this doesn't fix everything mentioned in the bug.
It also might clash with bug 4831 and should be tested with that patch.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit 0faf91c591)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:38:48 -05:00
Chris Cormack 3024ac0b41 Sorry pushed this by mistake when trying to fix Pauls permissions
Revert "Fix for Bug 5974 - Bogus auth check for "StaffMember" role"

This reverts commit a867bfcff7.
(cherry picked from commit 7a82e508f0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:38:44 -05:00
Owen Leonard 6a0be28284 Fix for Bug 5974 - Bogus auth check for "StaffMember" role
Also removing some YAHOO.widget.Button declarations which
are redundant.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a867bfcff7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
2011-11-16 07:35:55 -05:00
Chris Cormack 52c666edce Updating version number for release 2011-10-22 10:26:13 +13:00
Chris Cormack f4d9b8e9dc Release notes for 3.6.0 2011-10-22 10:24:05 +13:00
Chris Cormack d89eb95b0b Updating distro specific install files 2011-10-22 09:12:15 +13:00
Chris Cormack 55306b9267 Updating main INSTALL instructions 2011-10-22 09:04:19 +13:00
Ian Walls d52095b48c Bug 7078: Remove HTML::Template::Pro from Koha perl dependencies list
Removes HTML::Template::Pro as a requirement (since we're now on Template::Toolkit).

To test:

On a system without, HTML::Template::Pro installed, run perl koha_perl_deps.pl -m -u

Shouldn't return anything about HTML::Template::Pro

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-10-22 09:01:26 +13:00
Ian Walls 0953e8ca09 Bug 7063: add available perl packages for Debian in install_misc/debian.packages
Takes work done by Eduardo Trápani, alphabetizes, and adds two other packages:

libuniversal-require-perl
libgravatar-url-perl

From my testing, only CGI::Session::Driver::memcached remains missing; it is only
packaged for sid and wheezy at this time

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
2011-10-22 09:00:33 +13:00
Chris Cormack c8df6bdcc9 Merge remote-tracking branch 'kc/new/bug_5995' into kcmaster
Conflicts:
	opac/sco/sco-main.pl
2011-10-22 06:36:36 +13:00