Matt Blenkinsop
2e2b6ea0a8
Bug 38201: Split InputElement into text and number variants
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:33 -06:00
Matt Blenkinsop
4c8ba970b9
Bug 38201: Add an InputCheckboxElement component
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:32 -06:00
Matt Blenkinsop
47be86b5c0
Bug 38201: Add a TextareaElement component
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:32 -06:00
Matt Blenkinsop
5db2f4bcc0
Bug 38201: Add an InputElement component
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:31 -06:00
Matt Blenkinsop
d22cb75eab
Bug 38201: Prevent 'Invalid Date' from displaying
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:31 -06:00
Matt Blenkinsop
35bc45139a
Bug 38201: Remove additional fields from resourceAttrs
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:30 -06:00
Matt Blenkinsop
6b12997218
Bug 38201: Introduce 'hideIn' array to simplify attribute definitions
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:30 -06:00
Matt Blenkinsop
338c03a71a
Bug 38201: Improve consistency of table columns definition
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:29 -06:00
Matt Blenkinsop
3686d71ac7
Bug 38201: Rename resourceListFiltersRequired
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:29 -06:00
Matt Blenkinsop
06d642ac7f
Bug 38201: Fix translation tags
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:28 -06:00
Matt Blenkinsop
882b92712b
Bug 38201: Migrate WaitingList
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:28 -06:00
Matt Blenkinsop
6203fe471b
Bug 38201: Allow toolbar buttons to access component props
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:27 -06:00
Matt Blenkinsop
f7fe0a3924
Bug 38201: Implement copy item to train modal
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:27 -06:00
Matt Blenkinsop
3876b74ad8
Bug 38201: Move getResource to BaseResource
...
Also adds refreshTemplateState, for use to update components on state changes when access to the component context is not available
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:26 -06:00
Matt Blenkinsop
29233b0b6e
Bug 38201: Migrate Dialog to use FormElement
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:26 -06:00
Matt Blenkinsop
345764acc3
Bug 38201: Migrate the train items table to appendToShow
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:25 -06:00
Matt Blenkinsop
bd6caf88ca
Bug 38201: Add a afterResourceFetch hook
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:25 -06:00
Matt Blenkinsop
c503d58197
Bug 38201: Move additionalProps to data
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:24 -06:00
Matt Blenkinsop
8b93b18450
Bug 38201: Enable custom Kohatable action buttons
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:24 -06:00
Matt Blenkinsop
8174e09c27
Bug 38201: Add additional toolbar buttons to Trains
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:23 -06:00
Matt Blenkinsop
ba620c953c
Bug 38201: Add missing fields to show trains
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:23 -06:00
Matt Blenkinsop
4637ec2b0c
Bug 38201: Rename getFilters to getFilterValues
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:22 -06:00
Matt Blenkinsop
cb43ba3dbe
Bug 38201: Rename getTableFilters to getTableFilterFormElements
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:22 -06:00
Matt Blenkinsop
05d206cec5
Bug 38201: Fix filter options
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:21 -06:00
Matt Blenkinsop
5a3f6ec060
Bug 38201: Add default to trains not_for_loan
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:21 -06:00
Matt Blenkinsop
6e29cff4c7
Bug 38201: Add missing i18n strings for Trains
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:20 -06:00
Matt Blenkinsop
f4ddee335c
Bug 38201: Correct embedded property for the toolbar
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:20 -06:00
Jonathan Druart
ca35287b39
Bug 38201: Radio FormElement - pass default FIXME/DEBUG
...
Why cannot we do that? I am missing something obvious.
The debug shows: "{} true"
(cherry picked from commit 354497d68d61e39bf4762e4b898303720ab55785)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:19 -06:00
Jonathan Druart
256a65230d
Bug 38201: Add 'Filter by:' label before the filters
...
(cherry picked from commit 04257a558045ccedbd9788ec7ce03c93a7756e82)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:19 -06:00
Pedro Amorim
80da5e3d8a
Bug 38201: Radio FormElement follow-up
...
(cherry picked from commit 7e645f19fc3567bcbc2476ad1b4d21205282c4b6)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:18 -06:00
Jonathan Druart
759fe80c76
Bug 38201: Preservation - toolbar
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:18 -06:00
Jonathan Druart
2be89ad919
Bug 38201: Toolbar - add on click
...
(cherry picked from commit 5a4c6c5b15b3a2101b3520419107236b0576efee)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:17 -06:00
Jonathan Druart
f284b4dd7a
Bug 38201: Preservation toolbar
...
(cherry picked from commit 75aa0850893956b3f39799be4e558a569f5d9648)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:17 -06:00
Jonathan Druart
3e6c37ce6b
Bug 38201: Move preservation
...
(cherry picked from commit c58d5211048e2545eddf699c7275720099263d03)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:16 -06:00
Jonathan Druart
ea7b319734
Bug 38201: Fix preservation route
...
This is not correct, we need to retrieve the first parent with
is_end_node==true (I think)
(cherry picked from commit 98fbdf3d6ee7fde3266d52ffa5f46ed9c2320be1)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:16 -06:00
Jonathan Druart
9e86e1a5fe
Bug 38201: Improve code
...
(cherry picked from commit 38f6133e68e4f514954c7ed073f186abc5f86783)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:15 -06:00
Jonathan Druart
7c6ab84405
Bug 38201: Add 'radio' support to filters
...
In the context of the Preservation module, some changes expected here
however
Before:
Filter by: o All o Closed o Sent o Received
After:
All: o Closed: o Sent: o Received: o
(cherry picked from commit c2bc61ba7daa70eebe158b327b9fef0b6be44507)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:15 -06:00
Jonathan Druart
a7b66a877c
Bug 38201: Pass type='date' for date columns
...
(cherry picked from commit 15cbafd582a225f1eff1d942ea8b61d39267a32e)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:14 -06:00
Jonathan Druart
eaa096ca58
Bug 38201: Add 'required' support to FormRelationshipSelect
...
(cherry picked from commit 92ba6b9fbb6a81fb2b438ba8c1200863610dbfe4)
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:14 -06:00
Matt Blenkinsop
c1807b8ef0
Bug 38201: Allow ordering of toolbar buttons
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:13 -06:00
Matt Blenkinsop
edfa43fee2
Bug 38201: Extend additional toolbar buttons
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:13 -06:00
Jonathan Druart
6dbd7e1e75
Bug 38201: Use getToolbarButtons for "show"
...
Currently it's only used for the "list" view, and so its name was
confusing.
Now it can also be used for the "show" view, and allow addition of
custom buttons.
TODO:
1. I had to pass the resource from BaseResource as ResourceList could
not access the resource[idAttr] value easily.
Ideally we shouldn't need to pass functions
getToolbarButtons().list()
getToolbarButtons().show(resource)
But only the array of buttons defs:
getToolbarButtons().list
getToolbarButtons().show
2. There is duplication of code when the default is overwritten. We
could fallback to the default when none passed, or pass a string
instead of the full button's def:
return {
list: () => {
return [
"add",
{
to: { name: "EHoldingsLocalTitlesFormImport" },
icon: "plus",
title: __("Import from list"),
},
{
to: { name: "EHoldingsLocalTitlesKBARTImport" },
icon: "plus",
title: __("Import from KBART file"),
},
],
},
show: resource => {
return ["edit", "delete"]
}
}
But that is much more work and not a blocker for now IMO
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:12 -06:00
Pedro Amorim
e4e1bdc313
Bug 38201: Fix i18n
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:12 -06:00
Matt Blenkinsop
9888e7c60a
Bug 38201: Fix UI regression caused by RelationshipSelect
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:11 -06:00
Pedro Amorim
4d4149bde0
Bug 38201: Restore 'href' to table links
...
Bring back middle mouse button click opens in new tab interaction
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:11 -06:00
Pedro Amorim
586e24ad6d
Bug 38201: Update Cypress tests
...
perl /kohadevbox/misc4dev/run_tests.pl --run-cypress-tests-only
All passing
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:10 -06:00
Pedro Amorim
0f4c3fd1b0
Bug 38201: Ensure all HTML ids use plural form of resource name
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:10 -06:00
Pedro Amorim
e05e0f1f1d
Bug 38201: Fix setWarning call in titles+packages
...
'this' is scoped inside forEarch, an error was thrown when submiting the form with errors
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:09 -06:00
Matt Blenkinsop
4cd93c87cf
Bug 38201: Delete LicensesList
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:09 -06:00
Matt Blenkinsop
270798ce49
Bug 38201: Remove accordion display from agreements
...
Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2025-10-02 09:39:08 -06:00