Commit Graph

10161 Commits

Author SHA1 Message Date
Garry Collum 10bc9bc1be Bug 3360: Fix for unclosed <ol> element in export.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:15 +02:00
Garry Collum 497788d816 Bug 3362: Fixes invalid xhtml in stage-marc-import.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:15 +02:00
Owen Leonard 0679846269 Reformatting interface for Notice Triggers (Bug 3366)
Breaking up the table of options into three separate ones for first, second, and third notices, each in its own tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:15 +02:00
Owen Leonard 98bde3e698 Putting text form field first ensures field will correctly be given focus.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Nahuel ANGELINETTI 9c985c1426 (bug #3364) add itemnotes in itemslost report
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Nahuel ANGELINETTI 9178f8687d (bug #3368) index 464$t in unimarc
this patch add 464$t part of Title index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Nahuel ANGELINETTI 6dbdb30c09 (bug #3369) add 995$* unimarc fields in "item" index
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Garry Collum fc2a6225b5 Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.
Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Garry Collum a04a3241df Bug 2889: Removed toggle variable from z3950_search.pl.
Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Owen Leonard 1a90c1617a Another fix for Bug 3119 (Add date due to circ history)
Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Liz Rea 53b5c87aa8 bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Frédéric Demians 0053486cfa Bug 3301 - Speed up rebuild_zebra script
With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:

  rebuild_zebra -r -b -nosanitize

Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.

DOCUMENTATION:

rebuild_zebra.pl new paramater:

-nosanitize  export biblio/authority records directly from DB marcxml
             field without sanitizing records. It speed up
             dump process but could fail if DB contains badly
             encoded records. Works now only with -x and -b

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:14 +02:00
Joe Atzberger c0fd827a8a checkoverdues should not require $dbh
Passing $dbh around is an ancient style that doesn't know
to use C4::Context.  C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.

I also internalized $today into the SQL using NOW() in the query
and removed sth->finish.  Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers.  However, I did convert
it so it doesn't require a $count variable and its own loop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Joe Atzberger fdf6cda577 Return amount for CREDITS, POD rework.
The main change here is to get an {amount} field for CREDITS,
not just CHARGES.  I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.

POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference.  Deprecated display layer code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Joe Atzberger 66808ad2b5 Cleanup Members.pm - minor
MoveMemberToDeleted is problematic.  It has a bad name, since it
only copies, not moves.  Also the POD for it referenced a totally
different function name and was largely useless.  Sanity checks inserted.

A couple sth->finish removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Joe Atzberger 0664c7bb6a Remove unused variable and add FIXME.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Chris Nighswonger d86b310200 Adding installation documentation for Ubuntu
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Jane Wagner 862beea7c0 Bug # 2368 Change holds to pull default date range
Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today.  Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Joe Atzberger 14a7b39529 Bug 3350 - fail on queued emails w/ no address
If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely.  Otherwise they get mailbombed when
their email IS added.

Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin).  The other messaging features are the
targets affected by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Frédéric Demians 1b46d23e8e Bug 3351 - Limit Serials Search for Biblio to an item type
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:13 +02:00
Liz Rea 98cce25505 Adding links to guided reports wizard, dictionary, create from sql to reports home page.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:12 +02:00
Joe Atzberger 4c8bbd51df Correct POD and misleading variable names from copy/paste laziness
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:12 +02:00
Nahuel ANGELINETTI 1d6c94b1bf (bug #3339) fix rollover showed value
This patch just print the value of "whenmorethan1", that was missed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:12 +02:00
Garry Collum 13d3ded1b7 Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:12 +02:00
Ryan Higgins e903f64ef2 Add MARC21 Fast-add Framework.
Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:12 +02:00
Garry Collum 4d097814ee Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl.  Used template __odd__ variable instead.

Corrected a typo in the highlight class definition in .tmpl.

Corrected a readability issue with the description when deleting a subfield in .tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum 2db7c0fa14 Bug 2889: Removed toggle variable from stopwords.pl and .tmpl.
Removed toggle variable from stopwords.pl and stopwords.tmpl. Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Joe Atzberger f90913bce1 Cleanup - admin scripts
Fixed useless redirect statements that weren't even printed.
Removed unused javascript and script variables;
Removed sth->finish.  Use get instead of post on "cancel" button (no data to post).
Reduce duplicative variables (e.g. scriptname and script_name).

Many other problems are still in the scripts, including use of META-REFRESH instead of
redirect, and the whole idea of redirecting back to the same page for no valid reason.
We should be able to formulate the right response on THIS pass, not ask the browser to start over.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum b39910f15a Bug 2889: Removed unused toggle variable from pcard-member-search.pl. Added table highlighting to .tmpl.
Removed unused toggle variable form pcard-member-search.pl.

Added highlighting to pcard-members-search.tmpl and fixed some XHMTL errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum 8e81882ae5 Bug 2889: Removed toggle variable from aqbudget.tmpl. Used template variable __odd__ instead.
Removed toggle variable from aqbudget.pl and aqbudget.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum 61874463ff Bug 2889: Added template __odd__ variable to letter.tmpl
Used __odd__ variable instead of toggle in letter.tmpl.  No toggle variable was defined in letter.pl.

The table in letter.tmpl uses jquery for highlighting so the above may not be necessary, unless javascript is turned off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum e4869c8c1a Bug 2889: Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl.
Removed toggle variable from aqbookfund.pl and aqbookfund.tmpl. Used template __odd__ variable in aqbookfund.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Joe Atzberger 86b4bf18ab Cleanup authtypes and currency .pl and .tmpl
Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Added some HTML escaping in TMPL.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum 96777b2a3d Bug 2889: Removed toggle variables from z3950servers.pl and .tmpl
Removed toggle variables from z3950servers.pl and z3950servers.tmpl.  Used template __odd__variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Garry Collum 211711d845 Bug 2889: Removed toggle variable from roadtype.pl and .tmpl.
Removed toggle variable from roadtype.pl and roadtype.tmpl.  Corrected typo in class definition in roadtype.tmpl and add highlighting through the templated __odd__ variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:11 +02:00
Galen Charlton 650f970a87 removing disused C4::Serials functions
The following functions are no longer in use:

* old_newsubscription
* old_modsubscription
* old_getserials

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:10 +02:00
Galen Charlton 91b9fda3cf removing disused script
serials/subscription-copy.pl had been removed
in commit 8c78ff5aa5 but
for some reason had been accidentally restored in
a subsequent commit.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:10 +02:00
Frédéric Demians 13286efc37 Bug 3316 - Improve last 3 issues displayed on OPAC detail page
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:10 +02:00
Chris Cormack 738990940f Escaping HTML in the search results in the Librarian interface
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:10 +02:00
Garry Collum 69cb3944d4 Bug 2889: Removed toggle variable from itemtypes.tmpl. (resubmittal)
Removed toggle variable from itemtypes.tmpl and itemtypes.pl.  Used the __odd__ template variable instead.

Resubmittal - first patch contained a typo.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:10 +02:00
Nahuel ANGELINETTI 2eec617c92 (bug #3304) fix notices trigger with diacritics in categorycodes
This just utf8::encode the $key if needed to permit categorycodes with diacritics.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:09 +02:00
Galen Charlton fd83ed6b27 bug 3314: remove disused scripts and API functions
The distributedto column of the subscription table is
no longer used, having been replaced by the serials
routing list table.  This patch removes two C4::Serials
functions and a script and template, none of which were
reachable by current code:

C4::Serials::GetDistributedTo()
C4::Serials::SetDistributedTo()
koha-tmpl/intranet-tmpl/prog/en/modules/serials/distributedto.tmpl
serials/distributedto.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:08 +02:00
Brian Harrington 26b4f072e8 Bug 3313, bulkauthimport.pl skips MARC21 subdivision records.
This patch adds the MARC21 subdivsion record tags (18x) to the
block which recognizes and assigns authtypecodes to imported
authority records.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:08 +02:00
Galen Charlton 0f45cc2f7a fixed bug resulting in invalid XHTML
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:08 +02:00
Garry Collum 9f5aeecd55 Bug 2889: Removed toggle variable from overduerules.tmpl - added __odd__
Removed toggle variable from overduerules.pl and overduerules.tmpl. Used template variable __odd__ instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00
Garry Collum 1effd6f08b Bug 2889: Added shading for alternating rows to authorised_values.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00
Garry Collum 25eb30373f Bug 2889: Removed toggle variable from koha2marclinks.tmpl. Used template __odd__ variable.
Removed toggle variable from koha2marclinks.tmpl and koh2marclinks.pl.  Used template __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00
Garry Collum 9965900be5 Bug 2889: Removed toggle variable from currency.tmpl. Used template __odd__ instead.
Removed toggle variable from currency.tmpl and currency.pl.  Used template __odd_ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00
Galen Charlton 5f7dcd86bc bug 3259 part 3: changed last 'Too Many Renewals' to 'Not Renewable'
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00
Nicole Engard e522fa5b20 Fix Bug 3259 part 2 - fixed terminology on circulation.tmpl
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
2009-09-16 23:19:07 +02:00