Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold

In previous versions of Koha, if a hold canceled from the "Holds over" tab had other holds on it,
the librarian would be alerted with the message "This item is on hold for pick-up at your library"
and directed to check it in to fill the next hold. This no longer happens.

Test Plan:
1) Apply this patch
2) Find a hold that has been waiting too long
3) Cancel that hold via waitingreserves.pl
4) Note you get the message "This item is on hold for pick-up at your library"
5) Confirm the ok button redirects you to the correct tab

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit b80a18ee2f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 40e667cd21)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
This commit is contained in:
Kyle M Hall 2016-08-01 07:17:04 -07:00 committed by Julian Maurice
parent e48dac0bf5
commit ffe13850d5
2 changed files with 6 additions and 5 deletions

View File

@ -158,9 +158,10 @@ $template->param(
overcount => $overcount,
show_date => output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }),
ReservesMaxPickUpDelay => C4::Context->preference('ReservesMaxPickUpDelay')
tab => $tab,
);
if ($item && $tab eq 'holdsover') {
if ($item && $tab eq 'holdsover' && !@cancel_result) {
print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl#holdsover");
} elsif ($cancelall) {
print $input->redirect("/cgi-bin/koha/circ/waitingreserves.pl");

View File

@ -51,8 +51,8 @@
<p><strong>[% nextreservtitle %]</strong> is on hold for <strong> [% nextreservsurname %], [% nextreservfirstname %]</strong>.
Please retain this item and check it in to process the hold.
</p>
<form name="cancelReservewithtransfert" action="waitingreserves.pl" method="post">
<input type="submit" class="submit" value="OK" />
<form name="cancelReservewithtransfert" action="waitingreserves.p#[% tab %]" method="post">
<input class="btn" type="submit" class="submit" value="OK" />
</form>
</div>
[% END %]
@ -62,8 +62,8 @@
<p><strong>[% nextreservtitle %]</strong> is on hold for <strong>[% nextreservsurname %], [% nextreservfirstname %]</strong>.
Please retain this item and check it in to process the hold.
</p>
<form name="cancelReservewithwaiting" action="waitingreserves.pl" method="post">
<input type="submit" class="submit" value="OK"/>
<form name="cancelReservewithwaiting" action="waitingreserves.pl#[% tab %]" method="post">
<input class="btn" type="submit" class="submit" value="OK"/>
</form>
</div>
[% END %]