Bug 17114: Fix XSS in picture-upload.pl
To reproduce: 1/ cp your_image.jpg 'test<svg onload=alert(1)>.jpg' 2/ Use the upload picture tool to upload this file => Without this patch, the alert is show => With this patch, the filename is correctly displayed and no alert Note that the cardnumber var was not escaped neither, it's now. Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (cherry picked from commitda03dbd458) Signed-off-by: Frédéric Demians <f.demians@tamil.fr> (cherry picked from commit0fba9c17c9) Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
This commit is contained in:
parent
fe5b80d563
commit
e48dac0bf5
|
|
@ -56,8 +56,8 @@
|
|||
[% IF ( COUNT.TCOUNTS ) %]<li>[% COUNT.TCOUNTS %] image(s) moved into the database:</li>[% END %]
|
||||
[% FOREACH filename IN COUNT.filenames %]
|
||||
<tr>
|
||||
<td>[% filename.source %]</td>
|
||||
<td><a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% filename.cardnumber %]">[% filename.cardnumber %]</a></td>
|
||||
<td>[% filename.source | html %]</td>
|
||||
<td><a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% filename.cardnumber | url %]">[% filename.cardnumber | html %]</a></td>
|
||||
<td>
|
||||
[% IF ( filename.filerrors ) %]
|
||||
[% FOREACH filerror IN filename.filerrors %]
|
||||
|
|
|
|||
Loading…
Reference in New Issue