gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 7703: (QA follow-up) 

Revised test plan from Owen:

This patch modifies the hold process so that if one of the titles in a
multi-hold process has no items the process doesn't abort completely.

To test, apply the patch and perform a search in the catalog which will
return one or more records with no items attached.

 - Check checkboxes for multiple results, some of which have items and
   at least one of which has no items.
 - Click "Place hold."
 - You should be taken to the page for placing multiple holds, with a
   heading, "Cannot place hold on some items."
 - Note: You will not be able to complete the holds process without the
   next patch.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
This commit is contained in:
Kyle M Hall 2021-08-06 11:46:12 +00:00
parent c3a8607bcd
commit e20c7ec259
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
View File

@ -864,12 +864,12 @@
<fieldset class="action">
[% IF ( patron AND patron.borrowernumber ) %]
[% IF ( override_required ) %]
<button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place hold</button>
<button type="submit" class="btn btn-default warning"><i class="fa fa-exclamation-triangle "></i> Place holds</button>
[% ELSIF ( none_available ) %]
<button type="submit" disabled="disabled" class="btn btn-default btn-disabled">Place hold</button>
<button class="btn btn-default" type="submit">Place holds</button>
[% ELSE %]
[% IF ( multi_hold ) %]
<button type="submit" class="btn btn-default" id="multi_hold_submit">Place hold</button>
<button type="submit" class="btn btn-default" id="multi_hold_submit">Place holds</button>
[% ELSE %]
<button type="submit" class="btn btn-default">Place hold</button>
[% END %]

2
reserve/request.pl
View File

@ -405,7 +405,7 @@ foreach my $biblionumber (@biblionumbers) {
unless ( $items->count ) {
# FIXME Then why do we continue?
$template->param('noitems' => 1);
$template->param('noitems' => 1) unless ( $multi_hold );
$biblioloopiter{noitems} = 1;
}