Merge branch 'bug2505_patches' of git://git.catalyst.net.nz/koha into to-push

* 'bug2505_patches' of git://git.catalyst.net.nz/koha: (24 commits)
  Bug 2505 - use strict and warnings in sax_parser_test
  Bug 2505 - enable warnings for link_bibs_to_authorities
  Bug 2505 - add strict and warnings to perlmodule_ls
  Bug 2505 - add strict and warnings to check_sysprefs
  Bug 2505 - Add commented use warnings where missing in *.t
  Bug 2505 - Add commented use warnings where missing in *.pm
  Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory
  Bug 2505 - Add commented use warnings where missing in the misc/ directory
  Bug 2505 - Add commented use warnings where missing in the tools/ directory
  Bug 2505 - Add commented use warnings where missing in the installer/ directory
  Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory
  Bug 2505 - Add commented use warnings where missing in the C4/ directory
  Bug 2505 - Add commented use warnings where missing in the serials/ directory
  Bug 2505 - Add commented use warnings where missing in the catalogue/ directory
  Bug 2505 - Add commented use warnings where missing in the sms/ directory
  Bug 2505 - Add commented use warnings where missing in the opac/ directory
  Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory
  Bug 2505 - Add commented use warnings where missing in the suggestion/ directory
  Bug 2505 - Add commented use warnings where missing in the admin/ directory
  Bug 2505 - Add commented use warnings where missing in the circ/ directory
  ...

Conflicts:
	C4/Auth_with_cas.pm
	acqui/supplier.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

C4/Accounts.pm

@@ -19,6 +19,7 @@ package C4::Accounts;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Stats;
 use C4::Members;

C4/Auth.pm

@@ -18,6 +18,7 @@ package C4::Auth;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use Digest::MD5 qw(md5_base64);
 use Storable qw(thaw freeze);
 use URI::Escape;

C4/Auth_with_ldap.pm

@@ -18,7 +18,7 @@ package C4::Auth_with_ldap;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-# use warnings; almost?
+#use warnings; FIXME - Bug 2505
 use Digest::MD5 qw(md5_base64);
 
 use C4::Debug;

C4/AuthoritiesMarc.pm

@@ -17,6 +17,7 @@ package C4::AuthoritiesMarc;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Koha;
 use MARC::Record;

C4/AuthoritiesMarc/MARC21.pm

@@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::MARC21;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 our $VERSION = 3.00;
 

C4/AuthoritiesMarc/UNIMARC.pm

@@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::UNIMARC;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 our $VERSION = 3.00;
 
 =head1 NAME

C4/BackgroundJob.pm

@@ -19,6 +19,7 @@ package C4::BackgroundJob;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Auth qw/get_session/;
 use Digest::MD5;

C4/Barcodes/PrinterConfig.pm

@@ -16,6 +16,7 @@ package C4::Barcodes::PrinterConfig;
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use vars qw($VERSION @EXPORT);
 
 use PDF::API2;

C4/Bookseller.pm

@@ -18,6 +18,7 @@ package C4::Bookseller;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT);
 

C4/Branch.pm

@@ -17,6 +17,7 @@ package C4::Branch;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 require Exporter;
 use C4::Context;
 use C4::Koha;

C4/Budgets.pm

@@ -18,6 +18,7 @@ package C4::Budgets;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Dates qw(format_date format_date_in_iso);
 use C4::SQLHelper qw<:all>;

C4/Circulation.pm

@@ -19,7 +19,7 @@ package C4::Circulation;
 
 
 use strict;
-#use warnings;  # soon!
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Stats;
 use C4::Reserves;

C4/Contract.pm

@@ -18,6 +18,7 @@ package C4::Contract;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::SQLHelper qw(:all);
 
 use vars qw($VERSION @ISA @EXPORT);

C4/Csv.pm

@@ -19,6 +19,9 @@ package C4::Csv;
 #
 #
 
+#use strict;
+#use warnings; FIXME - Bug 2505
+
 use C4::Context;
 use vars qw($VERSION @ISA @EXPORT);
 

C4/Heading.pm

@@ -18,6 +18,7 @@ package C4::Heading;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 use MARC::Field;
 use C4::Context;

C4/Heading/MARC21.pm

@@ -18,6 +18,7 @@ package C4::Heading::MARC21;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use MARC::Record;
 use MARC::Field;
 

C4/Installer.pm

@@ -18,6 +18,7 @@ package C4::Installer;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 our $VERSION = 3.00;
 use C4::Context;

C4/Items.pm

@@ -18,6 +18,7 @@ package C4::Items;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use Carp;
 use C4::Context;

C4/Koha.pm

@@ -19,6 +19,7 @@ package C4::Koha;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Output;
 use URI::Split qw(uri_split);

C4/Languages.pm

@@ -20,7 +20,7 @@ package C4::Languages;
 
 
 use strict; 
-#use warnings;   #FIXME: turn off warnings before release
+#use warnings; FIXME - Bug 2505
 use Carp;
 use C4::Context;
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG);

C4/Maintainance.pm

@@ -21,6 +21,7 @@ package C4::Maintainance; #assumes C4/Maintainance
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 require Exporter;

C4/Members.pm

@@ -19,6 +19,7 @@ package C4::Members;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Dates qw(format_date_in_iso);
 use Digest::MD5 qw(md5_base64);

C4/Members/AttributeTypes.pm

@@ -18,6 +18,7 @@ package C4::Members::AttributeTypes;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 use vars qw($VERSION);

C4/Output.pm

@@ -26,6 +26,7 @@ package C4::Output;
 # templates.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Context;
 use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags language_get_description accept_language );

C4/Overdues.pm

@@ -19,6 +19,7 @@ package C4::Overdues;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use Date::Calc qw/Today Date_to_Days/;
 use Date::Manip qw/UnixDate/;
 use C4::Circulation;

C4/Print.pm

@@ -18,6 +18,7 @@ package C4::Print;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Circulation;
 use C4::Members;

C4/Record.pm

@@ -19,7 +19,8 @@ package C4::Record;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 #
-use strict;# use warnings; #FIXME: turn off warnings before release
+use strict;
+#use warnings; FIXME - Bug 2505
 
 # please specify in which methods a given module is used
 use MARC::Record; # marc2marcxml, marcxml2marc, html2marc, changeEncoding

C4/Reports.pm

@@ -18,6 +18,7 @@ package C4::Reports;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);

C4/Reports/Guided.pm

@@ -18,7 +18,7 @@ package C4::Reports::Guided;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-# use warnings;  # FIXME: this module needs a lot of repair to run clean under warnings
+#use warnings; FIXME - Bug 2505 this module needs a lot of repair to run clean under warnings
 use CGI;
 use Carp;
 

C4/Reserves.pm

@@ -21,7 +21,7 @@ package C4::Reserves;
 
 
 use strict;
-# use warnings;  # FIXME: someday
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Biblio;
 use C4::Members;

C4/Ris.pm

@@ -57,6 +57,8 @@ package C4::Ris;
 #
 #
 
+#use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT);
 

C4/RotatingCollections.pm

@@ -23,6 +23,7 @@ package C4::RotatingCollections;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 require Exporter;
 

C4/SIP/xmlparse.pl

@@ -7,6 +7,7 @@
 # in Sip::Configuration.pm
 #
 use strict;
+#use warnings; FIXME - Bug 2505
 use English;
 
 use XML::Simple qw(:strict);

C4/Scheduler.pm

@@ -18,6 +18,7 @@ package C4::Scheduler;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 use C4::Context;

C4/Search.pm

@@ -16,7 +16,7 @@ package C4::Search;
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
-# use warnings; # FIXME
+#use warnings; FIXME - Bug 2505
 require Exporter;
 use C4::Context;
 use C4::Biblio;    # GetMarcFromKohaField, GetBiblioData

C4/Search/PazPar2.pm

@@ -18,6 +18,7 @@ package C4::Search::PazPar2;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use LWP::UserAgent;
 use URI;

C4/Serials/Frequency.pm

@@ -18,6 +18,7 @@ package C4::Frequency;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::SQLHelper qw<:all>;
 use C4::Debug;

C4/Serials/NumberPattern.pm

@@ -18,6 +18,7 @@ package C4::Numberpattern;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::SQLHelper qw<:all>;
 use C4::Debug;

C4/Suggestions.pm

@@ -19,6 +19,7 @@ package C4::Suggestions;
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 
 use C4::Context;

C4/UploadedFile.pm

@@ -19,6 +19,7 @@ package C4::UploadedFile;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Auth qw/get_session/;
 use IO::File;

C4/XISBN.pm

@@ -27,6 +27,7 @@ use LWP::UserAgent;
 use HTTP::Request::Common;
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS);
 
 BEGIN {

C4/Z3950.pm

@@ -25,6 +25,7 @@ package C4::Z3950;
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 # standard or CPAN modules used
 use DBI;

C4/tests/Record_test.pl

@@ -19,7 +19,8 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 #
 #
-use strict; use warnings; #FIXME: turn off warnings before release
+use strict;
+use warnings;
 
 # specify the number of tests
 use Test::More tests => 23;

acqui/booksellers.pl

@@ -53,6 +53,7 @@ the C<basket> we have to close if op is equal to 'close'.
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use C4::Biblio;
 use C4::Output;

acqui/check_budget_total.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

acqui/fetch_sort_dropbox.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

acqui/histsearch.pl

@@ -48,6 +48,7 @@ to filter on ended date.
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Auth;    # get_template_and_user
 use C4::Output;

acqui/neworderbiblio.pl

@@ -56,6 +56,7 @@ the basket number to know on which basket this script have to add a new order.
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Search;
 use CGI;

acqui/newordersuggestion.pl

@@ -87,6 +87,7 @@ can be equal to
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use CGI;
 use C4::Auth;    # get_template_and_user

acqui/orderreceive.pl

@@ -57,7 +57,7 @@ The biblionumber of this order.
 =cut
 
 use strict;
-# use warnings;  # FIXME
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Koha;   # GetKohaAuthorisedValues GetItemTypes

acqui/parcel.pl

@@ -52,6 +52,8 @@ To filter the results list on this given date.
 
 =cut
 
+use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use C4::Acquisition;
 use C4::Budgets;
@@ -63,8 +65,6 @@ use C4::Output;
 use C4::Dates qw/format_date format_date_in_iso/;
 use JSON;
 
-use strict;
-
 my $input=new CGI;
 my $supplierid=$input->param('supplierid');
 my $bookseller=GetBookSellerFromId($supplierid);

acqui/updatesupplier.pl

@@ -44,13 +44,14 @@ list_currency, gst, list_gst, invoice_gst, discount, gstrate.
 =back
 
 =cut
+use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 use C4::Auth;
 use C4::Bookseller;
 use C4::Biblio;
 use C4::Output;
 use CGI;
-use strict;
 
 my $input=new CGI;
 my ($template, $loggedinuser, $cookie) = get_template_and_user(

admin/aqbudget_owner_search.pl

@@ -20,6 +20,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth ;
 use C4::Output;
 use CGI;

admin/aqbudgetperiods.pl

@@ -42,6 +42,7 @@ script to administer the budget periods table
 
 ## modules
 use strict;
+#use warnings; FIXME - Bug 2505
 use Number::Format qw(format_price);
 use CGI;
 use List::Util qw/min/;

admin/aqbudgets.pl

@@ -20,6 +20,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use List::Util qw/min/;
 use Number::Format qw(format_price);

admin/aqplan.pl

@@ -21,6 +21,7 @@
 # This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html)
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use List::Util qw/min/;
 use Date::Calc qw/Delta_YMD Easter_Sunday Today Decode_Date_EU/;

admin/auth_subfields_structure.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Output;
 use C4::Auth;
 use CGI;

admin/auth_tag_structure.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Auth;
 use C4::Koha;

admin/categorie.pl

@@ -37,6 +37,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Auth;

admin/check_budget_parent.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

admin/check_parent_total.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

admin/checkmarc.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Output;
 use C4::Auth;
 use CGI;

admin/classsources.pl

@@ -19,7 +19,7 @@
 #
 
 use strict;
-# use warnings; FIXME
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Auth;
 use C4::Context;

admin/clone-rules.pl

@@ -26,6 +26,7 @@
 # The script can be called with one of the parameters, both or none
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

admin/currency.pl

@@ -38,7 +38,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-# use warnings; # FIXME
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Auth;

admin/itemtypes.pl

@@ -41,6 +41,7 @@ written 20/02/2002 by paul.poulain@free.fr
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 
 use List::Util qw/min/;

admin/marc_subfields_structure.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Output;
 use C4::Auth;
 use CGI;

admin/patron-attr-types.pl

@@ -19,6 +19,7 @@
 #
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Auth;
 use C4::Context;

admin/printers.pl

@@ -38,6 +38,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

admin/smart-rules.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

admin/z3950servers.pl

@@ -20,6 +20,7 @@
 #	- we delete the record having primkey=$primkey
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Auth;

catalogue/ISBDdetail.pl

@@ -35,6 +35,7 @@ This script needs a biblionumber as parameter
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Auth;
 use C4::Context;

catalogue/MARCdetail.pl

@@ -44,6 +44,7 @@ the items attached to the biblio
 =cut
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Auth;
 use C4::Context;

catalogue/cardview.pl

@@ -1,5 +1,6 @@
 #!/usr/bin/perl
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use CGI;
 use XML::LibXSLT;

catalogue/detailprint.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Context;
 use CGI;

catalogue/export.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 use HTML::Template::Pro;
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use C4::Record;
 use C4::Auth;

catalogue/issuehistory.pl

@@ -17,6 +17,7 @@
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use CGI;
 use C4::Auth;

catalogue/moredetail.pl

@@ -19,6 +19,7 @@
 
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Koha;
 use CGI;
 use C4::Biblio;

catalogue/search.pl

@@ -132,6 +132,7 @@ Not yet completed...
 =cut
 
 use strict;            # always use
+#use warnings; FIXME - Bug 2505
 
 ## STEP 1. Load things that are used in both search page and
 # results page and decide which template to load, operations 

catalogue/showmarc.pl

@@ -25,6 +25,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 # standard or CPAN modules used
 use CGI qw(:standard);

catalogue/suggest.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use CGI;
 use C4::Auth;

cataloguing/addbiblio.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Output;
 use C4::Auth;

cataloguing/additem.pl

@@ -18,8 +18,9 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-use CGI;
 use strict;
+#use warnings; FIXME - Bug 2505
+use CGI;
 use C4::Auth;
 use C4::Output;
 use C4::Biblio;

cataloguing/merge.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Output;
 use C4::Auth;

cataloguing/merge_ajax.pl

@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 # standard or CPAN modules used
 use IO::File;

cataloguing/moveitem.pl

@@ -19,8 +19,9 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-use CGI;
 use strict;
+#use warnings; FIXME - Bug 2505
+use CGI;
 use C4::Auth;
 use C4::Output;
 use C4::Biblio;

cataloguing/plugin_launcher.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

cataloguing/value_builder/barcode.pl

@@ -19,7 +19,8 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-
+#use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 require C4::Dates;
 my $DEBUG = 0;

cataloguing/value_builder/dateaccessioned.pl

@@ -19,6 +19,9 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
+#use strict;
+#use warnings; FIXME - Bug 2505
+
 =head1
 
 plugin_parameters : useless here

cataloguing/value_builder/labs_theses.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 
 use CGI;
 

cataloguing/value_builder/macles.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use CGI;
 use C4::Context;
 use C4::Output;

cataloguing/value_builder/marc21_field_003.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 =head1

cataloguing/value_builder/marc21_field_005.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 =head1

cataloguing/value_builder/marc21_field_006.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use CGI;
 use C4::Context;

cataloguing/value_builder/marc21_field_007.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use CGI;
 use C4::Context;

cataloguing/value_builder/marc21_field_008.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use CGI;
 use C4::Context;

cataloguing/value_builder/marc21_field_008_authorities.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Auth;
 use CGI;
 use C4::Context;

cataloguing/value_builder/marc21_field_040c.pl

@@ -18,6 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 # use MARC::Record;
 

cataloguing/value_builder/marc21_field_040d.pl

@@ -19,6 +19,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 # use MARC::Record;
 

cataloguing/value_builder/marc21_field_245h.pl

@@ -19,6 +19,7 @@
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
+#use warnings; FIXME - Bug 2505
 use C4::Context;
 
 =head1