From 2121f6494bc1216202171057337b8522eb782aca Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 13:51:41 +1200 Subject: [PATCH 01/24] Bug 2505 - Add commented use warnings where missing in the errors/ directory --- errors/400.pl | 1 + errors/401.pl | 1 + errors/402.pl | 1 + errors/403.pl | 1 + errors/404.pl | 1 + errors/500.pl | 1 + 6 files changed, 6 insertions(+) diff --git a/errors/400.pl b/errors/400.pl index b04b7fdf73..f7ebf8a6c5 100755 --- a/errors/400.pl +++ b/errors/400.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/errors/401.pl b/errors/401.pl index 3ea459a0b1..0982c2fdd6 100755 --- a/errors/401.pl +++ b/errors/401.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/errors/402.pl b/errors/402.pl index 4bfe7cee90..c0b9783451 100755 --- a/errors/402.pl +++ b/errors/402.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/errors/403.pl b/errors/403.pl index 4058ce9ae7..e7759e021c 100755 --- a/errors/403.pl +++ b/errors/403.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/errors/404.pl b/errors/404.pl index 418723fead..b1fb9f9b03 100755 --- a/errors/404.pl +++ b/errors/404.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/errors/500.pl b/errors/500.pl index 6f570a251e..6ea9d96716 100755 --- a/errors/500.pl +++ b/errors/500.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; From b865ff624c48f5ca2f9c30c75be903c1fb90ebc0 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 14:32:36 +1200 Subject: [PATCH 02/24] Bug 2505 - Add commented use warnings where missing in the acqui/ directory --- acqui/booksellers.pl | 1 + acqui/check_budget_total.pl | 1 + acqui/fetch_sort_dropbox.pl | 1 + acqui/histsearch.pl | 1 + acqui/neworderbiblio.pl | 1 + acqui/newordersuggestion.pl | 1 + acqui/orderreceive.pl | 2 +- acqui/parcel.pl | 4 ++-- acqui/supplier.pl | 1 + acqui/updatesupplier.pl | 3 ++- 10 files changed, 12 insertions(+), 4 deletions(-) diff --git a/acqui/booksellers.pl b/acqui/booksellers.pl index 11aba49c30..7641e689e6 100755 --- a/acqui/booksellers.pl +++ b/acqui/booksellers.pl @@ -53,6 +53,7 @@ the C we have to close if op is equal to 'close'. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Biblio; use C4::Output; diff --git a/acqui/check_budget_total.pl b/acqui/check_budget_total.pl index f3a1363277..62e545359c 100755 --- a/acqui/check_budget_total.pl +++ b/acqui/check_budget_total.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/acqui/fetch_sort_dropbox.pl b/acqui/fetch_sort_dropbox.pl index 3a04621418..1bc9332016 100755 --- a/acqui/fetch_sort_dropbox.pl +++ b/acqui/fetch_sort_dropbox.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/acqui/histsearch.pl b/acqui/histsearch.pl index 016bb05913..0190e4a688 100755 --- a/acqui/histsearch.pl +++ b/acqui/histsearch.pl @@ -48,6 +48,7 @@ to filter on ended date. =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; # get_template_and_user use C4::Output; diff --git a/acqui/neworderbiblio.pl b/acqui/neworderbiblio.pl index c3f3396709..fcb4ffcde8 100755 --- a/acqui/neworderbiblio.pl +++ b/acqui/neworderbiblio.pl @@ -56,6 +56,7 @@ the basket number to know on which basket this script have to add a new order. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Search; use CGI; diff --git a/acqui/newordersuggestion.pl b/acqui/newordersuggestion.pl index 4697800f75..ba966b6620 100755 --- a/acqui/newordersuggestion.pl +++ b/acqui/newordersuggestion.pl @@ -87,6 +87,7 @@ can be equal to =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; # get_template_and_user diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl index b535af3e37..a1e6fce4b9 100755 --- a/acqui/orderreceive.pl +++ b/acqui/orderreceive.pl @@ -57,7 +57,7 @@ The biblionumber of this order. =cut use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Koha; # GetKohaAuthorisedValues GetItemTypes diff --git a/acqui/parcel.pl b/acqui/parcel.pl index f4a4b192f2..83fb45b509 100755 --- a/acqui/parcel.pl +++ b/acqui/parcel.pl @@ -52,6 +52,8 @@ To filter the results list on this given date. =cut +use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Acquisition; use C4::Budgets; @@ -63,8 +65,6 @@ use C4::Output; use C4::Dates qw/format_date format_date_in_iso/; use JSON; -use strict; - my $input=new CGI; my $supplierid=$input->param('supplierid'); my $bookseller=GetBookSellerFromId($supplierid); diff --git a/acqui/supplier.pl b/acqui/supplier.pl index e2d0a734c2..04bbe116c1 100755 --- a/acqui/supplier.pl +++ b/acqui/supplier.pl @@ -41,6 +41,7 @@ To know the bookseller this script has to display details. =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Acquisition; use C4::Contract; diff --git a/acqui/updatesupplier.pl b/acqui/updatesupplier.pl index 8348a00292..e324a2915c 100755 --- a/acqui/updatesupplier.pl +++ b/acqui/updatesupplier.pl @@ -44,13 +44,14 @@ list_currency, gst, list_gst, invoice_gst, discount, gstrate. =back =cut +use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Auth; use C4::Bookseller; use C4::Biblio; use C4::Output; use CGI; -use strict; my $input=new CGI; my ($template, $loggedinuser, $cookie) = get_template_and_user( From 0718cc8b6daf15f36d0aedb562a3e555a2ff9cf1 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 14:40:27 +1200 Subject: [PATCH 03/24] Bug 2505 - Add commented use warnings where missing in the members/ directory --- members/borrowers_details.pl | 1 + members/deletemem.pl | 2 +- members/guarantor_search.pl | 1 + members/member.pl | 1 + members/moremember.pl | 1 + members/notices.pl | 1 + members/update-child.pl | 1 + 7 files changed, 7 insertions(+), 1 deletion(-) diff --git a/members/borrowers_details.pl b/members/borrowers_details.pl index b01953f5d4..c861ad42c6 100755 --- a/members/borrowers_details.pl +++ b/members/borrowers_details.pl @@ -25,6 +25,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; diff --git a/members/deletemem.pl b/members/deletemem.pl index 0b85d5e1bc..81cb750177 100755 --- a/members/deletemem.pl +++ b/members/deletemem.pl @@ -22,7 +22,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; diff --git a/members/guarantor_search.pl b/members/guarantor_search.pl index 17af23da8b..d25d71f59e 100755 --- a/members/guarantor_search.pl +++ b/members/guarantor_search.pl @@ -21,6 +21,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Output; use CGI; diff --git a/members/member.pl b/members/member.pl index 39b8274675..aaa3c0e911 100755 --- a/members/member.pl +++ b/members/member.pl @@ -23,6 +23,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Output; use CGI; diff --git a/members/moremember.pl b/members/moremember.pl index 8d1f373cce..4d4d9bb406 100755 --- a/members/moremember.pl +++ b/members/moremember.pl @@ -32,6 +32,7 @@ =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth; diff --git a/members/notices.pl b/members/notices.pl index bd8786d74e..dea577e470 100755 --- a/members/notices.pl +++ b/members/notices.pl @@ -20,6 +20,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Output; use CGI; diff --git a/members/update-child.pl b/members/update-child.pl index b6ed131290..39e19a1f31 100755 --- a/members/update-child.pl +++ b/members/update-child.pl @@ -27,6 +27,7 @@ =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth; From f1598406e5f9425198f4ec42a372752b9cccf31a Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 14:47:08 +1200 Subject: [PATCH 04/24] Bug 2505 - Add commented use warnings where missing in the reports/ directory --- reports/acquisitions_stats.pl | 1 + reports/bor_issues_top.pl | 1 + reports/borrowers_stats.pl | 1 + reports/cat_issues_top.pl | 1 + reports/catalogue_stats.pl | 2 +- reports/guided_reports.pl | 2 +- reports/issues_avg_stats.pl | 1 + reports/issues_stats.pl | 1 + reports/manager.pl | 1 + reports/reports-home.pl | 1 + reports/reservereport.pl | 1 + reports/stats.print.pl | 1 + reports/stats.screen.pl | 1 + 13 files changed, 13 insertions(+), 2 deletions(-) diff --git a/reports/acquisitions_stats.pl b/reports/acquisitions_stats.pl index fe038be008..6c29e47802 100755 --- a/reports/acquisitions_stats.pl +++ b/reports/acquisitions_stats.pl @@ -21,6 +21,7 @@ # test comment use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl index 8cc13bec83..0290ab062a 100755 --- a/reports/bor_issues_top.pl +++ b/reports/bor_issues_top.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/reports/borrowers_stats.pl b/reports/borrowers_stats.pl index cec510d3e6..f44c20ede3 100755 --- a/reports/borrowers_stats.pl +++ b/reports/borrowers_stats.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; diff --git a/reports/cat_issues_top.pl b/reports/cat_issues_top.pl index 7f82c8495b..d7f2e443f4 100755 --- a/reports/cat_issues_top.pl +++ b/reports/cat_issues_top.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl index 6c368f0f78..5f865f308e 100755 --- a/reports/catalogue_stats.pl +++ b/reports/catalogue_stats.pl @@ -19,7 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index 9c0998d76a..d519423275 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -18,7 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use Text::CSV; use C4::Reports::Guided; diff --git a/reports/issues_avg_stats.pl b/reports/issues_avg_stats.pl index fa35606dec..678495f72b 100755 --- a/reports/issues_avg_stats.pl +++ b/reports/issues_avg_stats.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl index 748105f4ff..d1c0a04213 100755 --- a/reports/issues_stats.pl +++ b/reports/issues_stats.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use Date::Manip; diff --git a/reports/manager.pl b/reports/manager.pl index 133c099d12..4ca5595f66 100755 --- a/reports/manager.pl +++ b/reports/manager.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; diff --git a/reports/reports-home.pl b/reports/reports-home.pl index 0b849e9aeb..8fc47cbe1c 100755 --- a/reports/reports-home.pl +++ b/reports/reports-home.pl @@ -17,6 +17,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/reports/reservereport.pl b/reports/reservereport.pl index 4f8a427d44..67f384cc12 100755 --- a/reports/reservereport.pl +++ b/reports/reservereport.pl @@ -24,6 +24,7 @@ # eg: http://koha.rangitikei.katipo.co.nz/cgi-bin/koha/reports/reservereport.pl?branch=BL use strict; +#use warnings; FIXME - Bug 2505 use C4::Stats; use C4::Dates qw/format_date/; use CGI; diff --git a/reports/stats.print.pl b/reports/stats.print.pl index 1d89520fc0..066aafa4b6 100755 --- a/reports/stats.print.pl +++ b/reports/stats.print.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; diff --git a/reports/stats.screen.pl b/reports/stats.screen.pl index 862c2a232c..1d3eaef332 100755 --- a/reports/stats.screen.pl +++ b/reports/stats.screen.pl @@ -16,6 +16,7 @@ # Suite 330, Boston, MA 02111-1307 USA use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; use C4::Auth; From 1e2faa91192302bde210e149963b42e8cfa8f97b Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 14:52:03 +1200 Subject: [PATCH 05/24] Bug 2505 - Add commented use warnings where missing in the circ/ directory --- circ/bookcount.pl | 2 +- circ/branchoverdues.pl | 2 +- circ/circulation-home.pl | 1 + circ/circulation.pl | 2 +- circ/hold-transfer-slip.pl | 1 + circ/pendingreserves.pl | 1 + circ/returns.pl | 2 +- circ/stats.pl | 2 +- circ/ysearch.pl | 1 + 9 files changed, 9 insertions(+), 5 deletions(-) diff --git a/circ/bookcount.pl b/circ/bookcount.pl index 7590ec0947..2ae4f4a3a3 100755 --- a/circ/bookcount.pl +++ b/circ/bookcount.pl @@ -21,7 +21,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Debug; use C4::Context; diff --git a/circ/branchoverdues.pl b/circ/branchoverdues.pl index a33d836226..905af94396 100755 --- a/circ/branchoverdues.pl +++ b/circ/branchoverdues.pl @@ -17,7 +17,7 @@ # Suite 330, Boston, MA 02111-1307 USA use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use C4::Context; use CGI; use C4::Output; diff --git a/circ/circulation-home.pl b/circ/circulation-home.pl index 2ebd0d06dc..e4aef3b199 100755 --- a/circ/circulation-home.pl +++ b/circ/circulation-home.pl @@ -17,6 +17,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/circ/circulation.pl b/circ/circulation.pl index ee13b9d89f..4b679208d2 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -21,7 +21,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; use C4::Print; diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl index fa75d107d1..f581464bfd 100755 --- a/circ/hold-transfer-slip.pl +++ b/circ/hold-transfer-slip.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Output; use CGI; diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl index 416e690410..cf71094830 100755 --- a/circ/pendingreserves.pl +++ b/circ/pendingreserves.pl @@ -24,6 +24,7 @@ # The reserve pull lists *works* as long as not for indepencdant branches, I can fix! use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Output; use CGI; diff --git a/circ/returns.pl b/circ/returns.pl index e3f6bb2057..261109962b 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -26,7 +26,7 @@ script to execute returns of books =cut use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; diff --git a/circ/stats.pl b/circ/stats.pl index 827bc540fc..558a985c96 100755 --- a/circ/stats.pl +++ b/circ/stats.pl @@ -22,7 +22,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/circ/ysearch.pl b/circ/ysearch.pl index 9c3dc3d5b9..f8fc52a885 100755 --- a/circ/ysearch.pl +++ b/circ/ysearch.pl @@ -25,6 +25,7 @@ =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth qw/check_cookie_auth/; From bce3e2e619e3efffdd01caf560ce53a8ba903df2 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:00:19 +1200 Subject: [PATCH 06/24] Bug 2505 - Add commented use warnings where missing in the admin/ directory --- admin/aqbudget_owner_search.pl | 1 + admin/aqbudgetperiods.pl | 1 + admin/aqbudgets.pl | 1 + admin/aqplan.pl | 1 + admin/auth_subfields_structure.pl | 1 + admin/auth_tag_structure.pl | 1 + admin/categorie.pl | 1 + admin/check_budget_parent.pl | 1 + admin/check_parent_total.pl | 1 + admin/checkmarc.pl | 1 + admin/classsources.pl | 2 +- admin/clone-rules.pl | 1 + admin/currency.pl | 2 +- admin/itemtypes.pl | 1 + admin/marc_subfields_structure.pl | 1 + admin/patron-attr-types.pl | 1 + admin/printers.pl | 1 + admin/smart-rules.pl | 1 + admin/z3950servers.pl | 1 + 19 files changed, 19 insertions(+), 2 deletions(-) diff --git a/admin/aqbudget_owner_search.pl b/admin/aqbudget_owner_search.pl index d583d4fa3d..69e465fbde 100755 --- a/admin/aqbudget_owner_search.pl +++ b/admin/aqbudget_owner_search.pl @@ -20,6 +20,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth ; use C4::Output; use CGI; diff --git a/admin/aqbudgetperiods.pl b/admin/aqbudgetperiods.pl index 68501b0df0..62383f1937 100755 --- a/admin/aqbudgetperiods.pl +++ b/admin/aqbudgetperiods.pl @@ -42,6 +42,7 @@ script to administer the budget periods table ## modules use strict; +#use warnings; FIXME - Bug 2505 use Number::Format qw(format_price); use CGI; use List::Util qw/min/; diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl index 8d7bab75ab..35c8bc6970 100755 --- a/admin/aqbudgets.pl +++ b/admin/aqbudgets.pl @@ -20,6 +20,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use List::Util qw/min/; use Number::Format qw(format_price); diff --git a/admin/aqplan.pl b/admin/aqplan.pl index 51983b9b11..55367ef746 100755 --- a/admin/aqplan.pl +++ b/admin/aqplan.pl @@ -21,6 +21,7 @@ # This software is placed under the gnu General Public License, v2 (http://www.gnu.org/licenses/gpl.html) use strict; +#use warnings; FIXME - Bug 2505 use CGI; use List::Util qw/min/; use Date::Calc qw/Delta_YMD Easter_Sunday Today Decode_Date_EU/; diff --git a/admin/auth_subfields_structure.pl b/admin/auth_subfields_structure.pl index 12184e8a0a..cee3312c34 100755 --- a/admin/auth_subfields_structure.pl +++ b/admin/auth_subfields_structure.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Output; use C4::Auth; use CGI; diff --git a/admin/auth_tag_structure.pl b/admin/auth_tag_structure.pl index 645916de3a..6314c0acfc 100755 --- a/admin/auth_tag_structure.pl +++ b/admin/auth_tag_structure.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Koha; diff --git a/admin/categorie.pl b/admin/categorie.pl index b7f4feab7c..d804fe6b0f 100755 --- a/admin/categorie.pl +++ b/admin/categorie.pl @@ -37,6 +37,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth; diff --git a/admin/check_budget_parent.pl b/admin/check_budget_parent.pl index 5e637bd5dc..810e11711d 100755 --- a/admin/check_budget_parent.pl +++ b/admin/check_budget_parent.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl index ce26f5ef49..76b3e9a60d 100755 --- a/admin/check_parent_total.pl +++ b/admin/check_parent_total.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/admin/checkmarc.pl b/admin/checkmarc.pl index c11093543e..ca91164cde 100755 --- a/admin/checkmarc.pl +++ b/admin/checkmarc.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Output; use C4::Auth; use CGI; diff --git a/admin/classsources.pl b/admin/classsources.pl index e3c9dfaa4d..45183cd15f 100755 --- a/admin/classsources.pl +++ b/admin/classsources.pl @@ -19,7 +19,7 @@ # use strict; -# use warnings; FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; diff --git a/admin/clone-rules.pl b/admin/clone-rules.pl index 7daa369056..dcf4abedbd 100755 --- a/admin/clone-rules.pl +++ b/admin/clone-rules.pl @@ -26,6 +26,7 @@ # The script can be called with one of the parameters, both or none use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/admin/currency.pl b/admin/currency.pl index 0d96bfebb8..5c34d51fd3 100755 --- a/admin/currency.pl +++ b/admin/currency.pl @@ -38,7 +38,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth; diff --git a/admin/itemtypes.pl b/admin/itemtypes.pl index 670dce5993..9876852bc4 100755 --- a/admin/itemtypes.pl +++ b/admin/itemtypes.pl @@ -41,6 +41,7 @@ written 20/02/2002 by paul.poulain@free.fr =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use List::Util qw/min/; diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl index 7030a214ef..bae9c6501e 100755 --- a/admin/marc_subfields_structure.pl +++ b/admin/marc_subfields_structure.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Output; use C4::Auth; use CGI; diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl index 5bb6556424..f8c641d311 100755 --- a/admin/patron-attr-types.pl +++ b/admin/patron-attr-types.pl @@ -19,6 +19,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; diff --git a/admin/printers.pl b/admin/printers.pl index bb85aceec4..c32b4e6b57 100755 --- a/admin/printers.pl +++ b/admin/printers.pl @@ -38,6 +38,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl index ccfc031548..fdd9b9132b 100755 --- a/admin/smart-rules.pl +++ b/admin/smart-rules.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/admin/z3950servers.pl b/admin/z3950servers.pl index be7cae5d17..44b3967f7a 100755 --- a/admin/z3950servers.pl +++ b/admin/z3950servers.pl @@ -20,6 +20,7 @@ # - we delete the record having primkey=$primkey use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Auth; From 2587115062843bcc3c7561d6ad380e1360ca7f24 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:13:29 +1200 Subject: [PATCH 07/24] Bug 2505 - Add commented use warnings where missing in the suggestion/ directory --- suggestion/suggestion.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index 9811cc8604..ce79197098 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -16,6 +16,7 @@ # Suite 330, Boston, MA 02111-1307 USA use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use CGI; use C4::Auth; # get_template_and_user From 3eb648943fa3d72e6b2116324f10671bb42e5793 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:14:43 +1200 Subject: [PATCH 08/24] Bug 2505 - Add commented use warnings where missing in the virtualshelves/ directory --- virtualshelves/addbybiblionumber.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/virtualshelves/addbybiblionumber.pl b/virtualshelves/addbybiblionumber.pl index b636c1226f..d53a8c4e82 100755 --- a/virtualshelves/addbybiblionumber.pl +++ b/virtualshelves/addbybiblionumber.pl @@ -59,6 +59,7 @@ =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Biblio; use CGI; use C4::Output; From 91c7bb791f6837ce244980c96d4d1abfefc3c5dd Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:25:50 +1200 Subject: [PATCH 09/24] Bug 2505 - Add commented use warnings where missing in the opac/ directory --- opac/changelanguage.pl | 3 +++ opac/opac-user.pl | 1 + 2 files changed, 4 insertions(+) diff --git a/opac/changelanguage.pl b/opac/changelanguage.pl index 9a470aef64..16ef6d0f22 100755 --- a/opac/changelanguage.pl +++ b/opac/changelanguage.pl @@ -15,6 +15,9 @@ # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Suite 330, Boston, MA 02111-1307 USA +#use strict; +#use warnings; FIXME - Bug 2505 + use C4::Output; use CGI; diff --git a/opac/opac-user.pl b/opac/opac-user.pl index 772b7f34d0..634b77a9db 100755 --- a/opac/opac-user.pl +++ b/opac/opac-user.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; From f06ff3a86bfb8afb90e4d5ce3f08bc39c63168f8 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:27:11 +1200 Subject: [PATCH 10/24] Bug 2505 - Add commented use warnings where missing in the sms/ directory --- sms/sms.pl | 1 + sms/sms_listen_windows_start.pl | 1 + 2 files changed, 2 insertions(+) diff --git a/sms/sms.pl b/sms/sms.pl index 230aa90426..02a0c6cded 100755 --- a/sms/sms.pl +++ b/sms/sms.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::SMS; use C4::Output; diff --git a/sms/sms_listen_windows_start.pl b/sms/sms_listen_windows_start.pl index b9f706b56b..c0e39d5d9b 100755 --- a/sms/sms_listen_windows_start.pl +++ b/sms/sms_listen_windows_start.pl @@ -2,6 +2,7 @@ # script that starts the zebraqueue # Written by TG on 01/08/2006 use strict; +#use warnings; FIXME - Bug 2505 use Win32::Process; use Win32; From b31b5f3620552da4ae4de83f7a14fd18f1110cd2 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:39:44 +1200 Subject: [PATCH 11/24] Bug 2505 - Add commented use warnings where missing in the catalogue/ directory --- catalogue/ISBDdetail.pl | 1 + catalogue/MARCdetail.pl | 1 + catalogue/cardview.pl | 1 + catalogue/detailprint.pl | 1 + catalogue/export.pl | 1 + catalogue/issuehistory.pl | 1 + catalogue/moredetail.pl | 1 + catalogue/search.pl | 1 + catalogue/showmarc.pl | 1 + catalogue/suggest.pl | 1 + 10 files changed, 10 insertions(+) diff --git a/catalogue/ISBDdetail.pl b/catalogue/ISBDdetail.pl index 0b6419d75d..40a434d37c 100755 --- a/catalogue/ISBDdetail.pl +++ b/catalogue/ISBDdetail.pl @@ -35,6 +35,7 @@ This script needs a biblionumber as parameter =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Context; diff --git a/catalogue/MARCdetail.pl b/catalogue/MARCdetail.pl index a7a81b84ed..65475674e0 100755 --- a/catalogue/MARCdetail.pl +++ b/catalogue/MARCdetail.pl @@ -44,6 +44,7 @@ the items attached to the biblio =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Context; diff --git a/catalogue/cardview.pl b/catalogue/cardview.pl index a88d2962c7..f93323f5fb 100755 --- a/catalogue/cardview.pl +++ b/catalogue/cardview.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use CGI; use XML::LibXSLT; diff --git a/catalogue/detailprint.pl b/catalogue/detailprint.pl index a69b0463d0..41d346fb61 100755 --- a/catalogue/detailprint.pl +++ b/catalogue/detailprint.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use CGI; diff --git a/catalogue/export.pl b/catalogue/export.pl index 0093ce0f92..f6f02d7688 100755 --- a/catalogue/export.pl +++ b/catalogue/export.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use HTML::Template::Pro; use strict; +#use warnings; FIXME - Bug 2505 use C4::Record; use C4::Auth; diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl index 8790bb5580..a6f12c37c8 100755 --- a/catalogue/issuehistory.pl +++ b/catalogue/issuehistory.pl @@ -17,6 +17,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; diff --git a/catalogue/moredetail.pl b/catalogue/moredetail.pl index 66873d8b41..d790c41987 100755 --- a/catalogue/moredetail.pl +++ b/catalogue/moredetail.pl @@ -19,6 +19,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use C4::Koha; use CGI; use C4::Biblio; diff --git a/catalogue/search.pl b/catalogue/search.pl index c20cf3c633..ba0d044a38 100755 --- a/catalogue/search.pl +++ b/catalogue/search.pl @@ -132,6 +132,7 @@ Not yet completed... =cut use strict; # always use +#use warnings; FIXME - Bug 2505 ## STEP 1. Load things that are used in both search page and # results page and decide which template to load, operations diff --git a/catalogue/showmarc.pl b/catalogue/showmarc.pl index 2a9eb9222a..8627641a9a 100755 --- a/catalogue/showmarc.pl +++ b/catalogue/showmarc.pl @@ -25,6 +25,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use CGI qw(:standard); diff --git a/catalogue/suggest.pl b/catalogue/suggest.pl index a5154bbc4b..c348c76fb0 100755 --- a/catalogue/suggest.pl +++ b/catalogue/suggest.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; From d5c8104389e2f916f68857f38db268a79dd19fc1 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:40:32 +1200 Subject: [PATCH 12/24] Bug 2505 - Add commented use warnings where missing in the serials/ directory --- serials/reorder_members.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl index 224a37af14..c42823df9c 100755 --- a/serials/reorder_members.pl +++ b/serials/reorder_members.pl @@ -20,6 +20,7 @@ # where the hierarchical order can be changed on the fly and a routing list can be # printed out use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Context; From a7cf73fc7c7a8e4edf7baaeb3564777285b5e59b Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:42:23 +1200 Subject: [PATCH 13/24] Bug 2505 - Add commented use warnings where missing in the C4/ directory --- C4/SIP/xmlparse.pl | 1 + C4/tests/Record_test.pl | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/C4/SIP/xmlparse.pl b/C4/SIP/xmlparse.pl index 6a0b64e0c4..6496c609a1 100755 --- a/C4/SIP/xmlparse.pl +++ b/C4/SIP/xmlparse.pl @@ -7,6 +7,7 @@ # in Sip::Configuration.pm # use strict; +#use warnings; FIXME - Bug 2505 use English; use XML::Simple qw(:strict); diff --git a/C4/tests/Record_test.pl b/C4/tests/Record_test.pl index 9729e32032..f7a65ab0f9 100755 --- a/C4/tests/Record_test.pl +++ b/C4/tests/Record_test.pl @@ -19,7 +19,8 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. # # -use strict; use warnings; #FIXME: turn off warnings before release +use strict; +use warnings; # specify the number of tests use Test::More tests => 23; From e5bb64c1c1bfcb16786654995a04f566862944fd Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:44:39 +1200 Subject: [PATCH 14/24] Bug 2505 - Add commented use warnings where missing in the rotating_collections/ directory --- rotating_collections/addItems.pl | 1 + rotating_collections/editCollections.pl | 1 + rotating_collections/rotatingCollections.pl | 1 + rotating_collections/transferCollection.pl | 1 + 4 files changed, 4 insertions(+) diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl index 5c93b1382d..acde79aab4 100755 --- a/rotating_collections/addItems.pl +++ b/rotating_collections/addItems.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use C4::Output; diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl index 1dba296352..6289cac42b 100755 --- a/rotating_collections/editCollections.pl +++ b/rotating_collections/editCollections.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use CGI; diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl index 7940ebf238..b085e6b810 100755 --- a/rotating_collections/rotatingCollections.pl +++ b/rotating_collections/rotatingCollections.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use CGI; diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl index 6ca822c8d8..e2c5407db7 100755 --- a/rotating_collections/transferCollection.pl +++ b/rotating_collections/transferCollection.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use C4::Output; From b44f8e1a3194abf25900a40cf78891f2b0b5c61c Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:47:30 +1200 Subject: [PATCH 15/24] Bug 2505 - Add commented use warnings where missing in the installer/ directory --- installer/data/mysql/atomicupdate/subscription_add_enddate.pl | 2 ++ installer/data/mysql/labels_upgrade.pl | 3 +++ installer/data/mysql/patroncards_upgrade.pl | 3 +++ installer/data/mysql/update22to30.pl | 1 + 4 files changed, 9 insertions(+) diff --git a/installer/data/mysql/atomicupdate/subscription_add_enddate.pl b/installer/data/mysql/atomicupdate/subscription_add_enddate.pl index 8f8c23038b..b8074b1dee 100755 --- a/installer/data/mysql/atomicupdate/subscription_add_enddate.pl +++ b/installer/data/mysql/atomicupdate/subscription_add_enddate.pl @@ -1,4 +1,6 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; my $dbh=C4::Context->dbh; $dbh->do("ALTER TABLE `subscription` ADD `enddate` date default NULL"); diff --git a/installer/data/mysql/labels_upgrade.pl b/installer/data/mysql/labels_upgrade.pl index 4d2a56feee..4fb7829434 100755 --- a/installer/data/mysql/labels_upgrade.pl +++ b/installer/data/mysql/labels_upgrade.pl @@ -17,6 +17,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +#use strict; +#use warnings; FIXME - Bug 2505 + use C4::Context; my $sth = C4::Context->dbh; diff --git a/installer/data/mysql/patroncards_upgrade.pl b/installer/data/mysql/patroncards_upgrade.pl index 5b136590cc..a9f4ce5292 100755 --- a/installer/data/mysql/patroncards_upgrade.pl +++ b/installer/data/mysql/patroncards_upgrade.pl @@ -17,6 +17,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +#use strict; +#use warnings; FIXME - Bug 2505 + use C4::Context; my $sth = C4::Context->dbh; diff --git a/installer/data/mysql/update22to30.pl b/installer/data/mysql/update22to30.pl index 435d767f86..cb4379b67b 100755 --- a/installer/data/mysql/update22to30.pl +++ b/installer/data/mysql/update22to30.pl @@ -12,6 +12,7 @@ # NOTE: If you do something more than once in here, make it table driven. use strict; +#use warnings; FIXME - Bug 2505 # CPAN modules use DBI; From 44201a54e15f06d13c2f40d93bd5a76f6493d7d2 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 15:54:32 +1200 Subject: [PATCH 16/24] Bug 2505 - Add commented use warnings where missing in the tools/ directory --- tools/background-job-progress.pl | 1 + tools/batchMod.pl | 1 + tools/cleanborrowers.pl | 1 + tools/csv-profiles.pl | 1 + tools/koha-news.pl | 1 + tools/pdfViewer.pl | 1 + tools/picture-upload.pl | 3 +++ tools/scheduler.pl | 1 + tools/stage-marc-import.pl | 1 + tools/upload-file-progress.pl | 1 + tools/upload-file.pl | 1 + tools/viewlog.pl | 1 + 12 files changed, 14 insertions(+) diff --git a/tools/background-job-progress.pl b/tools/background-job-progress.pl index cd8a0651a0..db4d890497 100755 --- a/tools/background-job-progress.pl +++ b/tools/background-job-progress.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use IO::File; diff --git a/tools/batchMod.pl b/tools/batchMod.pl index 2d284d64d4..6c3caf8382 100755 --- a/tools/batchMod.pl +++ b/tools/batchMod.pl @@ -20,6 +20,7 @@ use CGI; use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use C4::Output; use C4::Biblio; diff --git a/tools/cleanborrowers.pl b/tools/cleanborrowers.pl index 1a6c9bc251..4fde0f2b5e 100755 --- a/tools/cleanborrowers.pl +++ b/tools/cleanborrowers.pl @@ -33,6 +33,7 @@ This script allows to do 2 things. =cut use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Output; diff --git a/tools/csv-profiles.pl b/tools/csv-profiles.pl index 7aafc92623..6f467ee5cd 100755 --- a/tools/csv-profiles.pl +++ b/tools/csv-profiles.pl @@ -35,6 +35,7 @@ This script allow the user to define a new profile for CSV export =cut use strict; +#use warnings; FIXME - Bug 2505 use Data::Dumper; use Encode; diff --git a/tools/koha-news.pl b/tools/koha-news.pl index cc70172467..ff4a32f323 100755 --- a/tools/koha-news.pl +++ b/tools/koha-news.pl @@ -22,6 +22,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; use C4::Koha; diff --git a/tools/pdfViewer.pl b/tools/pdfViewer.pl index 3ca61a815f..6a3549a446 100755 --- a/tools/pdfViewer.pl +++ b/tools/pdfViewer.pl @@ -23,6 +23,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use CGI; diff --git a/tools/picture-upload.pl b/tools/picture-upload.pl index c3f7b00e05..d21b6b0330 100755 --- a/tools/picture-upload.pl +++ b/tools/picture-upload.pl @@ -19,6 +19,9 @@ # # +#use strict; +#use warnings; FIXME - Bug 2505 + use File::Temp; use File::Copy; use CGI; diff --git a/tools/scheduler.pl b/tools/scheduler.pl index 9490301079..4d732db3a5 100755 --- a/tools/scheduler.pl +++ b/tools/scheduler.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Scheduler; use C4::Reports::Guided; diff --git a/tools/stage-marc-import.pl b/tools/stage-marc-import.pl index 2cd77c5d68..cc15f47cbc 100755 --- a/tools/stage-marc-import.pl +++ b/tools/stage-marc-import.pl @@ -25,6 +25,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use CGI; diff --git a/tools/upload-file-progress.pl b/tools/upload-file-progress.pl index 5e61d0ed6e..e3a643b4a4 100755 --- a/tools/upload-file-progress.pl +++ b/tools/upload-file-progress.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use IO::File; diff --git a/tools/upload-file.pl b/tools/upload-file.pl index 6b1fabbce3..1f38d076eb 100755 --- a/tools/upload-file.pl +++ b/tools/upload-file.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use IO::File; diff --git a/tools/viewlog.pl b/tools/viewlog.pl index d2e0b37acf..48804517fe 100755 --- a/tools/viewlog.pl +++ b/tools/viewlog.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; From 5e0b850d49f452ffbca41f47dc190d6d4f2323c7 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Fri, 16 Apr 2010 16:18:23 +1200 Subject: [PATCH 17/24] Bug 2505 - Add commented use warnings where missing in the misc/ directory --- misc/batchCompareMARCvsFrameworks.pl | 1 + misc/batchDeleteUnusedSubfields.pl | 1 + misc/batchImportMARCWithBiblionumbers.pl | 1 + misc/batchRebuildBiblioTables.pl | 2 +- misc/batchupdateISBNs.pl | 1 + misc/bin/zebraqueue_daemon.pl | 1 + misc/check_sysprefs.pl | 3 +++ misc/commit_biblios_file.pl | 1 + misc/cronjobs/build_browser_and_cloud.pl | 1 + misc/cronjobs/fines.pl | 1 + misc/cronjobs/holds/cancel_expired_holds.pl | 3 +++ misc/cronjobs/j2a.pl | 1 + misc/cronjobs/notifyMailsOp.pl | 1 + misc/cronjobs/smsoverdues.pl | 3 +++ misc/cronjobs/zebraqueue_start.pl | 1 + misc/exportauth.pl | 1 + misc/kohalib.pl | 1 + misc/link_bibs_to_authorities.pl | 1 + misc/maintenance/sync_items_in_marc_bib.pl | 1 + misc/migration_tools/22_to_30/export_Authorities.pl | 2 ++ misc/migration_tools/22_to_30/export_Authorities_xml.pl | 2 ++ misc/migration_tools/22_to_30/missing090field.pl | 1 + misc/migration_tools/22_to_30/move_marc_to_authheader.pl | 3 ++- misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl | 3 ++- misc/migration_tools/22_to_30/rebuild_leader.pl | 1 + misc/migration_tools/22_to_30/rebuild_unimarc_100.pl | 1 + misc/migration_tools/build6xx.pl | 1 + misc/migration_tools/buildCOUNTRY.pl | 1 + misc/migration_tools/buildEDITORS.pl | 1 + misc/migration_tools/buildLANG.pl | 1 + misc/migration_tools/bulkauthimport.pl | 1 + misc/migration_tools/fix_onloan.pl | 3 ++- misc/migration_tools/merge_authority.pl | 1 + misc/migration_tools/rebuild_nozebra.pl | 1 + misc/migration_tools/rebuild_zebra.pl | 1 + misc/migration_tools/upgradeitems.pl | 3 ++- misc/perlmodule_ls.pl | 3 +++ misc/sax_parser_test.pl | 2 ++ misc/stage_biblios_file.pl | 1 + misc/translator/stats.pl | 2 ++ misc/translator/text-extract.pl | 2 ++ misc/translator/text-extract2.pl | 3 ++- misc/translator/tmpl_process3.pl | 1 + 43 files changed, 61 insertions(+), 6 deletions(-) diff --git a/misc/batchCompareMARCvsFrameworks.pl b/misc/batchCompareMARCvsFrameworks.pl index b0ed79736b..9bbcde46df 100755 --- a/misc/batchCompareMARCvsFrameworks.pl +++ b/misc/batchCompareMARCvsFrameworks.pl @@ -3,6 +3,7 @@ use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/batchDeleteUnusedSubfields.pl b/misc/batchDeleteUnusedSubfields.pl index eca83ddefe..a0ecb5cece 100755 --- a/misc/batchDeleteUnusedSubfields.pl +++ b/misc/batchDeleteUnusedSubfields.pl @@ -2,6 +2,7 @@ # small script that rebuilds the non-MARC DB use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/batchImportMARCWithBiblionumbers.pl b/misc/batchImportMARCWithBiblionumbers.pl index a1bf26eb74..4acc02b116 100755 --- a/misc/batchImportMARCWithBiblionumbers.pl +++ b/misc/batchImportMARCWithBiblionumbers.pl @@ -2,6 +2,7 @@ # load records that already have biblionumber set into a koha system # Written by TG on 10/04/2006 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/batchRebuildBiblioTables.pl b/misc/batchRebuildBiblioTables.pl index 8e1c3aca3e..b15a91ade7 100755 --- a/misc/batchRebuildBiblioTables.pl +++ b/misc/batchRebuildBiblioTables.pl @@ -3,7 +3,7 @@ # Formerly named rebuildnonmarc.pl use strict; -# use warnings; FIXME someday +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules diff --git a/misc/batchupdateISBNs.pl b/misc/batchupdateISBNs.pl index 03d5bba82f..8cc8c6ac20 100755 --- a/misc/batchupdateISBNs.pl +++ b/misc/batchupdateISBNs.pl @@ -24,6 +24,7 @@ =cut use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/bin/zebraqueue_daemon.pl b/misc/bin/zebraqueue_daemon.pl index 7e62c944e1..6181a94c03 100755 --- a/misc/bin/zebraqueue_daemon.pl +++ b/misc/bin/zebraqueue_daemon.pl @@ -3,6 +3,7 @@ # daemon to watch the zebraqueue and update zebra as needed use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/check_sysprefs.pl b/misc/check_sysprefs.pl index 06ed80644e..68238087e9 100755 --- a/misc/check_sysprefs.pl +++ b/misc/check_sysprefs.pl @@ -5,6 +5,9 @@ # export PERL5LIB # then ./check_sysprefs.pl path (if path is blank it will use .) +#use strict; +#use warnings; FIXME - Bug 2505 + use File::Find; use C4::Context; diff --git a/misc/commit_biblios_file.pl b/misc/commit_biblios_file.pl index 2f9851fe82..5e3010e7a3 100755 --- a/misc/commit_biblios_file.pl +++ b/misc/commit_biblios_file.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/build_browser_and_cloud.pl b/misc/cronjobs/build_browser_and_cloud.pl index e1873c816f..d3ead43c30 100755 --- a/misc/cronjobs/build_browser_and_cloud.pl +++ b/misc/cronjobs/build_browser_and_cloud.pl @@ -2,6 +2,7 @@ # small script that builds the tag cloud use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/fines.pl b/misc/cronjobs/fines.pl index 1d0cdc0e5d..73cdf9f81b 100755 --- a/misc/cronjobs/fines.pl +++ b/misc/cronjobs/fines.pl @@ -28,6 +28,7 @@ # FIXME: use FinesMode as described or change syspref description use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules diff --git a/misc/cronjobs/holds/cancel_expired_holds.pl b/misc/cronjobs/holds/cancel_expired_holds.pl index c14c261d2e..70a2f59284 100755 --- a/misc/cronjobs/holds/cancel_expired_holds.pl +++ b/misc/cronjobs/holds/cancel_expired_holds.pl @@ -17,6 +17,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +#use strict; +#use warnings; FIXME - Bug 2505 + BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/j2a.pl b/misc/cronjobs/j2a.pl index de648ca290..ec5d207d8f 100755 --- a/misc/cronjobs/j2a.pl +++ b/misc/cronjobs/j2a.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl #run nightly -- changes J to A on someone's 18th birthday use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/notifyMailsOp.pl b/misc/cronjobs/notifyMailsOp.pl index e44ab78ec6..630b1591c3 100755 --- a/misc/cronjobs/notifyMailsOp.pl +++ b/misc/cronjobs/notifyMailsOp.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/smsoverdues.pl b/misc/cronjobs/smsoverdues.pl index c2a691315f..f4dda399b2 100755 --- a/misc/cronjobs/smsoverdues.pl +++ b/misc/cronjobs/smsoverdues.pl @@ -27,6 +27,9 @@ # $Id: sendoverdues.pl,v 1.1.2.1 2007/03/26 22:38:09 tgarip1957 Exp $ +#use strict; +#use warnings; FIXME - Bug 2505 + BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/cronjobs/zebraqueue_start.pl b/misc/cronjobs/zebraqueue_start.pl index 52c8fe0ef7..ea84156793 100755 --- a/misc/cronjobs/zebraqueue_start.pl +++ b/misc/cronjobs/zebraqueue_start.pl @@ -2,6 +2,7 @@ # script that starts the zebraquee # Written by TG on 01/08/2006 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/exportauth.pl b/misc/exportauth.pl index 52a0ec8971..4ac916c4d0 100755 --- a/misc/exportauth.pl +++ b/misc/exportauth.pl @@ -4,6 +4,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/kohalib.pl b/misc/kohalib.pl index b5e1f191be..e0add492b0 100755 --- a/misc/kohalib.pl +++ b/misc/kohalib.pl @@ -39,6 +39,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 my $module_dir; BEGIN { diff --git a/misc/link_bibs_to_authorities.pl b/misc/link_bibs_to_authorities.pl index 9954fd66bf..e3f9bdc824 100755 --- a/misc/link_bibs_to_authorities.pl +++ b/misc/link_bibs_to_authorities.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/maintenance/sync_items_in_marc_bib.pl b/misc/maintenance/sync_items_in_marc_bib.pl index af89769a89..d3eb2efe95 100755 --- a/misc/maintenance/sync_items_in_marc_bib.pl +++ b/misc/maintenance/sync_items_in_marc_bib.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/22_to_30/export_Authorities.pl b/misc/migration_tools/22_to_30/export_Authorities.pl index 8327cf7805..aeed3f2fa0 100755 --- a/misc/migration_tools/22_to_30/export_Authorities.pl +++ b/misc/migration_tools/22_to_30/export_Authorities.pl @@ -1,4 +1,6 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/22_to_30/export_Authorities_xml.pl b/misc/migration_tools/22_to_30/export_Authorities_xml.pl index 635a4145f8..70647ee7a1 100755 --- a/misc/migration_tools/22_to_30/export_Authorities_xml.pl +++ b/misc/migration_tools/22_to_30/export_Authorities_xml.pl @@ -1,4 +1,6 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/22_to_30/missing090field.pl b/misc/migration_tools/22_to_30/missing090field.pl index 648788ba18..aae803236d 100755 --- a/misc/migration_tools/22_to_30/missing090field.pl +++ b/misc/migration_tools/22_to_30/missing090field.pl @@ -3,6 +3,7 @@ # Written by TG on 01/10/2005 # Revised by Joshua Ferraro on 03/31/2006 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl b/misc/migration_tools/22_to_30/move_marc_to_authheader.pl index deffc7090d..2546da855b 100755 --- a/misc/migration_tools/22_to_30/move_marc_to_authheader.pl +++ b/misc/migration_tools/22_to_30/move_marc_to_authheader.pl @@ -2,6 +2,8 @@ # script to shift marc to biblioitems # scraped from updatedatabase for dev week by chris@katipo.co.nz +use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this @@ -13,7 +15,6 @@ use C4::AuthoritiesMarc; use MARC::Record; use MARC::File::XML ( BinaryEncoding => 'utf8' ); -use strict; print "moving MARC record to marc_header table\n"; my $dbh = C4::Context->dbh(); diff --git a/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl b/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl index 883af15f17..3635dbc386 100755 --- a/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl +++ b/misc/migration_tools/22_to_30/move_marc_to_biblioitems.pl @@ -1,5 +1,6 @@ #!/usr/bin/perl - +#use strict; +#use warnings; FIXME - Bug 2505 # script to shift marc to biblioitems # scraped from updatedatabase for dev week by chris@katipo.co.nz BEGIN { diff --git a/misc/migration_tools/22_to_30/rebuild_leader.pl b/misc/migration_tools/22_to_30/rebuild_leader.pl index 0ab0f07cf6..ded81b3730 100755 --- a/misc/migration_tools/22_to_30/rebuild_leader.pl +++ b/misc/migration_tools/22_to_30/rebuild_leader.pl @@ -3,6 +3,7 @@ # Written by TG on 01/10/2005 # Revised by Joshua Ferraro on 03/31/2006 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/22_to_30/rebuild_unimarc_100.pl b/misc/migration_tools/22_to_30/rebuild_unimarc_100.pl index 1ef4049fbd..320ced2684 100755 --- a/misc/migration_tools/22_to_30/rebuild_unimarc_100.pl +++ b/misc/migration_tools/22_to_30/rebuild_unimarc_100.pl @@ -3,6 +3,7 @@ # Written by TG on 01/10/2005 # Revised by Joshua Ferraro on 03/31/2006 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/build6xx.pl b/misc/migration_tools/build6xx.pl index 1c038ee2a6..5c02f12f3f 100755 --- a/misc/migration_tools/build6xx.pl +++ b/misc/migration_tools/build6xx.pl @@ -3,6 +3,7 @@ # delete FROM `marc_subfield_table` WHERE tag = "606" AND subfieldcode = 9; use strict; +#use warnings; FIXME - Bug 2505 # Koha modules used use MARC::File::USMARC; diff --git a/misc/migration_tools/buildCOUNTRY.pl b/misc/migration_tools/buildCOUNTRY.pl index 850ea17786..9fb657007d 100755 --- a/misc/migration_tools/buildCOUNTRY.pl +++ b/misc/migration_tools/buildCOUNTRY.pl @@ -3,6 +3,7 @@ # delete FROM `marc_subfield_table` WHERE tag = "606" AND subfieldcode = 9; use strict; +#use warnings; FIXME - Bug 2505 # Koha modules used use C4::Context; diff --git a/misc/migration_tools/buildEDITORS.pl b/misc/migration_tools/buildEDITORS.pl index e6d6fd3161..0126ae614a 100755 --- a/misc/migration_tools/buildEDITORS.pl +++ b/misc/migration_tools/buildEDITORS.pl @@ -2,6 +2,7 @@ # script that rebuild EDITORS use strict; +#use warnings; FIXME - Bug 2505 # Koha modules used use MARC::File::USMARC; diff --git a/misc/migration_tools/buildLANG.pl b/misc/migration_tools/buildLANG.pl index fe9e6d5e23..bd33212749 100755 --- a/misc/migration_tools/buildLANG.pl +++ b/misc/migration_tools/buildLANG.pl @@ -3,6 +3,7 @@ # delete FROM `marc_subfield_table` WHERE tag = "606" AND subfieldcode = 9; use strict; +#use warnings; FIXME - Bug 2505 # Koha modules used use C4::Context; diff --git a/misc/migration_tools/bulkauthimport.pl b/misc/migration_tools/bulkauthimport.pl index d3dcadcea7..2709db91c9 100755 --- a/misc/migration_tools/bulkauthimport.pl +++ b/misc/migration_tools/bulkauthimport.pl @@ -2,6 +2,7 @@ # small script that import an iso2709 file into koha 2.0 use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/fix_onloan.pl b/misc/migration_tools/fix_onloan.pl index 1dc5246af7..d6e63af79a 100755 --- a/misc/migration_tools/fix_onloan.pl +++ b/misc/migration_tools/fix_onloan.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Items; use C4::Biblio; @@ -24,4 +25,4 @@ $|=1; while (my ($biblionumber,$itemnumber,$onloan)= $rqbiblios->fetchrow){ ModItem({onloan => "$onloan"}, $biblionumber, $itemnumber); print "Onloan : $onloan for $biblionumber / $itemnumber\n"; -} \ No newline at end of file +} diff --git a/misc/migration_tools/merge_authority.pl b/misc/migration_tools/merge_authority.pl index 8bf4e7c325..0987827981 100755 --- a/misc/migration_tools/merge_authority.pl +++ b/misc/migration_tools/merge_authority.pl @@ -2,6 +2,7 @@ # script that rebuild thesaurus from biblio table. use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/migration_tools/rebuild_nozebra.pl b/misc/migration_tools/rebuild_nozebra.pl index 7432c5e6b4..b6b82c5c8c 100755 --- a/misc/migration_tools/rebuild_nozebra.pl +++ b/misc/migration_tools/rebuild_nozebra.pl @@ -6,6 +6,7 @@ use C4::Biblio; use C4::AuthoritiesMarc; use strict; +#use warnings; FIXME - Bug 2505 # # script that fills the nozebra table # diff --git a/misc/migration_tools/rebuild_zebra.pl b/misc/migration_tools/rebuild_zebra.pl index 0f4b4a0b13..37dcaf508d 100755 --- a/misc/migration_tools/rebuild_zebra.pl +++ b/misc/migration_tools/rebuild_zebra.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use Getopt::Long; diff --git a/misc/migration_tools/upgradeitems.pl b/misc/migration_tools/upgradeitems.pl index 864c91b7e4..10c754433a 100755 --- a/misc/migration_tools/upgradeitems.pl +++ b/misc/migration_tools/upgradeitems.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Items; use C4::Biblio; @@ -27,4 +28,4 @@ while (my ($biblionumber)= $rqbiblios->fetchrow_array){ warn $record->as_formatted; } } -} \ No newline at end of file +} diff --git a/misc/perlmodule_ls.pl b/misc/perlmodule_ls.pl index 818f855cc2..6ffcc528fd 100755 --- a/misc/perlmodule_ls.pl +++ b/misc/perlmodule_ls.pl @@ -1,5 +1,8 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 + use ExtUtils::Installed; my $instmod = ExtUtils::Installed->new(); foreach my $module ($instmod->modules()) { diff --git a/misc/sax_parser_test.pl b/misc/sax_parser_test.pl index 07d672cf09..c99f07bad2 100755 --- a/misc/sax_parser_test.pl +++ b/misc/sax_parser_test.pl @@ -1,4 +1,6 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 use XML::SAX; my $parser = XML::SAX::ParserFactory->parser( Handler => MySAXHandler->new diff --git a/misc/stage_biblios_file.pl b/misc/stage_biblios_file.pl index 5518359dcc..3f18082104 100755 --- a/misc/stage_biblios_file.pl +++ b/misc/stage_biblios_file.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/translator/stats.pl b/misc/translator/stats.pl index 8ba923bf51..1f1c6319cf 100755 --- a/misc/translator/stats.pl +++ b/misc/translator/stats.pl @@ -18,6 +18,8 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. # +#use strict; +#use warnings; FIXME - Bug 2505 my $PACKAGE="koha"; diff --git a/misc/translator/text-extract.pl b/misc/translator/text-extract.pl index f876e78195..4e2fbdce77 100755 --- a/misc/translator/text-extract.pl +++ b/misc/translator/text-extract.pl @@ -1,4 +1,6 @@ #!/usr/bin/perl +#use strict; +#use warnings; FIXME - Bug 2505 use HTML::Tree; use Getopt::Std; getopt("f:"); diff --git a/misc/translator/text-extract2.pl b/misc/translator/text-extract2.pl index ec838c80ec..452fd89666 100755 --- a/misc/translator/text-extract2.pl +++ b/misc/translator/text-extract2.pl @@ -14,10 +14,11 @@ # --> This will be relatively major rework, and requires corresponding # rework in tmpl_process.pl +use strict; +#use warnings; FIXME - Bug 2505 use Getopt::Long; use TmplTokenizer; use VerboseWarnings; -use strict; use vars qw( $input ); use vars qw( $debug_dump_only_p ); diff --git a/misc/translator/tmpl_process3.pl b/misc/translator/tmpl_process3.pl index 80325d077f..dbbe18e9b3 100755 --- a/misc/translator/tmpl_process3.pl +++ b/misc/translator/tmpl_process3.pl @@ -12,6 +12,7 @@ using gettext-compatible translation files =cut use strict; +#use warnings; FIXME - Bug 2505 use Getopt::Long; use Locale::PO; use File::Temp qw( :POSIX ); From f394170ebc25e19eced78f37b550f93064e40646 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 11:00:19 +1200 Subject: [PATCH 18/24] Bug 2505 - Add commented use warnings where missing in the cataloguing/ directory --- cataloguing/addbiblio.pl | 1 + cataloguing/additem.pl | 3 ++- cataloguing/merge.pl | 1 + cataloguing/merge_ajax.pl | 1 + cataloguing/moveitem.pl | 3 ++- cataloguing/plugin_launcher.pl | 1 + cataloguing/value_builder/barcode.pl | 3 ++- cataloguing/value_builder/dateaccessioned.pl | 3 +++ cataloguing/value_builder/labs_theses.pl | 1 + cataloguing/value_builder/macles.pl | 1 + cataloguing/value_builder/marc21_field_003.pl | 1 + cataloguing/value_builder/marc21_field_005.pl | 1 + cataloguing/value_builder/marc21_field_006.pl | 1 + cataloguing/value_builder/marc21_field_007.pl | 1 + cataloguing/value_builder/marc21_field_008.pl | 1 + cataloguing/value_builder/marc21_field_008_authorities.pl | 1 + cataloguing/value_builder/marc21_field_040c.pl | 1 + cataloguing/value_builder/marc21_field_040d.pl | 1 + cataloguing/value_builder/marc21_field_245h.pl | 1 + cataloguing/value_builder/marc21_leader.pl | 1 + cataloguing/value_builder/marc21_leader_authorities.pl | 1 + cataloguing/value_builder/marc21_leader_book.pl | 1 + cataloguing/value_builder/marc21_leader_computerfile.pl | 1 + cataloguing/value_builder/marc21_leader_video.pl | 1 + cataloguing/value_builder/stocknumber.pl | 3 ++- cataloguing/value_builder/unimarc_field_100.pl | 1 + cataloguing/value_builder/unimarc_field_105.pl | 1 + cataloguing/value_builder/unimarc_field_106.pl | 1 + cataloguing/value_builder/unimarc_field_110.pl | 1 + cataloguing/value_builder/unimarc_field_115a.pl | 1 + cataloguing/value_builder/unimarc_field_115b.pl | 1 + cataloguing/value_builder/unimarc_field_116.pl | 1 + cataloguing/value_builder/unimarc_field_117.pl | 1 + cataloguing/value_builder/unimarc_field_120.pl | 1 + cataloguing/value_builder/unimarc_field_121a.pl | 1 + cataloguing/value_builder/unimarc_field_121b.pl | 1 + cataloguing/value_builder/unimarc_field_122.pl | 1 + cataloguing/value_builder/unimarc_field_123a.pl | 1 + cataloguing/value_builder/unimarc_field_123d.pl | 1 + cataloguing/value_builder/unimarc_field_123e.pl | 1 + cataloguing/value_builder/unimarc_field_123f.pl | 1 + cataloguing/value_builder/unimarc_field_123g.pl | 1 + cataloguing/value_builder/unimarc_field_123i.pl | 1 + cataloguing/value_builder/unimarc_field_123j.pl | 1 + cataloguing/value_builder/unimarc_field_124.pl | 1 + cataloguing/value_builder/unimarc_field_124a.pl | 1 + cataloguing/value_builder/unimarc_field_124b.pl | 1 + cataloguing/value_builder/unimarc_field_124c.pl | 1 + cataloguing/value_builder/unimarc_field_124d.pl | 1 + cataloguing/value_builder/unimarc_field_124e.pl | 1 + cataloguing/value_builder/unimarc_field_124f.pl | 1 + cataloguing/value_builder/unimarc_field_124g.pl | 1 + cataloguing/value_builder/unimarc_field_125.pl | 1 + cataloguing/value_builder/unimarc_field_125a.pl | 1 + cataloguing/value_builder/unimarc_field_125b.pl | 1 + cataloguing/value_builder/unimarc_field_126.pl | 1 + cataloguing/value_builder/unimarc_field_126a.pl | 1 + cataloguing/value_builder/unimarc_field_126b.pl | 1 + cataloguing/value_builder/unimarc_field_127.pl | 1 + cataloguing/value_builder/unimarc_field_128a.pl | 1 + cataloguing/value_builder/unimarc_field_128b.pl | 1 + cataloguing/value_builder/unimarc_field_128c.pl | 1 + cataloguing/value_builder/unimarc_field_130.pl | 1 + cataloguing/value_builder/unimarc_field_135a.pl | 1 + cataloguing/value_builder/unimarc_field_140.pl | 1 + cataloguing/value_builder/unimarc_field_141.pl | 1 + cataloguing/value_builder/unimarc_field_210c.pl | 2 ++ cataloguing/value_builder/unimarc_field_225a.pl | 1 + cataloguing/value_builder/unimarc_field_4XX.pl | 1 + cataloguing/value_builder/unimarc_field_686a.pl | 1 + cataloguing/value_builder/unimarc_field_700-4.pl | 1 + cataloguing/value_builder/unimarc_leader.pl | 1 + cataloguing/z3950_search.pl | 1 + 73 files changed, 80 insertions(+), 4 deletions(-) diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl index 845ee855a8..7a1ed65eae 100755 --- a/cataloguing/addbiblio.pl +++ b/cataloguing/addbiblio.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; use C4::Auth; diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index a89a3c50e5..bd3876eed3 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -18,8 +18,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use CGI; use strict; +#use warnings; FIXME - Bug 2505 +use CGI; use C4::Auth; use C4::Output; use C4::Biblio; diff --git a/cataloguing/merge.pl b/cataloguing/merge.pl index 3a96979dbb..b1cddf23ee 100755 --- a/cataloguing/merge.pl +++ b/cataloguing/merge.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; use C4::Auth; diff --git a/cataloguing/merge_ajax.pl b/cataloguing/merge_ajax.pl index db4a430839..6bad3e91d2 100755 --- a/cataloguing/merge_ajax.pl +++ b/cataloguing/merge_ajax.pl @@ -1,6 +1,7 @@ #!/usr/bin/perl use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use IO::File; diff --git a/cataloguing/moveitem.pl b/cataloguing/moveitem.pl index b1542e36f1..e0ab5517cc 100755 --- a/cataloguing/moveitem.pl +++ b/cataloguing/moveitem.pl @@ -19,8 +19,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. -use CGI; use strict; +#use warnings; FIXME - Bug 2505 +use CGI; use C4::Auth; use C4::Output; use C4::Biblio; diff --git a/cataloguing/plugin_launcher.pl b/cataloguing/plugin_launcher.pl index 4e269df380..9a264ab161 100755 --- a/cataloguing/plugin_launcher.pl +++ b/cataloguing/plugin_launcher.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/cataloguing/value_builder/barcode.pl b/cataloguing/value_builder/barcode.pl index b80f70e2f6..e21105b3ff 100755 --- a/cataloguing/value_builder/barcode.pl +++ b/cataloguing/value_builder/barcode.pl @@ -19,7 +19,8 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - +#use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; require C4::Dates; my $DEBUG = 0; diff --git a/cataloguing/value_builder/dateaccessioned.pl b/cataloguing/value_builder/dateaccessioned.pl index f658cb840f..3b8e8c03d5 100755 --- a/cataloguing/value_builder/dateaccessioned.pl +++ b/cataloguing/value_builder/dateaccessioned.pl @@ -19,6 +19,9 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +#use strict; +#use warnings; FIXME - Bug 2505 + =head1 plugin_parameters : useless here diff --git a/cataloguing/value_builder/labs_theses.pl b/cataloguing/value_builder/labs_theses.pl index c6a61fb5a4..f24b8c49bc 100755 --- a/cataloguing/value_builder/labs_theses.pl +++ b/cataloguing/value_builder/labs_theses.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; diff --git a/cataloguing/value_builder/macles.pl b/cataloguing/value_builder/macles.pl index 54e71f5d04..4b2a202651 100755 --- a/cataloguing/value_builder/macles.pl +++ b/cataloguing/value_builder/macles.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; use C4::Output; diff --git a/cataloguing/value_builder/marc21_field_003.pl b/cataloguing/value_builder/marc21_field_003.pl index ab1fdd1313..531f586623 100755 --- a/cataloguing/value_builder/marc21_field_003.pl +++ b/cataloguing/value_builder/marc21_field_003.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; =head1 diff --git a/cataloguing/value_builder/marc21_field_005.pl b/cataloguing/value_builder/marc21_field_005.pl index 5c8b560150..3c331457b0 100755 --- a/cataloguing/value_builder/marc21_field_005.pl +++ b/cataloguing/value_builder/marc21_field_005.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; =head1 diff --git a/cataloguing/value_builder/marc21_field_006.pl b/cataloguing/value_builder/marc21_field_006.pl index 5d9532ab81..d2a9bb1129 100755 --- a/cataloguing/value_builder/marc21_field_006.pl +++ b/cataloguing/value_builder/marc21_field_006.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_field_007.pl b/cataloguing/value_builder/marc21_field_007.pl index 281d21667c..b250fbee45 100755 --- a/cataloguing/value_builder/marc21_field_007.pl +++ b/cataloguing/value_builder/marc21_field_007.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_field_008.pl b/cataloguing/value_builder/marc21_field_008.pl index 7f44c8622d..87012c6143 100755 --- a/cataloguing/value_builder/marc21_field_008.pl +++ b/cataloguing/value_builder/marc21_field_008.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_field_008_authorities.pl b/cataloguing/value_builder/marc21_field_008_authorities.pl index 1f5ab709b6..bf45e063c7 100755 --- a/cataloguing/value_builder/marc21_field_008_authorities.pl +++ b/cataloguing/value_builder/marc21_field_008_authorities.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_field_040c.pl b/cataloguing/value_builder/marc21_field_040c.pl index c162633a69..532ef84ab1 100755 --- a/cataloguing/value_builder/marc21_field_040c.pl +++ b/cataloguing/value_builder/marc21_field_040c.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; # use MARC::Record; diff --git a/cataloguing/value_builder/marc21_field_040d.pl b/cataloguing/value_builder/marc21_field_040d.pl index 7796b193c3..51a053fc8f 100755 --- a/cataloguing/value_builder/marc21_field_040d.pl +++ b/cataloguing/value_builder/marc21_field_040d.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; # use MARC::Record; diff --git a/cataloguing/value_builder/marc21_field_245h.pl b/cataloguing/value_builder/marc21_field_245h.pl index e1a26d1ddb..3a6f2b4370 100755 --- a/cataloguing/value_builder/marc21_field_245h.pl +++ b/cataloguing/value_builder/marc21_field_245h.pl @@ -19,6 +19,7 @@ # Suite 330, Boston, MA 02111-1307 USA use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; =head1 diff --git a/cataloguing/value_builder/marc21_leader.pl b/cataloguing/value_builder/marc21_leader.pl index 2bc4fed92f..d3b8e900cd 100755 --- a/cataloguing/value_builder/marc21_leader.pl +++ b/cataloguing/value_builder/marc21_leader.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_leader_authorities.pl b/cataloguing/value_builder/marc21_leader_authorities.pl index d66574f655..600ac99c45 100755 --- a/cataloguing/value_builder/marc21_leader_authorities.pl +++ b/cataloguing/value_builder/marc21_leader_authorities.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_leader_book.pl b/cataloguing/value_builder/marc21_leader_book.pl index 7ef9d69d66..edc9782800 100755 --- a/cataloguing/value_builder/marc21_leader_book.pl +++ b/cataloguing/value_builder/marc21_leader_book.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_leader_computerfile.pl b/cataloguing/value_builder/marc21_leader_computerfile.pl index 6b052de295..5c7a1190d7 100755 --- a/cataloguing/value_builder/marc21_leader_computerfile.pl +++ b/cataloguing/value_builder/marc21_leader_computerfile.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/marc21_leader_video.pl b/cataloguing/value_builder/marc21_leader_video.pl index 7877fc81c3..864360f2d5 100755 --- a/cataloguing/value_builder/marc21_leader_video.pl +++ b/cataloguing/value_builder/marc21_leader_video.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/stocknumber.pl b/cataloguing/value_builder/stocknumber.pl index 1daf7453ee..88e726a285 100755 --- a/cataloguing/value_builder/stocknumber.pl +++ b/cataloguing/value_builder/stocknumber.pl @@ -17,7 +17,8 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. - +#use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; =head1 diff --git a/cataloguing/value_builder/unimarc_field_100.pl b/cataloguing/value_builder/unimarc_field_100.pl index 6745f0df0f..b47c3202f8 100755 --- a/cataloguing/value_builder/unimarc_field_100.pl +++ b/cataloguing/value_builder/unimarc_field_100.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_105.pl b/cataloguing/value_builder/unimarc_field_105.pl index 0ccc30ee94..8eb46a8195 100755 --- a/cataloguing/value_builder/unimarc_field_105.pl +++ b/cataloguing/value_builder/unimarc_field_105.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_106.pl b/cataloguing/value_builder/unimarc_field_106.pl index 4bb27686b9..856db2445e 100755 --- a/cataloguing/value_builder/unimarc_field_106.pl +++ b/cataloguing/value_builder/unimarc_field_106.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_110.pl b/cataloguing/value_builder/unimarc_field_110.pl index bd328154bb..28eaea98bf 100755 --- a/cataloguing/value_builder/unimarc_field_110.pl +++ b/cataloguing/value_builder/unimarc_field_110.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_115a.pl b/cataloguing/value_builder/unimarc_field_115a.pl index 53d1ddfdb0..21ed66b0e5 100755 --- a/cataloguing/value_builder/unimarc_field_115a.pl +++ b/cataloguing/value_builder/unimarc_field_115a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_115b.pl b/cataloguing/value_builder/unimarc_field_115b.pl index af6c44011c..bdaf23a8d4 100755 --- a/cataloguing/value_builder/unimarc_field_115b.pl +++ b/cataloguing/value_builder/unimarc_field_115b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_116.pl b/cataloguing/value_builder/unimarc_field_116.pl index dd63499b08..16ab3d20bd 100755 --- a/cataloguing/value_builder/unimarc_field_116.pl +++ b/cataloguing/value_builder/unimarc_field_116.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_117.pl b/cataloguing/value_builder/unimarc_field_117.pl index 94524e5e95..679f727e91 100755 --- a/cataloguing/value_builder/unimarc_field_117.pl +++ b/cataloguing/value_builder/unimarc_field_117.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_120.pl b/cataloguing/value_builder/unimarc_field_120.pl index f3217f7303..d415dfa5b5 100755 --- a/cataloguing/value_builder/unimarc_field_120.pl +++ b/cataloguing/value_builder/unimarc_field_120.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_121a.pl b/cataloguing/value_builder/unimarc_field_121a.pl index 6cc2b9c404..d33983912f 100755 --- a/cataloguing/value_builder/unimarc_field_121a.pl +++ b/cataloguing/value_builder/unimarc_field_121a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_121b.pl b/cataloguing/value_builder/unimarc_field_121b.pl index a9d2c5ea6b..1ef8abef7c 100755 --- a/cataloguing/value_builder/unimarc_field_121b.pl +++ b/cataloguing/value_builder/unimarc_field_121b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_122.pl b/cataloguing/value_builder/unimarc_field_122.pl index 37118fc706..def9530326 100755 --- a/cataloguing/value_builder/unimarc_field_122.pl +++ b/cataloguing/value_builder/unimarc_field_122.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123a.pl b/cataloguing/value_builder/unimarc_field_123a.pl index d4111b6dc3..b5d674c154 100755 --- a/cataloguing/value_builder/unimarc_field_123a.pl +++ b/cataloguing/value_builder/unimarc_field_123a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123d.pl b/cataloguing/value_builder/unimarc_field_123d.pl index 589a84a34e..79cdc5037c 100755 --- a/cataloguing/value_builder/unimarc_field_123d.pl +++ b/cataloguing/value_builder/unimarc_field_123d.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123e.pl b/cataloguing/value_builder/unimarc_field_123e.pl index 589a84a34e..79cdc5037c 100755 --- a/cataloguing/value_builder/unimarc_field_123e.pl +++ b/cataloguing/value_builder/unimarc_field_123e.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123f.pl b/cataloguing/value_builder/unimarc_field_123f.pl index 9f3231ff07..636bada411 100755 --- a/cataloguing/value_builder/unimarc_field_123f.pl +++ b/cataloguing/value_builder/unimarc_field_123f.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123g.pl b/cataloguing/value_builder/unimarc_field_123g.pl index 589a84a34e..79cdc5037c 100755 --- a/cataloguing/value_builder/unimarc_field_123g.pl +++ b/cataloguing/value_builder/unimarc_field_123g.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123i.pl b/cataloguing/value_builder/unimarc_field_123i.pl index 038eaea583..125f393d51 100755 --- a/cataloguing/value_builder/unimarc_field_123i.pl +++ b/cataloguing/value_builder/unimarc_field_123i.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_123j.pl b/cataloguing/value_builder/unimarc_field_123j.pl index da6d38d1e7..b1c31b12b2 100755 --- a/cataloguing/value_builder/unimarc_field_123j.pl +++ b/cataloguing/value_builder/unimarc_field_123j.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124.pl b/cataloguing/value_builder/unimarc_field_124.pl index 5b4aa4ac12..563b3b5bd4 100755 --- a/cataloguing/value_builder/unimarc_field_124.pl +++ b/cataloguing/value_builder/unimarc_field_124.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124a.pl b/cataloguing/value_builder/unimarc_field_124a.pl index 0595b1f94c..cadacd6ae2 100755 --- a/cataloguing/value_builder/unimarc_field_124a.pl +++ b/cataloguing/value_builder/unimarc_field_124a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124b.pl b/cataloguing/value_builder/unimarc_field_124b.pl index 66a15a942c..d0ae9a94dc 100755 --- a/cataloguing/value_builder/unimarc_field_124b.pl +++ b/cataloguing/value_builder/unimarc_field_124b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124c.pl b/cataloguing/value_builder/unimarc_field_124c.pl index b46b89a688..057df95253 100755 --- a/cataloguing/value_builder/unimarc_field_124c.pl +++ b/cataloguing/value_builder/unimarc_field_124c.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124d.pl b/cataloguing/value_builder/unimarc_field_124d.pl index 71a27b2e24..70aa77e6e0 100755 --- a/cataloguing/value_builder/unimarc_field_124d.pl +++ b/cataloguing/value_builder/unimarc_field_124d.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124e.pl b/cataloguing/value_builder/unimarc_field_124e.pl index 64cb10f9bf..02df151fd0 100755 --- a/cataloguing/value_builder/unimarc_field_124e.pl +++ b/cataloguing/value_builder/unimarc_field_124e.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124f.pl b/cataloguing/value_builder/unimarc_field_124f.pl index 0f5dfaf179..c46a8d55b4 100755 --- a/cataloguing/value_builder/unimarc_field_124f.pl +++ b/cataloguing/value_builder/unimarc_field_124f.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_124g.pl b/cataloguing/value_builder/unimarc_field_124g.pl index 1e00503f44..c33a19092c 100755 --- a/cataloguing/value_builder/unimarc_field_124g.pl +++ b/cataloguing/value_builder/unimarc_field_124g.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_125.pl b/cataloguing/value_builder/unimarc_field_125.pl index 5b4aa4ac12..563b3b5bd4 100755 --- a/cataloguing/value_builder/unimarc_field_125.pl +++ b/cataloguing/value_builder/unimarc_field_125.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_125a.pl b/cataloguing/value_builder/unimarc_field_125a.pl index 7793ddc9e9..5b8777221e 100755 --- a/cataloguing/value_builder/unimarc_field_125a.pl +++ b/cataloguing/value_builder/unimarc_field_125a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_125b.pl b/cataloguing/value_builder/unimarc_field_125b.pl index 00e60f4b0d..0e40ee4287 100755 --- a/cataloguing/value_builder/unimarc_field_125b.pl +++ b/cataloguing/value_builder/unimarc_field_125b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_126.pl b/cataloguing/value_builder/unimarc_field_126.pl index 5b4aa4ac12..563b3b5bd4 100755 --- a/cataloguing/value_builder/unimarc_field_126.pl +++ b/cataloguing/value_builder/unimarc_field_126.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_126a.pl b/cataloguing/value_builder/unimarc_field_126a.pl index dc99442287..c8f5135a45 100755 --- a/cataloguing/value_builder/unimarc_field_126a.pl +++ b/cataloguing/value_builder/unimarc_field_126a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_126b.pl b/cataloguing/value_builder/unimarc_field_126b.pl index 091cc1ac51..c31bb8a831 100755 --- a/cataloguing/value_builder/unimarc_field_126b.pl +++ b/cataloguing/value_builder/unimarc_field_126b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_127.pl b/cataloguing/value_builder/unimarc_field_127.pl index d58d8c3732..79288371f9 100755 --- a/cataloguing/value_builder/unimarc_field_127.pl +++ b/cataloguing/value_builder/unimarc_field_127.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_128a.pl b/cataloguing/value_builder/unimarc_field_128a.pl index 10bc37c690..de895b18bb 100755 --- a/cataloguing/value_builder/unimarc_field_128a.pl +++ b/cataloguing/value_builder/unimarc_field_128a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_128b.pl b/cataloguing/value_builder/unimarc_field_128b.pl index f9c8d3cef7..6617f91a7c 100755 --- a/cataloguing/value_builder/unimarc_field_128b.pl +++ b/cataloguing/value_builder/unimarc_field_128b.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_128c.pl b/cataloguing/value_builder/unimarc_field_128c.pl index 863ed350d0..4a68e981ac 100755 --- a/cataloguing/value_builder/unimarc_field_128c.pl +++ b/cataloguing/value_builder/unimarc_field_128c.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_130.pl b/cataloguing/value_builder/unimarc_field_130.pl index c2fc5fb44a..4d2d1a58ae 100755 --- a/cataloguing/value_builder/unimarc_field_130.pl +++ b/cataloguing/value_builder/unimarc_field_130.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_135a.pl b/cataloguing/value_builder/unimarc_field_135a.pl index 5a681fc02a..22c887886a 100755 --- a/cataloguing/value_builder/unimarc_field_135a.pl +++ b/cataloguing/value_builder/unimarc_field_135a.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_140.pl b/cataloguing/value_builder/unimarc_field_140.pl index f639e0ed1c..3f7b953167 100755 --- a/cataloguing/value_builder/unimarc_field_140.pl +++ b/cataloguing/value_builder/unimarc_field_140.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_141.pl b/cataloguing/value_builder/unimarc_field_141.pl index efb5985b1c..d355f7117e 100755 --- a/cataloguing/value_builder/unimarc_field_141.pl +++ b/cataloguing/value_builder/unimarc_field_141.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_210c.pl b/cataloguing/value_builder/unimarc_field_210c.pl index 3228dc3283..6779999426 100755 --- a/cataloguing/value_builder/unimarc_field_210c.pl +++ b/cataloguing/value_builder/unimarc_field_210c.pl @@ -18,6 +18,8 @@ # with Koha; if not, write to the Free Software Foundation, Inc., # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. +#use strict; +#use warnings; FIXME - Bug 2505 use C4::AuthoritiesMarc; use C4::Auth; diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl index bbefb3c0ff..acd02e1887 100755 --- a/cataloguing/value_builder/unimarc_field_225a.pl +++ b/cataloguing/value_builder/unimarc_field_225a.pl @@ -42,6 +42,7 @@ It need : =cut use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl index 3d4b31aab2..91c4361d5d 100755 --- a/cataloguing/value_builder/unimarc_field_4XX.pl +++ b/cataloguing/value_builder/unimarc_field_4XX.pl @@ -19,6 +19,7 @@ use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Output; diff --git a/cataloguing/value_builder/unimarc_field_686a.pl b/cataloguing/value_builder/unimarc_field_686a.pl index 67160bd192..786748d4d9 100755 --- a/cataloguing/value_builder/unimarc_field_686a.pl +++ b/cataloguing/value_builder/unimarc_field_686a.pl @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_field_700-4.pl b/cataloguing/value_builder/unimarc_field_700-4.pl index c1bb22bd6b..e316027110 100755 --- a/cataloguing/value_builder/unimarc_field_700-4.pl +++ b/cataloguing/value_builder/unimarc_field_700-4.pl @@ -20,6 +20,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/value_builder/unimarc_leader.pl b/cataloguing/value_builder/unimarc_leader.pl index a5a69c15c6..2c7ceee011 100755 --- a/cataloguing/value_builder/unimarc_leader.pl +++ b/cataloguing/value_builder/unimarc_leader.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Auth; use CGI; use C4::Context; diff --git a/cataloguing/z3950_search.pl b/cataloguing/z3950_search.pl index cd312a18f8..cf9e7b2ff4 100755 --- a/cataloguing/z3950_search.pl +++ b/cataloguing/z3950_search.pl @@ -19,6 +19,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Auth; From 593a7d8e6acc92a8bc7842d1beda2983b570613e Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 11:52:29 +1200 Subject: [PATCH 19/24] Bug 2505 - Add commented use warnings where missing in *.pm --- C4/Accounts.pm | 1 + C4/Auth.pm | 1 + C4/Auth_with_cas.pm | 1 + C4/Auth_with_ldap.pm | 2 +- C4/AuthoritiesMarc.pm | 1 + C4/AuthoritiesMarc/MARC21.pm | 1 + C4/AuthoritiesMarc/UNIMARC.pm | 1 + C4/BackgroundJob.pm | 1 + C4/Barcodes/PrinterConfig.pm | 1 + C4/Bookseller.pm | 1 + C4/Branch.pm | 1 + C4/Budgets.pm | 1 + C4/Circulation.pm | 2 +- C4/Contract.pm | 1 + C4/Csv.pm | 3 +++ C4/Heading.pm | 1 + C4/Heading/MARC21.pm | 1 + C4/Installer.pm | 1 + C4/Items.pm | 1 + C4/Koha.pm | 1 + C4/Languages.pm | 2 +- C4/Maintainance.pm | 1 + C4/Members.pm | 1 + C4/Members/AttributeTypes.pm | 1 + C4/Output.pm | 1 + C4/Overdues.pm | 1 + C4/Print.pm | 1 + C4/Record.pm | 3 ++- C4/Reports.pm | 1 + C4/Reports/Guided.pm | 2 +- C4/Reserves.pm | 2 +- C4/Ris.pm | 2 ++ C4/RotatingCollections.pm | 1 + C4/Scheduler.pm | 1 + C4/Search.pm | 2 +- C4/Search/PazPar2.pm | 1 + C4/Serials/Frequency.pm | 1 + C4/Serials/NumberPattern.pm | 1 + C4/Suggestions.pm | 1 + C4/UploadedFile.pm | 1 + C4/XISBN.pm | 1 + C4/Z3950.pm | 1 + install_misc/UpgradeBackup.pm | 1 + installer/InstallAuth.pm | 1 + misc/translator/TmplToken.pm | 1 + misc/translator/TmplTokenType.pm | 1 + misc/translator/TmplTokenizer.pm | 1 + misc/translator/VerboseWarnings.pm | 1 + 48 files changed, 52 insertions(+), 7 deletions(-) diff --git a/C4/Accounts.pm b/C4/Accounts.pm index bbc6c0037e..ff2188b4db 100644 --- a/C4/Accounts.pm +++ b/C4/Accounts.pm @@ -19,6 +19,7 @@ package C4::Accounts; use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Stats; use C4::Members; diff --git a/C4/Auth.pm b/C4/Auth.pm index d745b63f2e..94a05fbdb0 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -18,6 +18,7 @@ package C4::Auth; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use Digest::MD5 qw(md5_base64); use Storable qw(thaw freeze); use URI::Escape; diff --git a/C4/Auth_with_cas.pm b/C4/Auth_with_cas.pm index 501fdefc98..8cf6b034da 100644 --- a/C4/Auth_with_cas.pm +++ b/C4/Auth_with_cas.pm @@ -18,6 +18,7 @@ package C4::Auth_with_cas; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Debug; use C4::Context; diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm index 994f8461a2..78666e9cf8 100644 --- a/C4/Auth_with_ldap.pm +++ b/C4/Auth_with_ldap.pm @@ -18,7 +18,7 @@ package C4::Auth_with_ldap; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; almost? +#use warnings; FIXME - Bug 2505 use Digest::MD5 qw(md5_base64); use C4::Debug; diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm index f0f2d05d20..a3eef6934f 100644 --- a/C4/AuthoritiesMarc.pm +++ b/C4/AuthoritiesMarc.pm @@ -17,6 +17,7 @@ package C4::AuthoritiesMarc; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Koha; use MARC::Record; diff --git a/C4/AuthoritiesMarc/MARC21.pm b/C4/AuthoritiesMarc/MARC21.pm index 1375369142..dd3f0f8959 100644 --- a/C4/AuthoritiesMarc/MARC21.pm +++ b/C4/AuthoritiesMarc/MARC21.pm @@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::MARC21; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use MARC::Record; our $VERSION = 3.00; diff --git a/C4/AuthoritiesMarc/UNIMARC.pm b/C4/AuthoritiesMarc/UNIMARC.pm index 87f6743443..5df70e661e 100644 --- a/C4/AuthoritiesMarc/UNIMARC.pm +++ b/C4/AuthoritiesMarc/UNIMARC.pm @@ -18,6 +18,7 @@ package C4::AuthoritiesMarc::UNIMARC; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 our $VERSION = 3.00; =head1 NAME diff --git a/C4/BackgroundJob.pm b/C4/BackgroundJob.pm index 6d5bfeac18..e20eb6efc9 100644 --- a/C4/BackgroundJob.pm +++ b/C4/BackgroundJob.pm @@ -19,6 +19,7 @@ package C4::BackgroundJob; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Auth qw/get_session/; use Digest::MD5; diff --git a/C4/Barcodes/PrinterConfig.pm b/C4/Barcodes/PrinterConfig.pm index d90cd9645f..183d4e43bc 100644 --- a/C4/Barcodes/PrinterConfig.pm +++ b/C4/Barcodes/PrinterConfig.pm @@ -16,6 +16,7 @@ package C4::Barcodes::PrinterConfig; # Suite 330, Boston, MA 02111-1307 USA use strict; +#use warnings; FIXME - Bug 2505 use vars qw($VERSION @EXPORT); use PDF::API2; diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm index 361039fe3d..bdc43467ab 100644 --- a/C4/Bookseller.pm +++ b/C4/Bookseller.pm @@ -18,6 +18,7 @@ package C4::Bookseller; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use vars qw($VERSION @ISA @EXPORT); diff --git a/C4/Branch.pm b/C4/Branch.pm index 103a14d3c8..03d5824f75 100644 --- a/C4/Branch.pm +++ b/C4/Branch.pm @@ -17,6 +17,7 @@ package C4::Branch; use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use C4::Context; use C4::Koha; diff --git a/C4/Budgets.pm b/C4/Budgets.pm index eb9761509b..eeb9b0c15f 100644 --- a/C4/Budgets.pm +++ b/C4/Budgets.pm @@ -18,6 +18,7 @@ package C4::Budgets; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Dates qw(format_date format_date_in_iso); use C4::SQLHelper qw<:all>; diff --git a/C4/Circulation.pm b/C4/Circulation.pm index d780189d3a..00b11efa02 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -19,7 +19,7 @@ package C4::Circulation; use strict; -#use warnings; # soon! +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Stats; use C4::Reserves; diff --git a/C4/Contract.pm b/C4/Contract.pm index 0f202c0b6a..2fd54e7f0f 100644 --- a/C4/Contract.pm +++ b/C4/Contract.pm @@ -18,6 +18,7 @@ package C4::Contract; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::SQLHelper qw(:all); use vars qw($VERSION @ISA @EXPORT); diff --git a/C4/Csv.pm b/C4/Csv.pm index 2ff1499ba1..07ce2ebc40 100644 --- a/C4/Csv.pm +++ b/C4/Csv.pm @@ -19,6 +19,9 @@ package C4::Csv; # # +#use strict; +#use warnings; FIXME - Bug 2505 + use C4::Context; use vars qw($VERSION @ISA @EXPORT); diff --git a/C4/Heading.pm b/C4/Heading.pm index 0a23f9487d..ae1a0d03f7 100644 --- a/C4/Heading.pm +++ b/C4/Heading.pm @@ -18,6 +18,7 @@ package C4::Heading; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use MARC::Record; use MARC::Field; use C4::Context; diff --git a/C4/Heading/MARC21.pm b/C4/Heading/MARC21.pm index 1ff2c60fee..a057e51e8e 100644 --- a/C4/Heading/MARC21.pm +++ b/C4/Heading/MARC21.pm @@ -18,6 +18,7 @@ package C4::Heading::MARC21; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use MARC::Record; use MARC::Field; diff --git a/C4/Installer.pm b/C4/Installer.pm index addb5c824d..b3d798eb74 100644 --- a/C4/Installer.pm +++ b/C4/Installer.pm @@ -18,6 +18,7 @@ package C4::Installer; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 our $VERSION = 3.00; use C4::Context; diff --git a/C4/Items.pm b/C4/Items.pm index cd6f7d0021..7f31cdc745 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -18,6 +18,7 @@ package C4::Items; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use Carp; use C4::Context; diff --git a/C4/Koha.pm b/C4/Koha.pm index cc72f35fd6..11c7850deb 100644 --- a/C4/Koha.pm +++ b/C4/Koha.pm @@ -19,6 +19,7 @@ package C4::Koha; use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Output; use URI::Split qw(uri_split); diff --git a/C4/Languages.pm b/C4/Languages.pm index 21dd6e8a0e..9ef243958e 100644 --- a/C4/Languages.pm +++ b/C4/Languages.pm @@ -20,7 +20,7 @@ package C4::Languages; use strict; -#use warnings; #FIXME: turn off warnings before release +#use warnings; FIXME - Bug 2505 use Carp; use C4::Context; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS $DEBUG); diff --git a/C4/Maintainance.pm b/C4/Maintainance.pm index 4a36353fd9..33d6483726 100644 --- a/C4/Maintainance.pm +++ b/C4/Maintainance.pm @@ -21,6 +21,7 @@ package C4::Maintainance; #assumes C4/Maintainance # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; require Exporter; diff --git a/C4/Members.pm b/C4/Members.pm index dfa41e5978..4f79e3e16a 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -19,6 +19,7 @@ package C4::Members; use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Dates qw(format_date_in_iso); use Digest::MD5 qw(md5_base64); diff --git a/C4/Members/AttributeTypes.pm b/C4/Members/AttributeTypes.pm index 389b14846f..0506e2360a 100644 --- a/C4/Members/AttributeTypes.pm +++ b/C4/Members/AttributeTypes.pm @@ -18,6 +18,7 @@ package C4::Members::AttributeTypes; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use vars qw($VERSION); diff --git a/C4/Output.pm b/C4/Output.pm index 1c31558441..61e79c64c6 100644 --- a/C4/Output.pm +++ b/C4/Output.pm @@ -26,6 +26,7 @@ package C4::Output; # templates. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Languages qw(getTranslatedLanguages get_bidi regex_lang_subtags language_get_description accept_language ); diff --git a/C4/Overdues.pm b/C4/Overdues.pm index 5c9bde8c90..7f59b9bed4 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -19,6 +19,7 @@ package C4::Overdues; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use Date::Calc qw/Today Date_to_Days/; use Date::Manip qw/UnixDate/; use C4::Circulation; diff --git a/C4/Print.pm b/C4/Print.pm index 35bd8b5870..674f22029c 100644 --- a/C4/Print.pm +++ b/C4/Print.pm @@ -18,6 +18,7 @@ package C4::Print; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Circulation; use C4::Members; diff --git a/C4/Record.pm b/C4/Record.pm index 8dd073bd0b..233fa6e2ca 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -19,7 +19,8 @@ package C4::Record; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. # # -use strict;# use warnings; #FIXME: turn off warnings before release +use strict; +#use warnings; FIXME - Bug 2505 # please specify in which methods a given module is used use MARC::Record; # marc2marcxml, marcxml2marc, html2marc, changeEncoding diff --git a/C4/Reports.pm b/C4/Reports.pm index 2777d0ef3f..ab23f19822 100644 --- a/C4/Reports.pm +++ b/C4/Reports.pm @@ -18,6 +18,7 @@ package C4::Reports; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use CGI; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); diff --git a/C4/Reports/Guided.pm b/C4/Reports/Guided.pm index da3465780f..5cdad462cb 100644 --- a/C4/Reports/Guided.pm +++ b/C4/Reports/Guided.pm @@ -18,7 +18,7 @@ package C4::Reports::Guided; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; -# use warnings; # FIXME: this module needs a lot of repair to run clean under warnings +#use warnings; FIXME - Bug 2505 this module needs a lot of repair to run clean under warnings use CGI; use Carp; diff --git a/C4/Reserves.pm b/C4/Reserves.pm index fee4fceb4d..464b3f37c5 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -21,7 +21,7 @@ package C4::Reserves; use strict; -# use warnings; # FIXME: someday +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Biblio; use C4::Members; diff --git a/C4/Ris.pm b/C4/Ris.pm index d3026c0c08..c5c48065b7 100644 --- a/C4/Ris.pm +++ b/C4/Ris.pm @@ -57,6 +57,8 @@ package C4::Ris; # # +#use strict; +#use warnings; FIXME - Bug 2505 use vars qw($VERSION @ISA @EXPORT); diff --git a/C4/RotatingCollections.pm b/C4/RotatingCollections.pm index 83fc6e0fc9..6b1383f62c 100644 --- a/C4/RotatingCollections.pm +++ b/C4/RotatingCollections.pm @@ -23,6 +23,7 @@ package C4::RotatingCollections; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 require Exporter; diff --git a/C4/Scheduler.pm b/C4/Scheduler.pm index f4230a2d72..8cb6d199c8 100644 --- a/C4/Scheduler.pm +++ b/C4/Scheduler.pm @@ -18,6 +18,7 @@ package C4::Scheduler; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); use C4::Context; diff --git a/C4/Search.pm b/C4/Search.pm index 554174cb28..7b0b408e8e 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -16,7 +16,7 @@ package C4::Search; # Suite 330, Boston, MA 02111-1307 USA use strict; -# use warnings; # FIXME +#use warnings; FIXME - Bug 2505 require Exporter; use C4::Context; use C4::Biblio; # GetMarcFromKohaField, GetBiblioData diff --git a/C4/Search/PazPar2.pm b/C4/Search/PazPar2.pm index b12a2f7aa8..bf786bce8f 100644 --- a/C4/Search/PazPar2.pm +++ b/C4/Search/PazPar2.pm @@ -18,6 +18,7 @@ package C4::Search::PazPar2; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use LWP::UserAgent; use URI; diff --git a/C4/Serials/Frequency.pm b/C4/Serials/Frequency.pm index 9b1bc0fc6a..e41db5e0cf 100644 --- a/C4/Serials/Frequency.pm +++ b/C4/Serials/Frequency.pm @@ -18,6 +18,7 @@ package C4::Frequency; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::SQLHelper qw<:all>; use C4::Debug; diff --git a/C4/Serials/NumberPattern.pm b/C4/Serials/NumberPattern.pm index 9425d3e458..88e6def2e2 100644 --- a/C4/Serials/NumberPattern.pm +++ b/C4/Serials/NumberPattern.pm @@ -18,6 +18,7 @@ package C4::Numberpattern; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::SQLHelper qw<:all>; use C4::Debug; diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm index 2f7bd077c7..7c283f1807 100644 --- a/C4/Suggestions.pm +++ b/C4/Suggestions.pm @@ -19,6 +19,7 @@ package C4::Suggestions; use strict; +#use warnings; FIXME - Bug 2505 use CGI; use C4::Context; diff --git a/C4/UploadedFile.pm b/C4/UploadedFile.pm index 11fdef3429..3329936209 100644 --- a/C4/UploadedFile.pm +++ b/C4/UploadedFile.pm @@ -19,6 +19,7 @@ package C4::UploadedFile; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; use C4::Auth qw/get_session/; use IO::File; diff --git a/C4/XISBN.pm b/C4/XISBN.pm index 8175e08384..aa9687c2de 100644 --- a/C4/XISBN.pm +++ b/C4/XISBN.pm @@ -27,6 +27,7 @@ use LWP::UserAgent; use HTTP::Request::Common; use strict; +#use warnings; FIXME - Bug 2505 use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); BEGIN { diff --git a/C4/Z3950.pm b/C4/Z3950.pm index c0d7fe0afd..2ac1460a69 100644 --- a/C4/Z3950.pm +++ b/C4/Z3950.pm @@ -25,6 +25,7 @@ package C4::Z3950; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 # standard or CPAN modules used use DBI; diff --git a/install_misc/UpgradeBackup.pm b/install_misc/UpgradeBackup.pm index 5aaf929fa2..f84f33850c 100644 --- a/install_misc/UpgradeBackup.pm +++ b/install_misc/UpgradeBackup.pm @@ -18,6 +18,7 @@ package install_misc::UpgradeBackup; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use File::Compare qw(compare); use Cwd qw(cwd); use File::Copy; diff --git a/installer/InstallAuth.pm b/installer/InstallAuth.pm index 4d56596cd4..3a55b21599 100644 --- a/installer/InstallAuth.pm +++ b/installer/InstallAuth.pm @@ -21,6 +21,7 @@ package InstallAuth; # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +#use warnings; FIXME - Bug 2505 use Digest::MD5 qw(md5_base64); require Exporter; diff --git a/misc/translator/TmplToken.pm b/misc/translator/TmplToken.pm index 0a54d0b52c..cb883b433f 100644 --- a/misc/translator/TmplToken.pm +++ b/misc/translator/TmplToken.pm @@ -1,6 +1,7 @@ package TmplToken; use strict; +#use warnings; FIXME - Bug 2505 use TmplTokenType; require Exporter; diff --git a/misc/translator/TmplTokenType.pm b/misc/translator/TmplTokenType.pm index 75d4f5256a..217cfbbab9 100644 --- a/misc/translator/TmplTokenType.pm +++ b/misc/translator/TmplTokenType.pm @@ -1,6 +1,7 @@ package TmplTokenType; use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); diff --git a/misc/translator/TmplTokenizer.pm b/misc/translator/TmplTokenizer.pm index 919a5d4e5b..838a59faa8 100644 --- a/misc/translator/TmplTokenizer.pm +++ b/misc/translator/TmplTokenizer.pm @@ -1,6 +1,7 @@ package TmplTokenizer; use strict; +#use warnings; FIXME - Bug 2505 use TmplTokenType; use TmplToken; use VerboseWarnings qw( pedantic_p error_normal warn_normal warn_pedantic ); diff --git a/misc/translator/VerboseWarnings.pm b/misc/translator/VerboseWarnings.pm index 05fd9e5ada..e2d57dd491 100644 --- a/misc/translator/VerboseWarnings.pm +++ b/misc/translator/VerboseWarnings.pm @@ -1,6 +1,7 @@ package VerboseWarnings; use strict; +#use warnings; FIXME - Bug 2505 require Exporter; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK %EXPORT_TAGS); From 23a19c6c9ab7a31584a452f56e870586f4cbcaee Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 12:02:46 +1200 Subject: [PATCH 20/24] Bug 2505 - Add commented use warnings where missing in *.t --- t/Boolean.t | 1 + t/db_dependent/VirtualShelves.t | 1 + 2 files changed, 2 insertions(+) diff --git a/t/Boolean.t b/t/Boolean.t index f0d2cc1c87..4810833643 100755 --- a/t/Boolean.t +++ b/t/Boolean.t @@ -2,6 +2,7 @@ # use strict; +#use warnings; FIXME - Bug 2505 use C4::Boolean; use vars qw( @tests ); diff --git a/t/db_dependent/VirtualShelves.t b/t/db_dependent/VirtualShelves.t index 75f366bb76..f4110faa8e 100755 --- a/t/db_dependent/VirtualShelves.t +++ b/t/db_dependent/VirtualShelves.t @@ -7,6 +7,7 @@ use Test; use strict; +#use warnings; FIXME - Bug 2505 use C4::Context; # Making 30 tests. From 1726a0625314d59fa784b064d11da62ead954ac9 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 15:13:10 +1200 Subject: [PATCH 21/24] Bug 2505 - add strict and warnings to check_sysprefs --- misc/check_sysprefs.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/misc/check_sysprefs.pl b/misc/check_sysprefs.pl index 68238087e9..0d06fde901 100755 --- a/misc/check_sysprefs.pl +++ b/misc/check_sysprefs.pl @@ -5,10 +5,11 @@ # export PERL5LIB # then ./check_sysprefs.pl path (if path is blank it will use .) -#use strict; -#use warnings; FIXME - Bug 2505 +use strict; +use warnings; use File::Find; + use C4::Context; @ARGV = qw(.) unless @ARGV; @@ -38,5 +39,5 @@ sub check_sys_pref { } $sth->finish(); } - + find(\&check_sys_pref,@ARGV); From 5647479f70e5cc822faecd1854dae2368d2611fa Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 15:17:27 +1200 Subject: [PATCH 22/24] Bug 2505 - add strict and warnings to perlmodule_ls --- misc/perlmodule_ls.pl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/misc/perlmodule_ls.pl b/misc/perlmodule_ls.pl index 6ffcc528fd..d381b6ee62 100755 --- a/misc/perlmodule_ls.pl +++ b/misc/perlmodule_ls.pl @@ -1,11 +1,12 @@ #!/usr/bin/perl -#use strict; -#use warnings; FIXME - Bug 2505 +use strict; +use warnings; use ExtUtils::Installed; + my $instmod = ExtUtils::Installed->new(); foreach my $module ($instmod->modules()) { -my $version = $instmod->version($module) || "???"; - print "$module -- $version\n"; + my $version = $instmod->version($module) || "???"; + print "$module -- $version\n"; } From 36d43bab0ab29d49b6ced672633f52aff1ffeaae Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 15:21:35 +1200 Subject: [PATCH 23/24] Bug 2505 - enable warnings for link_bibs_to_authorities --- misc/link_bibs_to_authorities.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/link_bibs_to_authorities.pl b/misc/link_bibs_to_authorities.pl index e3f9bdc824..0fc9c26f1a 100755 --- a/misc/link_bibs_to_authorities.pl +++ b/misc/link_bibs_to_authorities.pl @@ -1,7 +1,7 @@ #!/usr/bin/perl use strict; -#use warnings; FIXME - Bug 2505 +use warnings; BEGIN { # find Koha's Perl modules # test carefully before changing this From 3e4044ad5c82d43ec5b69bd016243600ae2c5599 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Mon, 19 Apr 2010 16:17:10 +1200 Subject: [PATCH 24/24] Bug 2505 - use strict and warnings in sax_parser_test --- misc/sax_parser_test.pl | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/misc/sax_parser_test.pl b/misc/sax_parser_test.pl index c99f07bad2..b2e597405c 100755 --- a/misc/sax_parser_test.pl +++ b/misc/sax_parser_test.pl @@ -1,13 +1,17 @@ #!/usr/bin/perl -#use strict; -#use warnings; FIXME - Bug 2505 + +use strict; +use warnings; + use XML::SAX; +use Encode; + my $parser = XML::SAX::ParserFactory->parser( Handler => MySAXHandler->new ); binmode STDOUT, ":utf8"; -print "\x{65}\x{301}\n"; -use Encode; $parser->parse_string(encode_utf8("\x{65}\x{301}")); +print "\x{65}\x{301}\n"; +$parser->parse_string(encode_utf8("\x{65}\x{301}")); $parser->parse_string("\xEF\xBB\xBF\x{65}\x{301}"); package MySAXHandler;