gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 43225: Fix punctuation for renewal confirmation message 

A renewal confirmation message (when the AllowFineOverrideRenewing
system preference is set to "Allow") is missing a period and space
between the amount due and the second sentence.

It currently reads:
"The patron has a debt of [amount]Are you sure you want to renew checkout(s)?"

Test plan:
1. Set the AllowFineOverrideRenewing system preference to "Allow".
2. Check out an item to a patron (for example, 39999000011418 to Mary Burton).
3. Add a $110 manual charge to the patron's account:
   - [Patron account] > Accounting > Create manual invoice
   - Should now have a message on the patron's page:
     Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges
4. Attempt to renew the checked out item from the checkouts section:
   - Check out > Checkouts > Show checkouts
   - Below the checkouts table, select "Override fine restrictions"
   - Click "Renew all"
5. There is a pop-up message with incorrect punctuation:
     The patron has a debt of 110.00Are you sure you want to renew checkout(s)?
6. Click the cancel option.
7. Repeat steps 4 to 6 from the details section (Details > Checkouts >
   Show checkouts) and note the same incorrect punctuation.
8. Apply the patch.
9. Repeat steps 4 to 7.
10. The pop-up message now reads:
      The patron has a debt of 110.00. Are you sure you want to renew checkout(s)?
11. Sign off.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
David Nind 2026-08-04 22:00:58 +00:00 committed by Pedro Amorim
parent 448419f918
commit b8d1993582
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
View File

@ -1226,7 +1226,7 @@
};
}
var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines);
var MSG_CONFIRM_RENEW = _("The patron has a debt of %s.").format(fines) + " ";
MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?");
// On-site checkout

2
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
View File

@ -912,7 +912,7 @@
[% Asset.js("js/throttledButton.js") | $raw %]
[% Asset.js("js/hold-group.js") | $raw %]
<script nonce="[% Koha.CSPNonce | $raw %]">
var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines);
var MSG_CONFIRM_RENEW = _("The patron has a debt of %s.").format(fines) + " ";
MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?");
function uncheck_sibling(me) {