From b8d19935825244a4720b8622b5ca599d129cd0e2 Mon Sep 17 00:00:00 2001 From: David Nind Date: Tue, 4 Aug 2026 22:00:58 +0000 Subject: [PATCH] Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Andrew Fuerste Henry Signed-off-by: Pedro Amorim --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 9d44f1de22..8257174802 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -1226,7 +1226,7 @@ }; } - var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines); + var MSG_CONFIRM_RENEW = _("The patron has a debt of %s.").format(fines) + " "; MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?"); // On-site checkout diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index 0e61a6d8d4..8ffac93803 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -912,7 +912,7 @@ [% Asset.js("js/throttledButton.js") | $raw %] [% Asset.js("js/hold-group.js") | $raw %]