Bug 38470: Add missing double quotes to some Javascript

This change adds some double quotes where quotes were missing,
and replaces single quotes with double quotes, which prevents XSS.

Test plan:
0. Apply the patch
1. Create a subscription
2. Using the ID from the subscription, go to this page:
http://localhost:8081/cgi-bin/koha/serials/subscription-detail.pl?
print_routing_list_issue=1&subscriptionid=<SUBSCRIPTIONID>

3. Note that you're able to generate a print slip
(You may need to allow popups)

4. To check the security vulnerability is fixed, try the proof-of-concepts
attached to the bug report

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit e4295598a2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 9933fb21e9)
Signed-off-by: JesseM <jesse@bywatersolutions.com>
This commit is contained in:
David Cook 2024-11-18 05:15:26 +00:00 committed by JesseM
parent 6841c6001e
commit b47b2bac27
1 changed files with 1 additions and 1 deletions

View File

@ -455,7 +455,7 @@
$(document).ready(function() {
$("#renewsub").click(function(){
popup([% subscriptionid | html %]);
popup("[% subscriptionid | html %]");
return false;
})