From b47b2bac27facaadcab181fbdb2e7071a0f1a8ec Mon Sep 17 00:00:00 2001 From: David Cook Date: Mon, 18 Nov 2024 05:15:26 +0000 Subject: [PATCH] Bug 38470: Add missing double quotes to some Javascript This change adds some double quotes where quotes were missing, and replaces single quotes with double quotes, which prevents XSS. Test plan: 0. Apply the patch 1. Create a subscription 2. Using the ID from the subscription, go to this page: http://localhost:8081/cgi-bin/koha/serials/subscription-detail.pl? print_routing_list_issue=1&subscriptionid= 3. Note that you're able to generate a print slip (You may need to allow popups) 4. To check the security vulnerability is fixed, try the proof-of-concepts attached to the bug report Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Julian Maurice Signed-off-by: Paul Derscheid Signed-off-by: wainuiwitikapark (cherry picked from commit e4295598a2b07f5e102b0fec4c206c0b4f394525) Signed-off-by: Fridolin Somers (cherry picked from commit 9933fb21e9f303a1033df67184b375a7febad5a4) Signed-off-by: JesseM --- .../prog/en/modules/serials/subscription-detail.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt index 38ce2cc818..f58f4f1a75 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt @@ -455,7 +455,7 @@ $(document).ready(function() { $("#renewsub").click(function(){ - popup([% subscriptionid | html %]); + popup("[% subscriptionid | html %]"); return false; })