Bug 20794: Hide holds tab on details when user lacks circulate_remaining_permissions
If a user doesn't have circulate_remaining permissions, but has borrowers: - checkouts tab is hidden - details tab is visible - holds tab on details is visible, but results in an error The problem is that the svc/holds script requires circulate_remaining_permissions. To test: - Create 2 staff users with and without circulate_remaining_permissions Both need borrowers permission - Go to the details tab in a patron's account who has holds - Verify that you get a datatables error for the staff patron without circulate_remaining_permissions - Apply patch - Verify that now the holds tab is no longer displayed for this patron Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
This commit is contained in:
parent
279e328cdd
commit
b3d1a5bfec
|
|
@ -412,6 +412,7 @@
|
|||
<li><a href="#relatives-issues" id="relatives-issues-tab">Relatives' checkouts</a></li>
|
||||
[% END %]
|
||||
<li><a href="#finesandcharges">Fines & Charges</a></li>
|
||||
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
|
||||
<li>
|
||||
[% IF ( holds_count ) %]
|
||||
<a href="#reserves" id="holds-tab">[% holds_count %] Hold(s)</a>
|
||||
|
|
@ -419,6 +420,7 @@
|
|||
<a href="#reserves" id="holds-tab">0 Holds</a>
|
||||
[% END %]
|
||||
</li>
|
||||
[% END %]
|
||||
[% IF Koha.Preference('ArticleRequests') %]
|
||||
<li>
|
||||
<a href="#article-requests" id="article-requests-tab"> [% patron.article_requests_current.count %] Article requests</a>
|
||||
|
|
@ -478,6 +480,7 @@
|
|||
|
||||
[% INCLUDE borrower_debarments.inc %]
|
||||
|
||||
[% IF ( CAN_user_circulate_circulate_remaining_permissions ) %]
|
||||
<div id="reserves">
|
||||
[% IF ( holds_count ) %]
|
||||
<form action="/cgi-bin/koha/reserve/modrequest.pl" method="post">
|
||||
|
|
@ -530,7 +533,7 @@
|
|||
|
||||
[% ELSE %]<p>Patron has nothing on hold.</p>[% END %]
|
||||
</div>
|
||||
|
||||
[% END %]
|
||||
|
||||
[% IF Koha.Preference('ArticleRequests') %]
|
||||
[% INCLUDE 'patron-article-requests.inc' %]
|
||||
|
|
|
|||
Loading…
Reference in New Issue