Bug 42286: Tidy all script tags - ill

In order to tidy all the script tags of the .tt files we isolate the
interpolation of Template::Toolkit variables in a separate script tag.

This patch focuses on the ILL module.

I don't really know how to test this patch...

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Jonathan Druart 2026-03-30 14:10:17 +02:00 committed by Pedro Amorim
parent c355bb8574
commit 71cd1efd7d
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
1 changed files with 12 additions and 15 deletions

View File

@ -88,12 +88,6 @@
[% UNLESS blocking_error %]
[% IF op == 'illlist' %]
<script nonce="[% Koha.CSPNonce | $raw %]">
var ill_table_actions = [% table_actions | $raw %];
</script>
[% END %]
<div id="interlibraryloans">
[% IF !backends_available || !has_branch || ill_deprecated_backend_freeform_is_installed %]
<div class="alert alert-info">ILL module configuration problem. Take a look at the <a href="/cgi-bin/koha/about.pl?tab=sysinfo">about page</a></div>
@ -1132,20 +1126,22 @@
[% IF op == 'edit_action' %]
[% INCLUDE 'select_manager.inc' add_modal => 1, manager => request.manager, filter => 'ill_users' %]
[% END %]
[% IF metadata_enrichment_services %]
<script nonce="[% Koha.CSPNonce | $raw %]">
<script nonce="[% Koha.CSPNonce | $raw %]" data-tt-allowed="true">
[% IF op == 'illlist' %]
var ill_table_actions = [% table_actions | $raw %];
[% END %]
[% IF metadata_enrichment_services %]
var ill_check_availability_syspref = '[% Koha.Preference('ILLCheckAvailability') | html %]';
var metadata_enrichment_services = [% metadata_enrichment_services | $raw %];
</script>
<script nonce="[% Koha.CSPNonce | $raw %]">
[% IF batch_availability_services %]
var batch_availability_services = [% batch_availability_services | $raw %];
var batch_availability_services = [% batch_availability_services | $raw %];
[% ELSE %]
var batch_availability_services = [];
var batch_availability_services = [];
[% END %]
</script>
[% END %]
<script nonce="[% Koha.CSPNonce | $raw %]">
[% END %]
var prefilters = '[% prefilters | $raw %]';
// Set column settings
var table_settings = [% TablesSettings.GetTableSettings( 'illrequests', 'ill-requests', 'ill-requests', 'json' ) | $raw %];
@ -1164,6 +1160,7 @@
var metadata = "[% metadata | $raw %]";
[% END %]
</script>
<script nonce="[% Koha.CSPNonce | $raw %]">
$("#ill_checkout_inhouse_select").on("change", function () {
if ($(this).val().length > 0) {