From 71cd1efd7dd8cbab108569ad8daad102f8d5ecbe Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 30 Mar 2026 14:10:17 +0200
Subject: [PATCH] Bug 42286: Tidy all script tags - ill

In order to tidy all the script tags of the .tt files we isolate the
interpolation of Template::Toolkit variables in a separate script tag.

This patch focuses on the ILL module.

I don't really know how to test this patch...

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Signed-off-by: Jan Kissig <bibliothek@th-wildau.de>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
---
 .../prog/en/modules/ill/ill-requests.tt       | 27 +++++++++----------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
index 302b9054f2..1e193570c1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
@@ -88,12 +88,6 @@
 
     [% UNLESS blocking_error %]
 
-        [% IF op == 'illlist' %]
-            <script nonce="[% Koha.CSPNonce | $raw %]">
-                var ill_table_actions = [% table_actions | $raw %];
-            </script>
-        [% END %]
-
         <div id="interlibraryloans">
             [% IF !backends_available || !has_branch || ill_deprecated_backend_freeform_is_installed %]
                 <div class="alert alert-info">ILL module configuration problem. Take a look at the <a href="/cgi-bin/koha/about.pl?tab=sysinfo">about page</a></div>
@@ -1132,20 +1126,22 @@
         [% IF op == 'edit_action' %]
             [% INCLUDE 'select_manager.inc' add_modal => 1, manager => request.manager, filter => 'ill_users' %]
         [% END %]
-        [% IF metadata_enrichment_services %]
-            <script nonce="[% Koha.CSPNonce | $raw %]">
+
+        <script nonce="[% Koha.CSPNonce | $raw %]" data-tt-allowed="true">
+            [% IF op == 'illlist' %]
+                var ill_table_actions = [% table_actions | $raw %];
+            [% END %]
+
+            [% IF metadata_enrichment_services %]
                 var ill_check_availability_syspref = '[% Koha.Preference('ILLCheckAvailability') | html %]';
                 var metadata_enrichment_services = [% metadata_enrichment_services | $raw %];
-            </script>
-            <script nonce="[% Koha.CSPNonce | $raw %]">
                 [% IF batch_availability_services %]
-                var batch_availability_services = [% batch_availability_services | $raw %];
+                    var batch_availability_services = [% batch_availability_services | $raw %];
                 [% ELSE %]
-                var batch_availability_services = [];
+                    var batch_availability_services = [];
                 [% END %]
-            </script>
-        [% END %]
-        <script nonce="[% Koha.CSPNonce | $raw %]">
+            [% END %]
+
             var prefilters = '[% prefilters | $raw %]';
             // Set column settings
             var table_settings = [% TablesSettings.GetTableSettings( 'illrequests', 'ill-requests', 'ill-requests', 'json' ) | $raw %];
@@ -1164,6 +1160,7 @@
             var metadata = "[% metadata | $raw %]";
             [% END %]
         </script>
+
         <script nonce="[% Koha.CSPNonce | $raw %]">
             $("#ill_checkout_inhouse_select").on("change", function () {
                 if ($(this).val().length > 0) {