gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 24767: Hide the "Claim returned" tab if the feature is turned off 

The ability to claim an item "claim returned" is not there if the syspref is empty, however, the Claim Returned tab is stil present on the patrons detail page.

Test Plan:
1) Ensure ClaimReturnedLostValue is not set
2) Note the claims tabs on the circulation and patron details pages
3) Apply this patch
4) Refresh those pages
5) The claims tabs should be gone!

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
This commit is contained in:
Kyle M Hall 2020-03-12 07:07:48 -04:00 committed by Joy Nelson
parent 572c3afef1
commit 5d4f396c7e
2 changed files with 44 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
View File

@ -860,23 +860,25 @@
</li>
[% END %]
<li>
[% IF ( patron.return_claims.count ) %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
/
<span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
Claim(s)
</a>
[% ELSE %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">0</span>
/
<span id="return-claims-count-unresolved">0</span>
Claim(s)
</a>
[% END %]
</li>
[% IF Koha.Preference('ClaimReturnedLostValue') %]
<li>
[% IF ( patron.return_claims.count ) %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
/
<span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
Claim(s)
</a>
[% ELSE %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">0</span>
/
<span id="return-claims-count-unresolved">0</span>
Claim(s)
</a>
[% END %]
</li>
[% END %]
<li><a id="debarments-tab-link" href="#reldebarments">[% debarments.count | html %] Restrictions</a></li>
@ -961,7 +963,9 @@
[% END # /IF holds_count %]
</div> <!-- /#reserves -->
[% INCLUDE 'patron-return-claims.inc' %]
[% IF Koha.Preference('ClaimReturnedLostValue') %]
[% INCLUDE 'patron-return-claims.inc' %]
[% END %]
[% IF Koha.Preference('ArticleRequests') %]
[% INCLUDE 'patron-article-requests.inc' %]

40
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
View File

@ -719,23 +719,25 @@
</li>
[% END %]
<li>
[% IF ( patron.return_claims.count ) %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
/
<span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
Claim(s)
</a>
[% ELSE %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">0</span>
/
<span id="return-claims-count-unresolved">0</span>
Claim(s)
</a>
[% END %]
</li>
[% IF Koha.Preference('ClaimReturnedLostValue') %]
<li>
[% IF ( patron.return_claims.count ) %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">[% patron.return_claims.resolved.count | html %]</span>
/
<span id="return-claims-count-unresolved">[% patron.return_claims.unresolved.count | html %]</span>
Claim(s)
</a>
[% ELSE %]
<a href="#return-claims" id="return-claims-tab">
<span id="return-claims-count-resolved">0</span>
/
<span id="return-claims-count-unresolved">0</span>
Claim(s)
</a>
[% END %]
</li>
[% END %]
<li>
<a id="debarments-tab-link" href="#reldebarments">[% debarments.size | html %] Restrictions</a>
@ -829,7 +831,9 @@
</div> [% # /div#reserves %]
[% END %]
[% INCLUDE 'patron-return-claims.inc' %]
[% IF Koha.Preference('ClaimReturnedLostValue') %]
[% INCLUDE 'patron-return-claims.inc' %]
[% END %]
[% IF Koha.Preference('ArticleRequests') %]
[% INCLUDE 'patron-article-requests.inc' %]