gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug 42330: (QA follow-up) Fix file permissions on new test and tidy 

This patch
- Fixes the file permissions on the new test
- Removes a variable declaration from the new test that's unused
- Removes a new line from the end of staff-global.scss

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
This commit is contained in:
Lisette Scheer 2026-07-22 18:10:50 +00:00 committed by Pedro Amorim
parent 6cb0f5161c
commit 2aa2cc0e7f
No known key found for this signature in database
GPG Key ID: 06B75BA7F3894D55
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
xt/find-missing-main-container.t Normal file → Executable file
View File

@ -28,7 +28,7 @@ my $dev_files = Koha::Devel::Files->new( { context => 'core' } );
my @tt_files = $dev_files->ls_tt_files; my @tt_files = $dev_files->ls_tt_files;
# Only for staff # Only for staff
@tt_files = grep {m{/intranet-tmpl/}} @tt_files; @tt_files = grep { m{/intranet-tmpl/} } @tt_files;
my @exceptions = qw( my @exceptions = qw(
koha-tmpl/intranet-tmpl/prog/en/includes/main-container.inc koha-tmpl/intranet-tmpl/prog/en/includes/main-container.inc
@ -42,12 +42,14 @@ plan tests => scalar(@tt_files) + 1;
for my $file (@tt_files) { for my $file (@tt_files) {
my @lines = read_file($file); my @lines = read_file($file);
my ( $has_main, $has_main_container_fluid ); my $has_main;
for my $line (@lines) { for my $line (@lines) {
#$has_main_container_fluid = 1 if $line =~ m{<div class="main container-fluid">}; #$has_main_container_fluid = 1 if $line =~ m{<div class="main container-fluid">};
$has_main = 1 if $line =~ m{<main>}; $has_main = 1 if $line =~ m{<main>};
} }
ok( !$has_main, qq{$file has '<main>', it must use main-container.inc instead.} ); ok( !$has_main, qq{$file has '<main>', it must use main-container.inc instead.} );
#is( $has_main_container_fluid, 0, qq{$file has '<div class="main container-fluid">', it must use main-container.inc instead.} ); #is( $has_main_container_fluid, 0, qq{$file has '<div class="main container-fluid">', it must use main-container.inc instead.} );
} }