From 2aa2cc0e7f5c386c513b6d82c6d3c0628b2b19ea Mon Sep 17 00:00:00 2001 From: Lisette Scheer Date: Wed, 22 Jul 2026 18:10:50 +0000 Subject: [PATCH] Bug 42330: (QA follow-up) Fix file permissions on new test and tidy This patch - Fixes the file permissions on the new test - Removes a variable declaration from the new test that's unused - Removes a new line from the end of staff-global.scss Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim --- koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 2 +- xt/find-missing-main-container.t | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) mode change 100644 => 100755 xt/find-missing-main-container.t diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 2f0657a8c2..c48b5405c0 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -5230,4 +5230,4 @@ div .suggestion_note { background-color: #FFF; border-color: #666; } -} +} \ No newline at end of file diff --git a/xt/find-missing-main-container.t b/xt/find-missing-main-container.t old mode 100644 new mode 100755 index 4e485b0a39..300223f67f --- a/xt/find-missing-main-container.t +++ b/xt/find-missing-main-container.t @@ -28,7 +28,7 @@ my $dev_files = Koha::Devel::Files->new( { context => 'core' } ); my @tt_files = $dev_files->ls_tt_files; # Only for staff -@tt_files = grep {m{/intranet-tmpl/}} @tt_files; +@tt_files = grep { m{/intranet-tmpl/} } @tt_files; my @exceptions = qw( koha-tmpl/intranet-tmpl/prog/en/includes/main-container.inc @@ -42,12 +42,14 @@ plan tests => scalar(@tt_files) + 1; for my $file (@tt_files) { my @lines = read_file($file); - my ( $has_main, $has_main_container_fluid ); + my $has_main; for my $line (@lines) { + #$has_main_container_fluid = 1 if $line =~ m{
}; $has_main = 1 if $line =~ m{
}; } ok( !$has_main, qq{$file has '
', it must use main-container.inc instead.} ); + #is( $has_main_container_fluid, 0, qq{$file has '
', it must use main-container.inc instead.} ); }