As requested on comment99. Personally I do not feel that it
should be a requirement for adding a koha-conf entry though.
Note that koha-create does/did not even support adding multiple
line entries to koha-conf like we do here now.
But it might be a start for adding them?
Test plan:
The following tweak might help you to test without running the
complete koha-create, while still convincing you:
[1] cp debian/templates/koha-conf-site.xml.in /etc/koha/test.conf
[2] Add the following line in debian/scripts/koha-create. Append
if after the BCRYPT_SETTINGS= line on L652:
generate_config_file test.conf test.xml; exit
[3] Run debian/scripts/koha-create --keep-cookie A
[4] Check if you see <do_not_remove_cookie>A<..> in test.xml.
[5] Run debian/scripts/koha-create --keep-cookie A --keep-cookie B
[6] Check for two lines in test.xml
[7] Run debian/scripts/koha-create clone_name
[8] Check that the __KEEP_COOKIE__ line is gone in test.xml.
[9] Undo the tweak by removing test.xml and /etc/koha/test.conf,
and removing the added line from koha-create.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
|
||
|---|---|---|
| .. | ||
| SIPconfig.xml | ||
| apache-shared-disable.conf | ||
| apache-shared-intranet-plack.conf | ||
| apache-shared-intranet.conf | ||
| apache-shared-opac-plack.conf | ||
| apache-shared-opac.conf | ||
| apache-shared.conf | ||
| apache-site-https.conf.in | ||
| apache-site.conf.in | ||
| koha-common.conf | ||
| koha-conf-site.xml.in | ||
| koha-core.conf | ||
| koha-sites.conf | ||
| koha-worker@.service | ||
| log4perl-site.conf.in | ||
| marc21-retrieval-info-auth-dom.xml | ||
| marc21-retrieval-info-bib-dom.xml | ||
| plack.psgi | ||
| unimarc-retrieval-info-auth-dom.xml | ||
| unimarc-retrieval-info-bib-dom.xml | ||
| zebra-authorities-dom-site.cfg.in | ||
| zebra-biblios-dom-site.cfg.in | ||
| zebra.passwd.in | ||