gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Jonathan Druart 23ed6dd88f Bug 9942: Make Koha fail if privacy is not respected 
If a patron has requested anonymity on returning items and the system is
not correctly configured (AnonymousPatron no set or set to an inexistent
patron), the application should take it into account and not fail
quietly.

This patch is quite radical: the script will die loudly if the privacy
is not respected.

To be care of the bad "Software error", some checks are done in the
updatedatabase to be sure the admin will be warned is something is wrong
in the configuration.

Test plan:
1/ Test the updatedatabase entry:
a. Turn on OPACPrivacy and set AnonymousPatron to an existing patron
=> You will get a warning
b. Turn on OPACPrivacy and set AnonymousPatron to 0 or ''
=> You will get a warning
c. Turn on OPACPrivacy and set the privacy to 2 (Never) for at least 1 patron
Turn off OPACPrivacy
=> You will get a warning
d. In all other cases you will get no error

2/ Test the interface
a. Turn on OPACPrivacy and set the privacy to 2 (Never) for a patron
b. Now you can turn off OPACPrivacy or keep it on, behavior should be
the same
c. check an item out the patron
d. Check the item in using the check out table
=> fail
e. Check the item in using the Check in tab
=> fail (not gracefully).

Note that the software error could appear on other pages too.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Updatedatabase works as described
On staff, if don't have correct settings for anonymity it's
impossible to check-in (with OPACPrivacy on)
No errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
(cherry picked from commit 94315f663b)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
 		2015-07-14 11:53:12 +12:00
..
Acquisition Bug 12743: ACQ: default values for catalogue records 2015-05-11 10:10:41 -03:00
Circulation Bug 9942: Make Koha fail if privacy is not respected 2015-07-14 11:53:12 +12:00
Holds Bug 11126: (RM followup) remove diags from tests 2014-11-04 18:59:42 -03:00
Items Bug 14057: Inventory is painfully slow 2015-05-06 10:40:23 -03:00
Koha Bug 14057: Inventory is painfully slow 2015-05-06 10:40:23 -03:00
LDAP
…
Labels Bug 14204: (QA followup) remove unneeded messages 2015-05-15 15:34:22 -03:00
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 12847: Items issued today is considered as overdue 2015-04-20 09:57:25 -03:00
OAI Bug 13940 : (QA followup) Add test for ModOAISet 2015-04-09 11:56:53 -03:00
Record Bug 12404: Allow equal sign '=' in the TT directive 2015-04-27 10:43:23 -03:00
Reports Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Search Bug 11430: (QA followup) we test for warnings, always 2015-03-11 15:14:24 -03:00
Serials Bug 12671: Guess next serial date when there are several issues per unit. Added support for real month and year lenghts. 2015-05-05 15:22:10 -03:00
Template/Plugin Bug 7380: Add tests for TT plugins 2015-05-19 10:10:31 -03:00
Utils Bug 13419: (follow-up) fix call to set_userenv 2015-04-22 14:59:10 -03:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
www Bug 13579: Prefer like instead of ok to match a regex 2015-01-14 12:24:29 -03:00
00-strict.t Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) 2014-04-29 19:34:23 +00:00
Accounts.t Bug 13942 : Testing the 'recordpayment' function in C4::Accounts 2015-04-13 11:53:45 -03:00
Acquisition.t Bug 11006: Drop column aqorders.totalamount 2015-05-14 11:11:58 -03:00
Amazon.t
…
Auth.t Bug 14439: Add test - template path should finish by .tt 2015-07-14 09:12:44 +12:00
Auth_with_cas.t Bug 5010: Fix OPACBaseURL to include protocol 2015-06-07 19:47:49 +12:00
Auth_with_ldap.t Bug 12831: (RM followup) regression test 2014-11-27 14:45:11 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 13606: Add tests and fix existing ones 2015-04-23 13:18:49 -03:00
Barcodes.t Bug 13673: (QA followup) Add license 2015-05-15 16:00:28 -03:00
Biblio.t Bug 12674: (regression tests) GetMarcISSN should not return empty ISSN 2014-09-01 10:42:08 -03:00
Bookseller.t Bug 10900 - Follow up, since more has been added to master 2015-02-09 17:00:15 -03:00
Borrower.t Bug 13019: (follow-up) Remove smartmatch operator 2015-02-12 15:21:03 -03:00
Borrower_Debarments.t Bug 12416: add new tests of DelUniqueDebarment 2014-06-22 19:59:04 -03:00
Borrower_Discharge.t Bug 14325: Test calls C4::Context::set_userenv 2015-06-07 19:42:02 +12:00
Borrower_Files.t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-11 16:16:11 -03:00
Borrowers.t Bug 13019 [QA Followup] - Allow find() and search() to be called as static methods 2015-02-12 15:21:05 -03:00
Branch.t Bug 9530: Follow-up - Fix t/db_dependent/Branch.t 2014-10-28 09:26:03 -03:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 12958: Set a fund owner to a fund hierarchy 2014-10-31 16:18:49 -03:00
Category.t Bug 12604: refactoring Category.t with TestBuilder 2015-04-20 10:12:08 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
Circulation.t Bug 13919: Make the tests pass fixing the number of tests 2015-04-28 15:11:34 -03:00
Circulation_Branch.t
…
Circulation_Issuingrule.t Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Circulation_OfflineOperation.t
…
Circulation_issue.t Bug 13315: (QA followup) fix t/db_dependent/Circulation_issue.t 2015-04-13 15:15:31 -03:00
Circulation_issuingrules.t Bug 11934: (follow-up) tidy up whitespace 2014-03-13 15:18:49 +00:00
Circulation_transfers.t Bug 12122: TransferSlip should accept both itemnumber and barcode 2015-03-05 11:47:12 +01:00
ClassSource.t
…
ColumnsSettings.t Bug 10212: Columns configuration for tables - Unit tests 2014-08-26 09:28:18 -03:00
Context.t Bug 5010: Fix OPACBaseURL to include protocol 2015-06-07 19:47:49 +12:00
Contract.t Bug 12487: SQLHelper replacement - C4::Contract 2014-07-30 10:44:11 -03:00
CourseReserves.t
…
Csv.t
…
External_BakerTaylor.t
…
FrameworkPlugin.t Bug 10480: New module and unit test for framework plugins 2015-04-16 14:48:35 -03:00
Heading_MARC21.t
…
Holds.t Bug 13687: Move hold policy check into CanItemBeReserved 2015-05-19 12:05:50 -03:00
HoldsQueue.t Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
Holidays.t Bug 13451: Holidays.t assumes default data 2014-12-17 19:24:50 -03:00
ILSDI_Services.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
ImportBatch.t Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio 2015-04-16 13:40:59 -03:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 13713: Follow-up removing biblioitem routines 2015-03-19 14:06:01 -03:00
Items_DelItem.t Bug 12583: (followup) rename new test file 2014-07-26 10:17:09 -03:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 13453: Koha.t daily quote tests assume sample data 2014-12-28 19:52:51 -03:00
Koha_Authority.t Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t Bug 3050: QA follow-up 2014-05-25 21:15:03 +00:00
Koha_borrower_modifications.t Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
Koha_template_plugin_Branches.t Bug 10900 - Follow up, since more has been added to master 2015-02-09 17:00:15 -03:00
Koha_template_plugin_KohaDates.t Bug 12669: Centralize the timezone handle into Koha::DateUtils 2015-02-20 10:20:30 -03:00
Languages.t Bug 14030 - Added tests for duplicates. 2015-04-24 09:55:54 -03:00
Letters.t Bug 14206: Adds test for getletter() call from overdue_notices.pl 2015-06-15 09:04:59 +12:00
Linker_FirstMatch.t
…
Log.t Bug 13889: Add unit tests 2015-05-04 11:11:32 -03:00
MarcModificationTemplates.t Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Members.t Bug 12633: Remove SQLHelper in C4::Members 2015-05-15 15:38:05 -03:00
Members_Attributes.t Bug 12427: Allow execution of UTs on a DB with issues 2014-06-24 09:43:04 -03:00
Members_columns.t
…
MungeMarcPrice.t Bug 9593: (follow-up) don't make currency.isocode required 2014-05-04 22:21:17 +00:00
NewsChannels.t Bug 7567: (follow-up) make tests of get_opac_new more readable 2014-04-07 18:14:20 +00:00
Overdues.t Bug 9180: All branches should be returned if a default rule exists 2014-08-19 09:29:51 -03:00
PatronLists.t
…
Plugins.t Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
QueryParser.t Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
Ratings.t Bug 13998: (RM followup) tests expect data on the database 2015-04-21 13:53:40 -03:00
Record.t Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Reports.t
…
ReportsGuided.t Bug 13141: (QA Followup) Update number of unit tests 2014-10-31 13:15:06 -03:00
Reports_Guided.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
Reserves.t Bug 5786 - Move AllowOnShelfHolds and OPACItemHolds system prefs to the Circulation Matrix 2015-03-25 10:33:14 -03:00
Review.t Bug 13969: (QA followup) Delete issues before borrowers 2015-05-14 11:11:46 -03:00
RotatingCollections.t Bug 8836: (RM followup) unit tests should use the new API 2014-11-07 11:09:14 -03:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
Search.t Bug 13088: (RM followup) add missing pref mock 2014-10-28 12:07:46 -03:00
Search_SearchHistory.t Bug 10807: (follow-up) remove comment about routine that is no longer present 2014-05-05 02:58:29 +00:00
Serials.t Bug 13423: Fix number of tests in Serials.t 2015-05-14 11:48:17 -03:00
Serials_2.t Bug 5342: Serial claiming improvements: add a counter 2014-10-28 10:07:37 -03:00
Service.t
…
ShelfBrowser.t
…
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 13007: Special case budgetid == '' 2015-02-09 15:49:57 -03:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 14195: (followup) increment number of tests 2015-05-20 11:05:27 -03:00
UploadedFile.t
…
VirtualShelves.t Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate 2014-04-20 22:52:21 +00:00
VirtualShelves_Page.t
…
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2014-08-20 12:29:27 -03:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
check_sysprefs.t
…
default_search_class.pl Bug 12738: (regression tests) C4::Context should set keyword search as default for QueryParser 2014-08-11 10:05:59 -03:00
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
sysprefs.t
…
zebra_config.pl Bug 12651: DOM indexing is the default 2014-10-27 12:35:44 -03:00