f9820f38a8
To reproduce warns:
1) Go to Tools -> Notices & slips
2) Create a new notice of any module
Notice these warns:
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
Use of uninitialized value $code in regexp compilation at
/home/vagrant/kohaclone/tools/letter.pl line 265.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_svc_letters_get line 50, this
can lead to vulnerabilities. See the warning in "Fetching the value or
values of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
3) Create a new notice of the Circulation module
Notice this additional warn:
Use of uninitialized value $code in pattern match (m//) at
/home/vagrant/kohaclone/tools/letter.pl line 258.
To test:
4) Apply patch and refresh page
5) Run steps 1-3 again and confirm no warns show
Sponsored-by: Catalyst IT
Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| csv-profiles | ||
| quotes | ||
| access_files.pl | ||
| ajax-inventory.pl | ||
| automatic_item_modification_by_age.pl | ||
| background-job-progress.pl | ||
| batchMod.pl | ||
| batch_delete_records.pl | ||
| batch_record_modification.pl | ||
| batch_records_ajax.pl | ||
| cleanborrowers.pl | ||
| copy-holidays.pl | ||
| csv-profiles.pl | ||
| exceptionHolidays.pl | ||
| export.pl | ||
| holidays.pl | ||
| import_borrowers.pl | ||
| inventory.pl | ||
| koha-news.pl | ||
| letter.pl | ||
| manage-marc-import.pl | ||
| marc_modification_templates.pl | ||
| modborrowers.pl | ||
| newHolidays.pl | ||
| overduerules.pl | ||
| picture-upload.pl | ||
| quotes-upload.pl | ||
| quotes.pl | ||
| scheduler.pl | ||
| showdiffmarc.pl | ||
| stage-marc-import.pl | ||
| stockrotation.pl | ||
| tools-home.pl | ||
| upload-cover-image.pl | ||
| upload-file.pl | ||
| upload.pl | ||
| viewlog.pl | ||