gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
32,549 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Andrew Isherwood fca5a1cb3d Bug 21289: Fix "isa" bug during partner request 
We cannot call 'handle_commit_maybe' inside a 'try' block.
handle_commit_maybe redirects the client then calls 'exit', this is
interpreted as an error and the 'catch' block is erroneously called.

This patch moves the calling of 'handle_commit_maybe' outside the try
block, it will only be reached if everything inside the try block
suceeds.

To test:
1) Enable ILL and have the FreeForm backend available
2) Create a patron category to hold ILL "partners" to whom requests can
be sent. The category can be called anything, you should note the code
you assign
3) Create a patron that belongs to your new category, the patron must
have a primary email defined.
4) In your <interlibrary_loans> block in koha-conf.xml, ensure you have
a <partner_code> element, it should contain the code you assigned in
step 2
5) Create an ILL request using the FreeForm backend
6) Once the request is created, select the "Place request with partners"
button
7) Select your "partner" from the "Select partner libraries" box
8) Click "Send email"
9) TEST: Observe no errors are displayed in the UI

Signed-off-by: Barry Cannon <bc@interleaf.ie>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
 		2018-10-01 11:03:48 +00:00
C4 Bug 21196: Use replacement cost from the item type if not set at item level 2018-09-26 16:00:30 +00:00
Koha Bug 21396: Add 2 missing use statements in Koha::Account 2018-09-28 19:26:16 +00:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 16739: Show note instead of 500 error for 'Generate EDIFACT' when no EDI account is configured 2018-09-28 19:24:49 +00:00
admin Bug 17530: (QA follow-up) Replace our variable by cached value 2018-09-07 13:16:07 +00:00
api/v1 Bug 20944: OpenAPI spec for /patrons/{patron_id}/account/credits 2018-08-31 12:46:59 +00:00
authorities Bug 13406: (follow-up) Add styling classes to authority MARC detail display 2018-09-19 13:45:38 +00:00
basket Bug 16575: Irregular behaviour using window.print() followed by window.location.href 2018-07-19 16:12:56 +00:00
catalogue Bug 21248: Fix COinS carp in MARC details page on unknown record 2018-09-14 17:28:49 +00:00
cataloguing Bug 16424: Add framework support to advanced MARC editor 2018-09-28 19:01:50 +00:00
circ Bug 19383: (QA follow-up) Remove unused name variable 2018-08-30 19:52:49 +00:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20467: (QA follow-up) Display error if no or invalid course id is passed 2018-07-02 12:55:38 +00:00
debian Bug 21416: 'gr' option missing from ZEBRA_LANGUAGE options in koha-sites.conf 2018-09-28 19:43:03 +00:00
docs Bug 7143: Update about page for new dev - Alberto Martinez 2018-09-26 19:00:16 +00:00
errors Bug 19998: use Modern::Perl in error perl scripts 2018-02-05 09:45:48 -03:00
etc Bug 14302: (QA follow-up) Remove remaining file 2018-08-31 11:24:21 +00:00
ill Bug 21289: Fix "isa" bug during partner request 2018-10-01 11:03:48 +00:00
installer Bug 16690: Simplify SHOW GRANTS to work when connected 2018-10-01 10:56:16 +00:00
koha-tmpl Bug 13618: (follow-up) Pass opacuser_js from plugins as raw 2018-10-01 10:56:01 +00:00
labels Bug 20765: Fix search for items by acqdate in label batch 2018-09-15 21:20:19 +00:00
members Bug 21167: Fix price formatting on printed fee invoice and receipt 2018-09-28 19:41:36 +00:00
misc Bug 19620: Allow skipping of patrons with valid emails for Talking Tech 2018-09-26 19:05:37 +00:00
offline_circ Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl 2018-09-14 17:27:29 +00:00
opac Bug 20023: (QA follow-up) Tiny simplification 2018-09-26 16:03:14 +00:00
patron_lists Bug 19524: Use existing logged_in_user variable 2018-07-18 16:49:30 +00:00
patroncards Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image 2018-07-23 15:08:57 +00:00
plugins Bug 20011: use Modern::Perl in plugins perl scripts 2018-02-05 09:46:44 -03:00
reports Bug 20495: Remove get_saved_report 2018-07-02 12:06:54 +00:00
reserve Bug 19469: (QA follow-up) Use hold item's itemtype if available, fix priority changing 2018-09-14 17:50:19 +00:00
reviews Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
rotating_collections Bug 21183: Replace C4::Items::GetItemnumberFromBarcode calls 2018-08-30 13:40:35 +00:00
serials Bug 20241: Fix display of publication year in subscription record search for MARC21 2018-09-28 19:35:15 +00:00
services Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
suggestion Bug 21048: (QA follow-up) Fix authorized value statuses in filter 2018-08-08 20:58:23 +00:00
svc Bug 16424: (QA follow-up) Use Modern::Perl 2018-09-28 19:01:51 +00:00
t Bug 20669: Add upgrade method to plugins 2018-09-26 16:29:05 +00:00
tags Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 21333: Add ability to add to basket from a new file 2018-09-26 19:05:53 +00:00
virtualshelves Bug 19039: (follow-up) Results of virtual shelves (lists) not sortable by date 2018-08-24 16:23:27 +00:00
xt Bug 13618: Fix wrong condition in xt tests 2018-08-17 16:54:37 +00:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Update mailmap - Jonathan Druart 2017-06-21 12:42:19 -03:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-11-22 11:29:07 +00:00
Koha.pm Bug 5458: DBRev 18.06.00.032 2018-09-26 16:17:06 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 19817: Remove local help files + edit help feature 2018-09-06 17:32:27 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
changelanguage.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
gulpfile.js Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 20019: use Modern::Perl in misc perl scripts 2018-02-05 09:47:08 -03:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 17698: Do not send pending_checkout_notes from all circ scripts 2018-07-23 15:23:44 +00:00
package.json Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00
rewrite-config.PL Bug 14302: Remove GRS1 specific code 2018-08-31 11:24:20 +00:00
yarn.lock Bug 19474: Convert staff client CSS to SCSS 2018-08-09 15:12:20 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo