Go to file
David Cook f5ac9b281e Bug 32302: Hide "ISBN" label when no ISBN data when sending list
There is a logic mistake in the opac-sendshelf.tt template where
we test if the "ISBN" key exists in the "BIBLIO_RESULT" hash when
we should really be testing if the arrayref returned by "ISBN" is
empty or not, since that "ISBN" key always exists and contains at least
an empty arrayref.

Test plan:
1. Apply patch and restart your Koha Starman
2. Create a public list containing records with 020 MARC fields and
records without 020 MARC fields
3. View the list in the OPAC
4. Click "Send list" and email it to yourself
5. Note that only records with 020 MARC fields with show "ISBN:"
in the email output

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 44366c0985)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 45a53a3d5e)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2023-01-19 22:52:00 +00:00
C4 Bug 32208: Adjust Auth.pm for relogin without perms 2022-12-22 16:20:27 +00:00
Koha Bug 32242: Resolve encoding issue when sending to Net::Stomp 2022-12-21 15:40:07 +00:00
acqui Bug 31459: (follow-up) Preserve budget period display 2022-12-05 22:47:05 +00:00
admin Bug 31976: Incorrect default category selected by authorized values page 2022-12-05 23:37:08 +00:00
api Bug 30982: [22.05.x] Use the REST API for background job list view 2022-11-01 21:40:18 +00:00
authorities Bug 29333: Fix encoding of imported UNIMARC authorities 2022-08-23 15:30:11 +00:00
basket Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes 2022-07-12 15:54:27 +00:00
bin
…
catalogue Bug 30779: Remove _update_import_record_marc and update tests 2022-10-03 22:48:43 +00:00
cataloguing Bug 31873: Check ->find before calling ->safe_delete 2023-01-17 15:39:09 +00:00
circ Bug 28167: Remove uninitialized variable warnings from circ/set-library.pl 2022-10-31 22:41:21 +00:00
clubs Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
course_reserves Bug 30409: barcodedecode() should always trim barcode 2022-07-13 19:44:18 +00:00
debian Bug 31675: Remove packages from debian/control that are no longer used 2023-01-18 21:26:45 +00:00
docs Bug 30808: Add the 22.05 release team. 2022-05-25 23:56:12 -10:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 15048: Index all possible searched subfields for index-term-genre 2022-12-05 22:42:23 +00:00
ill Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
installer Increment version for the 22.05.08 release 2022-12-22 17:18:30 +00:00
koha-tmpl Bug 32302: Hide "ISBN" label when no ISBN data when sending list 2023-01-19 22:52:00 +00:00
labels Bug 31482: Label creator does not call barcodedecode 2022-11-10 23:43:49 +00:00
lib/CGI/Session/Serialize
…
members Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. 2022-12-05 22:38:12 +00:00
misc Update release notes for 22.05.08 release 2022-12-22 18:17:09 +00:00
offline_circ Bug 30525: Items batch modification broken 2022-04-21 13:41:36 -10:00
opac Bug 31739: Password recovery from staff fails if previous expired reset-entry exists. 2022-12-05 22:38:12 +00:00
patron_lists Bug 16446: Add ability to add patrons to list by borrowernumber 2021-10-21 12:24:04 +02:00
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 29787: Add plugin version to plugin search results 2022-04-08 15:49:15 +02:00
pos Bug 28481: (RM follow-up) formatting 2021-12-16 12:13:51 -10:00
recalls Bug 30924: Add missing branchtransfers.reason value for recall cancellation 2022-07-13 19:13:33 +00:00
reports Bug 28967: Patrons with no checkouts report shows patrons from other libraries with IndependentBranches 2022-12-05 20:23:34 +00:00
reserve Bug 31575: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed 2022-12-05 18:06:06 +00:00
reviews
…
rotating_collections
…
serials Bug 29608: Made so doesn't require full permission 2022-10-31 19:55:45 +00:00
services
…
skel
…
suggestion Bug 30127: By default show pending suggestions tab 2022-05-10 23:09:09 -10:00
svc Bug 31682: Silence automatic linker warn 2022-12-05 18:15:20 +00:00
t Bug 32622: Fix Auth.t on D10 2023-01-17 21:06:50 +00:00
tags Bug 29469: (bug 17600 follow-up) Fix tag approval/rejection from staff 2021-11-16 15:49:22 +01:00
tmp/modified_authorities
…
tools Bug 32037: Check for existence of object before building link 2023-01-18 21:14:52 +00:00
virtualshelves Bug 29114: Trim whitespace before the barcode 2022-08-23 19:29:20 +00:00
xt Bug 27619: (QA follow-up) Remove xt/sample_notices.t 2022-05-11 11:28:48 +01:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json
…
.gitignore
…
.htaccess
…
.mailmap 22.05.00: Update mailmap 2022-05-25 23:56:12 -10:00
.perlcriticrc
…
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.scss-lint.yml
…
INSTALL
…
Koha.pm Increment version for the 22.05.08 release 2022-12-22 17:18:30 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 19532: Database and installer stuff 2022-03-14 22:45:50 -10:00
README
…
README.md
…
README.robots
…
about.pl Bug 27667: Display a warning for records missing in Elasticsearch 2022-08-23 19:26:34 +00:00
app.psgi
…
changelanguage.pl
…
cpanfile Bug 31588 - Update cpanfile for new OpenAPI versions (22.05) 2022-12-05 21:23:00 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 30373: Enable translation of UNIMARC frameworks 2022-04-21 13:41:35 -10:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 29020: Add link on the mainpage for users without admin access 2021-10-19 09:29:09 +02:00
package.json
…
rewrite-config.PL
…
yarn.lock
…

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo