gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/opac
History
Jonathan Druart 7e21b1fd2d Bug 21986: Do not escape quotation marks when cataloguing 
In several places we escape quotation marks using
  $value =~ s/"/"/g;
All the occurrences are wrong and must be removed.
Most of them are leftover of bug 11638 (Remove HTML from
addbiblio.pl), which removes the construction of html from pl scripts.

The problem has been highlighted by bug 13618, I did not track down why
the issue did not exist before (?)

Test plan:
0/ Use strings with quotation marks, like:
'Fiddle tune history : "bad" tunes'
You can also use other html characters to make the tests more complete,
like 'Fiddle tune history : <"bad" tunes>'
1/ authorities/authorities.pl
a. Edit an authority filling different fields with quotation marks
b. Edit it again
=> The display (inputs' values) is wrong, if you save the escaped quotes
will be inserted
2/ cataloguing/addbiblio.pl
Same editing a bibliographic record
3/ cataloguing/additem.pl
Same editing items
4/ members/memberentry.pl
Edit a patron's record and fill some fields with quotation marks
+ fields borrowernotes and opacnotes
=> The quotes are inserted directly in DB (escape is done before the
insert!)
5/ opac/opac-review.pl
For QA only: $js_ok_review is never used
6/ tools/batchMod.pl
For QA only: $value is always undefined at that point

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit d561273ef8)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 305729fdc0)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e2cfc2615c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2019-01-02 11:12:37 +01:00
..
clubs Bug 12461 - Add patron clubs feature 2017-04-28 08:37:44 -04:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
external/overdrive bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron 2017-02-21 19:58:20 +00:00
rss
…
sco Bug 17989: Final changes 2017-11-01 13:10:18 -03:00
svc Bug 21115: Add multi_param call and add divider in cache key in svc/report and opac counterpart 2018-11-09 09:33:39 +01:00
ilsdi.pl Bug 13990: ILS-DI LookupPatron requires ID Type 2018-02-02 15:04:08 +00:00
maintenance.pl Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
oai.pl Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
opac-ISBDdetail.pl Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit 2018-02-22 01:05:02 +00:00
opac-MARCdetail.pl Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit 2018-02-22 01:05:02 +00:00
opac-account-pay-paypal-return.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-account-pay-return.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account-pay.pl Bug 19173: Make OPAC online payments pluggable 2017-09-19 14:15:52 -03:00
opac-account.pl Bug 19173: Add opac payment and marc conversion plugins to the pulldown filter list 2017-09-19 14:15:52 -03:00
opac-addbybiblionumber.pl Bug 18262: Koha::Biblio - Remove GetBiblioData - part 1 2017-07-14 12:22:23 -03:00
opac-alert-subscribe.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-article-request-cancel.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
opac-authorities-home.pl Bug 18204 - Authority searches are not saved in Search history 2017-05-28 22:12:01 -04:00
opac-authoritiesdetail.pl Bug 18149: Move CountUsage calls to Koha namespace 2017-09-19 11:47:32 -03:00
opac-basket.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-blocked.pl
…
opac-browser.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-changelanguage.pl Bug 18946 [QA Followup] - code cleanup 2017-09-01 13:02:26 -03:00
opac-course-details.pl
…
opac-course-reserves.pl
…
opac-detail.pl Bug 4319: (QA follow-up) Rename hasItemswaitingOrInTransit to has_items_waiting_or_intransit 2018-02-22 01:05:02 +00:00
opac-discharge.pl Bug 20953: Prevent several discharge requests on OPAC 2018-07-30 14:30:16 +02:00
opac-downloadcart.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-downloadshelf.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-export.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-ics.pl Bug 5456 - Create a link to opac-ics.pl 2016-09-02 15:55:32 +00:00
opac-idref.pl Bug 19640: fix OPAC IdRef webservice display 2017-12-14 11:07:25 +00:00
opac-illrequests.pl Bug 20536: (ILL) authnotrequired should be explicitly unset on opac 2018-05-14 19:30:21 +00:00
opac-image.pl Bug 16154: CGI->multi_param - Manual changes 2016-04-26 23:16:43 +00:00
opac-imageviewer.pl Bug 18260: Koha::Biblio - Remove GetBiblio 2017-07-10 13:03:38 -03:00
opac-issue-note.pl Bug 18915: Fix checkout note email message 2018-01-23 01:25:05 +00:00
opac-main.pl Bug 12001: [17.11.X] Remove simple calls to GetMemberAccountRecords 2018-07-26 12:39:15 +02:00
opac-memberentry.pl Bug 19911: Do not escape html characters when saving passwords 2018-01-23 01:16:14 +00:00
opac-messaging.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-modrequest-suspend.pl
…
opac-modrequest.pl Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
opac-mymessages.pl
…
opac-news-rss.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-overdrive-search.pl Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
opac-passwd.pl Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
opac-password-recovery.pl Bug 21771: (follow-up) Revert the shift statement 2018-11-16 13:47:20 +01:00
opac-patron-image.pl Bug 15635: Koha::Patron::Images - Remove GetPatronImage 2016-03-04 12:54:15 +00:00
opac-privacy.pl Bug 18169: Make 'before' param non mandatory for Koha::Patrons->anonymise_issue_history 2017-03-03 18:16:54 +00:00
opac-ratings-ajax.pl Bug 17089: Improve errors handling 2016-09-09 09:31:30 +00:00
opac-ratings.pl Bug 17089: Improve errors handling 2016-09-09 09:31:30 +00:00
opac-readingrecord.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-registration-verify.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
opac-renew.pl Bug 18572 - QA Followup 2017-07-24 13:38:31 -03:00
opac-request-article.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
opac-reserve.pl Bug 20724: (QA follow-up) Remove two obsolete comment lines 2018-08-27 14:48:40 +02:00
opac-restrictedpage.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
opac-retrieve-file.pl Bug 17501: Move getCategories and httpheaders from Upload.pm 2017-01-20 14:20:05 +00:00
opac-review.pl Bug 21986: Do not escape quotation marks when cataloguing 2019-01-02 11:12:37 +01:00
opac-search-history.pl Bug 12497: Fix OPAC search history reachable by URL even when disabled 2017-12-14 12:04:17 +00:00
opac-search.pl Bug 19502: Retrieve index.max_result_window from ES 2018-07-30 14:14:25 +02:00
opac-sendbasket.pl Bug 21874: Fix encoding of cart and list email subjects 2018-12-19 13:45:31 +01:00
opac-sendshelf.pl Bug 21874: Fix encoding of cart and list email subjects 2018-12-19 13:45:31 +01:00
opac-serial-issues.pl Bug 10357: Do not change the alerttype 2017-04-21 10:58:33 -04:00
opac-shareshelf.pl Bug 20687: (follow-up) Look for invitekey in show_accept and fix error codes 2018-05-22 10:27:12 +00:00
opac-shelves.pl Bug 21629: Use cn_sort instead of itemcallnumber when displaying a list 2018-11-28 11:04:19 +01:00
opac-showmarc.pl Bug 20083: Follow up - use same logic in opac-showmarc 2018-03-26 15:19:26 +00:00
opac-showreviews.pl Bug 19808: Handle deleted reviewers gracefully - opac-showreview 2017-12-21 16:06:54 +00:00
opac-suggestions.pl Bug 20763: Remove unecessary Koha::Patron fetch 2018-06-07 09:16:27 +02:00
opac-tags.pl Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
opac-tags_subject.pl Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
opac-topissues.pl Bug 17835: Replace GetItemTypes with Koha::ItemTypes 2017-04-14 10:43:51 -04:00
opac-user.pl Bug 12001: [17.11.X] Remove simple calls to GetMemberAccountRecords 2018-07-26 12:39:15 +02:00
tracklinks.pl Bug 21018: Allow uris defined in the item 2018-08-28 15:17:48 +02:00
unapi Bug 19439: (follow-up) Remove four spaces from lines 133-149 2017-12-14 18:08:36 +00:00