6eade474ed
The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several reasons: - badly named, we can get biblio info from a barcode - SELECT * from items, biblio and biblioitems makes things hard to follow and debug, we never know where do come from the value we display - sometimes called only for trivial information such as biblionumber, author or title This patchset suggests to replace it with calls to: - Koha::Items->find for item's info - $item->biblio for biblio's info - $item->biblio->biblioitem for biblioitem's info Test plan: Item's info should correctly be displayed on the following pages: - circulation history - transfer book - checkin - waiting holds QA will check the other changes reading the code, it's trivial Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| value_builder | ||
| addbiblio.pl | ||
| addbooks.pl | ||
| additem.pl | ||
| editor.pl | ||
| linkitem.pl | ||
| merge.pl | ||
| merge_ajax.pl | ||
| moveitem.pl | ||
| plugin_launcher.pl | ||
| ysearch.pl | ||
| z3950_auth_search.pl | ||
| z3950_search.pl | ||